New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 661061 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: 2016-11-15
OS: Chrome
Pri: 2
Type: Bug
ARC
Team-Accessibility



Sign in to add a comment

Unable to use keyboard commands with Talkback in Android apps

Reported by ni...@jaberspace.com, Nov 1 2016

Issue description

Mode: force_next
Version: 56.0.2905.0
Reproduction Steps: 
1. Enable CVox Next, and make sure that Android apps are enabled... this works on Google Pixel 2015.
2. Navigate to launcher>>locate playstore (or any other Android app)
3. Attempt to navigate by using Search+right arrow through the Android application.
Expected: The content of the Android app is spoken. This behavior used to occur.
Actual: CVox speaks, and alerts the user of the title of the window without speaking any other content. The window is maximized, and this behavior still occurs consistently.
 
Description: Show this description
Summary: Unable to use keyboard commands with Talkback in Android apps (was: uNABLE TO USE KEYBOARD COMMANDS WITH tALKBACK IN aNDROID APPS)
Cc: yawano@chromium.org
Labels: ARC
Cc: dtseng@chromium.org
Labels: phase4
Owner: yawano@chromium.org
Status: Assigned (was: Unconfirmed)

Comment 5 by dtseng@chromium.org, Nov 15 2016

Labels: Needs-Bisect
NextAction: 2016-11-15
Can someone bisect this issue? Thanks

Comment 6 by yawano@chromium.org, Nov 24 2016

Status: Started (was: Assigned)

Comment 7 by yawano@chromium.org, Nov 24 2016

Cc: dmazz...@chromium.org
Labels: -Needs-Bisect
Status: Assigned (was: Started)
Bisected. First bad commit is https://chromium.googlesource.com/chromium/src/+/33da1a9126ec165972482429ca942a2009d5b66e
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f0cf5b355d668d98b8097e850eb33a9b86a727a

commit 7f0cf5b355d668d98b8097e850eb33a9b86a727a
Author: yawano <yawano@chromium.org>
Date: Fri Dec 09 04:46:23 2016

Add kAccessibilityFocusFallsbackToWidget property

- Added kAccessibilityFocusFallsbackToWidget property to aura::Window.
- Default value of kAccessibilityFocusFallsbackToWidget is true.
- kAccessibilityFocusFallsbackToWidget is set to false for arc window.

BUG= 661061 
TEST=manually tested as described in the issue; User can navigate
     elements in Android window by using TalkBack.
     interactive_ui_tests:SpokenFeedbackTest

Review-Url: https://codereview.chromium.org/2530073002
Cr-Commit-Position: refs/heads/master@{#437469}

[modify] https://crrev.com/7f0cf5b355d668d98b8097e850eb33a9b86a727a/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
[modify] https://crrev.com/7f0cf5b355d668d98b8097e850eb33a9b86a727a/components/exo/shell_surface.cc
[modify] https://crrev.com/7f0cf5b355d668d98b8097e850eb33a9b86a727a/ui/aura/client/aura_constants.cc
[modify] https://crrev.com/7f0cf5b355d668d98b8097e850eb33a9b86a727a/ui/aura/client/aura_constants.h
[modify] https://crrev.com/7f0cf5b355d668d98b8097e850eb33a9b86a727a/ui/views/accessibility/ax_aura_obj_cache.cc

Cc: mitsuji@chromium.org
Labels: Merge-Request-56

Comment 10 by dimu@chromium.org, Dec 10 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 12 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23918093598100679745e8df43a435104a1cab09

commit 23918093598100679745e8df43a435104a1cab09
Author: Yuki Awano <yawano@chromium.org>
Date: Mon Dec 12 07:04:37 2016

Merge to M56: Add kAccessibilityFocusFallsbackToWidget property

TBR=dmazzoni@chromium.org, reveman@chromium.org, sky@chromium.org

Original description:
Add kAccessibilityFocusFallsbackToWidget property

- Added kAccessibilityFocusFallsbackToWidget property to aura::Window.
- Default value of kAccessibilityFocusFallsbackToWidget is true.
- kAccessibilityFocusFallsbackToWidget is set to false for arc window.

BUG= 661061 
TEST=manually tested as described in the issue; User can navigate
     elements in Android window by using TalkBack.
     interactive_ui_tests:SpokenFeedbackTest

Review-Url: https://codereview.chromium.org/2530073002
Cr-Commit-Position: refs/heads/master@{#437469}
(cherry picked from commit 7f0cf5b355d668d98b8097e850eb33a9b86a727a)

Review-Url: https://codereview.chromium.org/2565273003 .
Cr-Commit-Position: refs/branch-heads/2924@{#452}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/23918093598100679745e8df43a435104a1cab09/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
[modify] https://crrev.com/23918093598100679745e8df43a435104a1cab09/components/exo/shell_surface.cc
[modify] https://crrev.com/23918093598100679745e8df43a435104a1cab09/ui/aura/client/aura_constants.cc
[modify] https://crrev.com/23918093598100679745e8df43a435104a1cab09/ui/aura/client/aura_constants.h
[modify] https://crrev.com/23918093598100679745e8df43a435104a1cab09/ui/views/accessibility/ax_aura_obj_cache.cc

Status: Fixed (was: Assigned)
Merged to M56. Marking this as fixed for now.

Comment 13 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 14 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 15 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Status: Verified (was: Fixed)

Sign in to add a comment