New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 661010 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Allow output surface state to be recorded in traces.

Project Member Reported by reve...@chromium.org, Nov 1 2016

Issue description

The output surface state can be used to collect display latency data for clients that are not hooked up to Chromium's latency info mechanism (e.g. Arc++ apps). The state needs to contain vsync time stamp and screenshots of framebuffer and overlay textures.
 
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15aee286dd3b89eb397ff75eda58eafdaf9ad6fd

commit 15aee286dd3b89eb397ff75eda58eafdaf9ad6fd
Author: reveman <reveman@chromium.org>
Date: Fri Nov 04 19:09:20 2016

exo: Connect frame callbacks with UI compositor begin frames.

Frame callbacks are used by simple wayland clients to drive
animations and provide back-pressure when producing frames.

This makes use of begin frame callbacks and the frame timestamps
they provide instead of having these callbacks fire at "WillDraw"
time using the current time.

The result is better timestamps for animations and frames that
are better aligned with UI compositor drawing.

BUG=661010
TEST=wayland-motion-events

Review-Url: https://codereview.chromium.org/2480783002
Cr-Commit-Position: refs/heads/master@{#429968}

[modify] https://crrev.com/15aee286dd3b89eb397ff75eda58eafdaf9ad6fd/components/exo/surface.cc
[modify] https://crrev.com/15aee286dd3b89eb397ff75eda58eafdaf9ad6fd/components/exo/surface.h
[modify] https://crrev.com/15aee286dd3b89eb397ff75eda58eafdaf9ad6fd/components/exo/wayland/clients/motion_events.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27536cb98a4c4ff9c2b7bc3db57a0b0ee4b9dd36

commit 27536cb98a4c4ff9c2b7bc3db57a0b0ee4b9dd36
Author: reveman <reveman@chromium.org>
Date: Fri Nov 04 22:42:28 2016

exo: Remove begin frame observer correctly.

BUG=661010
TEST=wayland-motion-events

Review-Url: https://codereview.chromium.org/2476033002
Cr-Commit-Position: refs/heads/master@{#430041}

[modify] https://crrev.com/27536cb98a4c4ff9c2b7bc3db57a0b0ee4b9dd36/components/exo/surface.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1bef5260e46cd301c41a88a6a7a6f7b581d2ce5f

commit 1bef5260e46cd301c41a88a6a7a6f7b581d2ce5f
Author: reveman <reveman@chromium.org>
Date: Sat Nov 05 00:52:18 2016

exo: Add continuous drawing using skia to motion event client.

Use skia to animate the rotation of a rectangle.

BUG=661010
TEST=wayland-motion-events

Review-Url: https://codereview.chromium.org/2478403002
Cr-Commit-Position: refs/heads/master@{#430104}

[modify] https://crrev.com/1bef5260e46cd301c41a88a6a7a6f7b581d2ce5f/components/exo/wayland/BUILD.gn
[modify] https://crrev.com/1bef5260e46cd301c41a88a6a7a6f7b581d2ce5f/components/exo/wayland/clients/motion_events.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f4793d91932b2c7c9e4d394f9342cd0bfd27368

commit 8f4793d91932b2c7c9e4d394f9342cd0bfd27368
Author: reveman <reveman@chromium.org>
Date: Sat Nov 05 01:56:27 2016

exo: Cleanup and improve event time rendering in motion event client.

BUG=661010
TEST=wayland-motion-events

Review-Url: https://codereview.chromium.org/2475423002
Cr-Commit-Position: refs/heads/master@{#430125}

[modify] https://crrev.com/8f4793d91932b2c7c9e4d394f9342cd0bfd27368/components/exo/wayland/clients/motion_events.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/381ce176825fb27f1ccf9a6bd24980fac3cbd030

commit 381ce176825fb27f1ccf9a6bd24980fac3cbd030
Author: reveman <reveman@chromium.org>
Date: Sun Nov 06 03:51:48 2016

exo: Add useful flags and benchmarking to motion event client.

FPS will now be printed to stdout every 5 seconds and the
following flags have been added:

--size=NxM, specifies the client buffer size.

--scale=N, specifies the client scale factor (ie. number
of physical pixels per DIP).

--num-rects=N, specifies the number of rotating rects to draw.

--fullscreen, specifies if client should be fullscreen.

BUG=661010
TEST=wayland-motion-events

Review-Url: https://codereview.chromium.org/2484503002
Cr-Commit-Position: refs/heads/master@{#430180}

[modify] https://crrev.com/381ce176825fb27f1ccf9a6bd24980fac3cbd030/components/exo/wayland/clients/motion_events.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67808baf1012d79550204d4cb25c4e3a26caa416

commit 67808baf1012d79550204d4cb25c4e3a26caa416
Author: dcastagna <dcastagna@chromium.org>
Date: Mon Nov 07 06:41:51 2016

exo: Add drm support to motion_events.

Add support to render using dmabufs to motion_events wayland
test client.

BUG=661010
TEST=XDG_RUNTIME_DIR=/var/run/chrome /tmp/wayland_motion_events --linux_dmabuf_v1 on kevin.

Review-Url: https://codereview.chromium.org/2477043002
Cr-Commit-Position: refs/heads/master@{#430224}

[modify] https://crrev.com/67808baf1012d79550204d4cb25c4e3a26caa416/components/exo/wayland/BUILD.gn
[modify] https://crrev.com/67808baf1012d79550204d4cb25c4e3a26caa416/components/exo/wayland/clients/motion_events.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33d7e2f3e00011aa6e02ac99896c1622d9aa7b44

commit 33d7e2f3e00011aa6e02ac99896c1622d9aa7b44
Author: perkj <perkj@chromium.org>
Date: Mon Nov 07 07:30:38 2016

Revert of exo: Add drm support to motion_events. (patchset #11 id:240001 of https://codereview.chromium.org/2477043002/ )

Reason for revert:
Seems to break PrecacheFetcherTest.DailyQuot
componnentest on Mac 10.9 and 10.10

https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/31355

Original issue's description:
> exo: Add drm support to motion_events.
>
> Add support to render using dmabufs to motion_events wayland
> test client.
>
> BUG=661010
> TEST=XDG_RUNTIME_DIR=/var/run/chrome /tmp/wayland_motion_events --linux_dmabuf_v1 on kevin.
>
> Committed: https://crrev.com/67808baf1012d79550204d4cb25c4e3a26caa416
> Cr-Commit-Position: refs/heads/master@{#430224}

TBR=reveman@chromium.org,dcastagna@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=661010

Review-Url: https://codereview.chromium.org/2481713002
Cr-Commit-Position: refs/heads/master@{#430230}

[modify] https://crrev.com/33d7e2f3e00011aa6e02ac99896c1622d9aa7b44/components/exo/wayland/BUILD.gn
[modify] https://crrev.com/33d7e2f3e00011aa6e02ac99896c1622d9aa7b44/components/exo/wayland/clients/motion_events.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c8a4fdc731c2d663383b270549ff5af4103ca17

commit 3c8a4fdc731c2d663383b270549ff5af4103ca17
Author: perkj <perkj@chromium.org>
Date: Mon Nov 07 08:01:17 2016

Reland of xo: Add drm support to motion_events. (patchset #1 id:1 of https://codereview.chromium.org/2481713002/ )

Reason for revert:
This cl was not to blame.

Seems like the real problem is due to daylight saving time on the bots.

Original issue's description:
> Revert of exo: Add drm support to motion_events. (patchset #11 id:240001 of https://codereview.chromium.org/2477043002/ )
>
> Reason for revert:
> Seems to break PrecacheFetcherTest.DailyQuot
> componnentest on Mac 10.9 and 10.10
>
> https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/31355
>
> Original issue's description:
> > exo: Add drm support to motion_events.
> >
> > Add support to render using dmabufs to motion_events wayland
> > test client.
> >
> > BUG=661010
> > TEST=XDG_RUNTIME_DIR=/var/run/chrome /tmp/wayland_motion_events --linux_dmabuf_v1 on kevin.
> >
> > Committed: https://crrev.com/67808baf1012d79550204d4cb25c4e3a26caa416
> > Cr-Commit-Position: refs/heads/master@{#430224}
>
> TBR=reveman@chromium.org,dcastagna@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=661010
>
> Committed: https://crrev.com/33d7e2f3e00011aa6e02ac99896c1622d9aa7b44
> Cr-Commit-Position: refs/heads/master@{#430230}

TBR=reveman@chromium.org,dcastagna@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=661010

Review-Url: https://codereview.chromium.org/2481723002
Cr-Commit-Position: refs/heads/master@{#430236}

[modify] https://crrev.com/3c8a4fdc731c2d663383b270549ff5af4103ca17/components/exo/wayland/BUILD.gn
[modify] https://crrev.com/3c8a4fdc731c2d663383b270549ff5af4103ca17/components/exo/wayland/clients/motion_events.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Nov 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/106d9c981130ca2de709c14f368655b56479eb71

commit 106d9c981130ca2de709c14f368655b56479eb71
Author: dcastagna <dcastagna@chromium.org>
Date: Fri Nov 11 19:23:18 2016

exo: Use use-drm flag to pick a driver.

The test wayland_motion_event used had an hardcoded render
node path.
This render node path turned out to use vgem on kevin.

This CL adds logic to allow to specify a string for the flag
use-drm.
The first drm device with a driver name containing the substring
will be picked.

BUG=661010

Review-Url: https://codereview.chromium.org/2488253005
Cr-Commit-Position: refs/heads/master@{#431615}

[modify] https://crrev.com/106d9c981130ca2de709c14f368655b56479eb71/components/exo/wayland/clients/motion_events.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Nov 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d052b1ae3efc8a67a48ef025c82d6cbf8b3e8edd

commit d052b1ae3efc8a67a48ef025c82d6cbf8b3e8edd
Author: reveman <reveman@chromium.org>
Date: Sat Nov 12 02:11:04 2016

exo: Add max frames pending flag and better benchmarking to motion event client.

--max-frames-pending flag can now be used to have the client
queue pending frames.

Synchronization has also been improved to avoid calling glFinish().

Stride is also used correctly with --use-drm flag.

BUG=661010

Review-Url: https://codereview.chromium.org/2477383002
Cr-Commit-Position: refs/heads/master@{#431742}

[modify] https://crrev.com/d052b1ae3efc8a67a48ef025c82d6cbf8b3e8edd/components/exo/wayland/clients/motion_events.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Nov 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/800d00b3c2ca7eedafe5cc9c4be4f56c860875ab

commit 800d00b3c2ca7eedafe5cc9c4be4f56c860875ab
Author: reveman <reveman@chromium.org>
Date: Mon Nov 14 23:26:13 2016

exo: Add FPS counter to motion event client.

This adds a fps counter and event time stamps to the frame
output.

BUG=661010

Review-Url: https://codereview.chromium.org/2498883002
Cr-Commit-Position: refs/heads/master@{#431965}

[modify] https://crrev.com/800d00b3c2ca7eedafe5cc9c4be4f56c860875ab/components/exo/wayland/clients/motion_events.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Nov 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73a9f66a9a89f66628ea6554f33750f3a17fd823

commit 73a9f66a9a89f66628ea6554f33750f3a17fd823
Author: reveman <reveman@chromium.org>
Date: Wed Nov 16 06:37:14 2016

exo: Improve benchmark support in motion event client.

It adds a kBenchmarkWarmupFrames constant and rendering of
a number of frames before we start benchmark measurements.

--benchmark=RUNS can be used to perform a number of
benchmark runs. Each will print the result as a tab
separated list to standard output that is easy to
parse in a shell script. Client will exit after
performing all runs.

--benchmark-interval=MS can be used specify length of
each benchmark run in milliseconds.

BUG=661010

Review-Url: https://codereview.chromium.org/2498153004
Cr-Commit-Position: refs/heads/master@{#432400}

[modify] https://crrev.com/73a9f66a9a89f66628ea6554f33750f3a17fd823/components/exo/wayland/clients/motion_events.cc

Project Member

Comment 14 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad7d1b32f2cef49d966189e14afecce27ad1bad1

commit ad7d1b32f2cef49d966189e14afecce27ad1bad1
Author: reveman <reveman@chromium.org>
Date: Fri Nov 18 16:47:23 2016

exo: Fix benchmark-interval flag in motion events client.

Copy-n-paste mistake caused this flag to not work correctly.

BUG=661010
TBR=dcastagna@chromium.org

Review-Url: https://codereview.chromium.org/2512033004
Cr-Commit-Position: refs/heads/master@{#433218}

[modify] https://crrev.com/ad7d1b32f2cef49d966189e14afecce27ad1bad1/components/exo/wayland/clients/motion_events.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Jan 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/211cf808aabe5487f7db53d7bcc896ff02008dc2

commit 211cf808aabe5487f7db53d7bcc896ff02008dc2
Author: reveman <reveman@chromium.org>
Date: Tue Jan 10 00:30:59 2017

exo: Implement presentation interface.

This implements the wayland presentation interface for
presentation timing feedback. The motion event client
has been updated to use this interface for accurate
display latency measurements.

This also cleans up the Surfce/CompositorFrameSinkHolder
communication slighly and fixes a problem in the motion
event client that prevented it from working without
--use-drm flag on ozone devices.

BUG=661010
TEST=wayland_motion_events

Review-Url: https://codereview.chromium.org/2610513006
Cr-Commit-Position: refs/heads/master@{#442421}

[modify] https://crrev.com/211cf808aabe5487f7db53d7bcc896ff02008dc2/components/exo/compositor_frame_sink_holder.cc
[modify] https://crrev.com/211cf808aabe5487f7db53d7bcc896ff02008dc2/components/exo/compositor_frame_sink_holder.h
[modify] https://crrev.com/211cf808aabe5487f7db53d7bcc896ff02008dc2/components/exo/surface.cc
[modify] https://crrev.com/211cf808aabe5487f7db53d7bcc896ff02008dc2/components/exo/surface.h
[modify] https://crrev.com/211cf808aabe5487f7db53d7bcc896ff02008dc2/components/exo/wayland/BUILD.gn
[modify] https://crrev.com/211cf808aabe5487f7db53d7bcc896ff02008dc2/components/exo/wayland/clients/motion_events.cc
[modify] https://crrev.com/211cf808aabe5487f7db53d7bcc896ff02008dc2/components/exo/wayland/server.cc

Components: OS>Kernel>Graphics

Sign in to add a comment