Add retries |
||
Issue descriptionEmpricial data from our in house testing on Gin2G-poor indicates that we often need several retries to get a page, even if we give it the full 3 minute timeout. Increase the number of retries to give us about 10 minutes on poor connections, and make any other required code changes to get multiple retries working properly.
,
Nov 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cdb23a159c0f4cbd8e18f9b15c878cc20a4ba48d commit cdb23a159c0f4cbd8e18f9b15c878cc20a4ba48d Author: petewil <petewil@chromium.org> Date: Fri Nov 04 00:59:52 2016 Add retries for completed background loading attempts We determined through manual testing that retries are needed for an acceptable page display rate. This adds back the retry limit, set to 3 for now, and has the unit test changes to adapt to the retry limit. Since we now do retries, we set the policy for retries to prefer requests with fewer retries, and among requests with the same number of retries, to prefer earlier requests. This will try the requests in round-robin order so that one troublesome website will not stop the other requests. We also removed the check temporarily allowing completed retries (under the guise of started retries) BUG= 660991 Review-Url: https://codereview.chromium.org/2472593002 Cr-Commit-Position: refs/heads/master@{#429748} [modify] https://crrev.com/cdb23a159c0f4cbd8e18f9b15c878cc20a4ba48d/components/offline_pages/background/offliner_policy.h [modify] https://crrev.com/cdb23a159c0f4cbd8e18f9b15c878cc20a4ba48d/components/offline_pages/background/request_coordinator.cc [modify] https://crrev.com/cdb23a159c0f4cbd8e18f9b15c878cc20a4ba48d/components/offline_pages/background/request_coordinator_unittest.cc
,
Nov 30 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by dougarnett@chromium.org
, Nov 1 2016