New issue
Advanced search Search tips

Issue 660950 link

Starred by 2 users
Status: Archived
Owner: ----
Closed: Nov 2017
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Make X-Mod-Pagespeed header's commit number optional

Project Member Reported by cfredric@google.com, Oct 31 2016 
UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.59 Safari/537.36

Steps to reproduce the problem:
The commit number is currently required in headers following the X-Mod-Pagespeed format.

What is the expected behavior?
A header such as "X-Mod-Pagespeed: 1.2.24.1", which does not include the SVN commit number, should be considered valid.

What went wrong?
The commit number is required.

Did this work before? No 

Chrome version: 54.0.2840.59  Channel: n/a
OS Version: Ubuntu 16.04
Flash Version: Shockwave Flash 23.0 r0
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3028617e93ab30b34c34f5e12008b6e171f909e

commit b3028617e93ab30b34c34f5e12008b6e171f909e
Author: cfredric <cfredric@google.com>
Date: Tue Nov 01 19:40:40 2016

Make the SVN commit number an optional part of X-Mod-Pagespeed header.
Currently, the X-Mod-Pagespeed header format is expected to be
"<major>.<minor>.<branch>.<point>-<commit>", where <commit> is the SVN commit
number. This should not be required; i.e. the format should also be allowed to
be "<major>.<minor>.<branch>.<point>".

BUG= 660950 

Review-Url: https://codereview.chromium.org/2465023002
Cr-Commit-Position: refs/heads/master@{#429075}

[add] https://crrev.com/b3028617e93ab30b34c34f5e12008b6e171f909e/chrome/browser/mod_pagespeed/OWNERS
[modify] https://crrev.com/b3028617e93ab30b34c34f5e12008b6e171f909e/chrome/browser/mod_pagespeed/mod_pagespeed_metrics.cc
[modify] https://crrev.com/b3028617e93ab30b34c34f5e12008b6e171f909e/chrome/browser/mod_pagespeed/mod_pagespeed_metrics_unittest.cc
Project Member

Comment 2 by sheriffbot@chromium.org, Nov 2 2017

Status: Archived (was: Unconfirmed)
Issue has not been modified or commented on in the last 365 days, please re-open or file a new bug if this is still an issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
►

Sign in to add a comment