We should have autocomplete that isn't case sensitive, shows inexact matches, etc.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b667bbde4508a08433cdc5d63f68f6c475231a6f commit b667bbde4508a08433cdc5d63f68f6c475231a6f Author: einbinder <einbinder@chromium.org> Date: Thu Nov 03 08:10:35 2016 DevTools: Consolidate completion code into JavaScriptAutocomplete.js BUG= 660941 Review-Url: https://codereview.chromium.org/2471243002 Cr-Commit-Position: refs/heads/master@{#429537} [modify] https://crrev.com/b667bbde4508a08433cdc5d63f68f6c475231a6f/third_party/WebKit/LayoutTests/http/tests/inspector/console-cd-completions.html [modify] https://crrev.com/b667bbde4508a08433cdc5d63f68f6c475231a6f/third_party/WebKit/LayoutTests/inspector/console/console-correct-suggestions.html [modify] https://crrev.com/b667bbde4508a08433cdc5d63f68f6c475231a6f/third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-completions-on-call-frame.html [modify] https://crrev.com/b667bbde4508a08433cdc5d63f68f6c475231a6f/third_party/WebKit/Source/devtools/BUILD.gn [modify] https://crrev.com/b667bbde4508a08433cdc5d63f68f6c475231a6f/third_party/WebKit/Source/devtools/front_end/components/ExecutionContextSelector.js [add] https://crrev.com/b667bbde4508a08433cdc5d63f68f6c475231a6f/third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js [modify] https://crrev.com/b667bbde4508a08433cdc5d63f68f6c475231a6f/third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js [modify] https://crrev.com/b667bbde4508a08433cdc5d63f68f6c475231a6f/third_party/WebKit/Source/devtools/front_end/components/module.json [modify] https://crrev.com/b667bbde4508a08433cdc5d63f68f6c475231a6f/third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js [modify] https://crrev.com/b667bbde4508a08433cdc5d63f68f6c475231a6f/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f86e28c9e681f4b9d252c6a555a973f8403a7e3 commit 8f86e28c9e681f4b9d252c6a555a973f8403a7e3 Author: einbinder <einbinder@chromium.org> Date: Thu Nov 03 22:16:25 2016 DevTools: Rename prefix to query in the context of autocomplete This is in preparation of autocomplete that doesn't just use the prefix to filter completions, but instead might search in the middle of completions. BUG= 660941 Review-Url: https://codereview.chromium.org/2474143002 Cr-Commit-Position: refs/heads/master@{#429711} [modify] https://crrev.com/8f86e28c9e681f4b9d252c6a555a973f8403a7e3/third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js [modify] https://crrev.com/8f86e28c9e681f4b9d252c6a555a973f8403a7e3/third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js [modify] https://crrev.com/8f86e28c9e681f4b9d252c6a555a973f8403a7e3/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js [modify] https://crrev.com/8f86e28c9e681f4b9d252c6a555a973f8403a7e3/third_party/WebKit/Source/devtools/front_end/text_editor/TextEditorAutocompleteController.js [modify] https://crrev.com/8f86e28c9e681f4b9d252c6a555a973f8403a7e3/third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js [modify] https://crrev.com/8f86e28c9e681f4b9d252c6a555a973f8403a7e3/third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js [modify] https://crrev.com/8f86e28c9e681f4b9d252c6a555a973f8403a7e3/third_party/WebKit/Source/devtools/front_end/ui/suggestBox.css
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c2e553e4b38ed65bf11045c2e61895dc625e3dd5 commit c2e553e4b38ed65bf11045c2e61895dc625e3dd5 Author: einbinder <einbinder@chromium.org> Date: Fri Nov 04 06:55:37 2016 DevTools: Substring autocomplete in Console and StylesSideBar. Case insensitive matching as well as matching user entered text in the middle of a suggestion. BUG= 660941 Review-Url: https://codereview.chromium.org/2478563002 Cr-Commit-Position: refs/heads/master@{#429819} [modify] https://crrev.com/c2e553e4b38ed65bf11045c2e61895dc625e3dd5/third_party/WebKit/LayoutTests/inspector/console/console-correct-suggestions-expected.txt [modify] https://crrev.com/c2e553e4b38ed65bf11045c2e61895dc625e3dd5/third_party/WebKit/LayoutTests/inspector/console/console-correct-suggestions.html [modify] https://crrev.com/c2e553e4b38ed65bf11045c2e61895dc625e3dd5/third_party/WebKit/LayoutTests/inspector/elements/styles-3/style-autocomplete-expected.txt [modify] https://crrev.com/c2e553e4b38ed65bf11045c2e61895dc625e3dd5/third_party/WebKit/LayoutTests/inspector/elements/styles-3/style-autocomplete.html [modify] https://crrev.com/c2e553e4b38ed65bf11045c2e61895dc625e3dd5/third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js [modify] https://crrev.com/c2e553e4b38ed65bf11045c2e61895dc625e3dd5/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js [modify] https://crrev.com/c2e553e4b38ed65bf11045c2e61895dc625e3dd5/third_party/WebKit/Source/devtools/front_end/text_editor/TextEditorAutocompleteController.js [modify] https://crrev.com/c2e553e4b38ed65bf11045c2e61895dc625e3dd5/third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js [modify] https://crrev.com/c2e553e4b38ed65bf11045c2e61895dc625e3dd5/third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a7fe92e0e53bd505ef6893a6d148f50d144db4a commit 1a7fe92e0e53bd505ef6893a6d148f50d144db4a Author: einbinder <einbinder@chromium.org> Date: Sat Nov 05 07:57:29 2016 DevTools: Don't show autocomplete when the user is typing a number Any time the user typed 3, we would show a suggestion for Float32Array. BUG= 660941 Review-Url: https://codereview.chromium.org/2479943002 Cr-Commit-Position: refs/heads/master@{#430157} [modify] https://crrev.com/1a7fe92e0e53bd505ef6893a6d148f50d144db4a/third_party/WebKit/LayoutTests/inspector/console/console-correct-suggestions-expected.txt [modify] https://crrev.com/1a7fe92e0e53bd505ef6893a6d148f50d144db4a/third_party/WebKit/LayoutTests/inspector/console/console-correct-suggestions.html [modify] https://crrev.com/1a7fe92e0e53bd505ef6893a6d148f50d144db4a/third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b80ee94906688a5b57690631ecc89e398e5e1fbe commit b80ee94906688a5b57690631ecc89e398e5e1fbe Author: einbinder <einbinder@chromium.org> Date: Fri Nov 11 08:52:42 2016 DevTools: Ghost text shouldn't affect textWithCurrentSuggestion Before, textWithCurrentSuggestion was really textWithGhostText. You can have autocomplete without ghost text now, so it wasn't always accurate. With this patch, scrolling through the styles sidebar always applies the current suggestion even if there is no ghost text. BUG= 660941 Review-Url: https://codereview.chromium.org/2489403002 Cr-Commit-Position: refs/heads/master@{#431528} [modify] https://crrev.com/b80ee94906688a5b57690631ecc89e398e5e1fbe/third_party/WebKit/LayoutTests/http/tests/inspector-unit/text-prompt-expected.txt [modify] https://crrev.com/b80ee94906688a5b57690631ecc89e398e5e1fbe/third_party/WebKit/LayoutTests/http/tests/inspector-unit/text-prompt.html [modify] https://crrev.com/b80ee94906688a5b57690631ecc89e398e5e1fbe/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js [modify] https://crrev.com/b80ee94906688a5b57690631ecc89e398e5e1fbe/third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js
Comment 1 by bugdroid1@chromium.org
, Nov 3 2016