WebRTC's Chromium bots are failing on the compile step. |
|||
Issue descriptionSince https://codereview.webrtc.org/2441383002 was imported into Chromium by https://codereview.chromium.org/2461923002 the WebRTC Chromium bot has been failing to compile, with the error: ninja: error: unknown target 'frame_analyzer' This can be tested locally on an updated chromium checkout by running: gn gen out/gn ninja -C out/gn frame_analyzer
,
Nov 1 2016
You're probably right that my WebRTC CL combined with https://codereview.chromium.org/2409303003/ made the frame_analyzer target no longer getting generated in Chromium. I have a fix in progress that makes it become a part of the gn_all target: https://codereview.chromium.org/2462933003/
,
Nov 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b1ab7b84734e30b086053e8791f19f4af18b781d commit b1ab7b84734e30b086053e8791f19f4af18b781d Author: kjellander <kjellander@chromium.org> Date: Tue Nov 01 08:34:21 2016 Make gn_all depend on frame_analyzer. After https://codereview.chromium.org/2409303003/ it seems webrtc/tools/BUILD.gn is no longer processed so it's not possible to build the frame_analyzer target as we used to do for our custom WebRTC testers that runs video quality tests. BUG= 660937 TBR=dpranke@chromium.org Review-Url: https://codereview.chromium.org/2462933003 Cr-Commit-Position: refs/heads/master@{#428962} [modify] https://crrev.com/b1ab7b84734e30b086053e8791f19f4af18b781d/BUILD.gn
,
Nov 1 2016
Fix seems to work. Compilation is in progress and the builders should cycle green: https://build.chromium.org/p/chromium.webrtc/builders/Linux%20Builder/builds/86245/steps/compile/logs/stdio Next time, let's try to detect errors like this earlier!
,
Nov 15 2016
[bulk-edit : please ignore if not applicable] Could you please set the correct milestone for this issue? |
|||
►
Sign in to add a comment |
|||
Comment 1 by ehmaldonado@chromium.org
, Oct 31 2016