New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 660934 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , All
Pri: 3
Type: Feature



Sign in to add a comment

Remove support for reporting experiment IDs to google update.

Project Member Reported by jwd@chromium.org, Oct 31 2016

Issue description

We will no longer support reporting experiment IDs to the google update service. We will remove handling of google_update_experiment_id from the seed data.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 8 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/f629b9f2f88f74e6169fe24199040f9675748ca1

commit f629b9f2f88f74e6169fe24199040f9675748ca1
Author: rohitrao <rohitrao@google.com>
Date: Tue Nov 08 17:50:26 2016

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab5de4d2557d497cc47b9d4f9b67fc64474ca99f

commit ab5de4d2557d497cc47b9d4f9b67fc64474ca99f
Author: jwd <jwd@chromium.org>
Date: Fri Nov 11 20:33:16 2016

Removing Variations support for google_update_experiment_id, and clearing the them from the Google Update experiment labels registry value.

BUG= 660934 

Review-Url: https://codereview.chromium.org/2465003002
Cr-Commit-Position: refs/heads/master@{#431623}

[modify] https://crrev.com/ab5de4d2557d497cc47b9d4f9b67fc64474ca99f/chrome/browser/BUILD.gn
[modify] https://crrev.com/ab5de4d2557d497cc47b9d4f9b67fc64474ca99f/chrome/browser/metrics/variations/chrome_variations_service_client.cc
[modify] https://crrev.com/ab5de4d2557d497cc47b9d4f9b67fc64474ca99f/chrome/browser/metrics/variations/chrome_variations_service_client.h
[delete] https://crrev.com/d17ffd41bac39d40a9f351929f1a87ace0775961/chrome/browser/metrics/variations/variations_registry_syncer_win.cc
[delete] https://crrev.com/d17ffd41bac39d40a9f351929f1a87ace0775961/chrome/browser/metrics/variations/variations_registry_syncer_win.h
[modify] https://crrev.com/ab5de4d2557d497cc47b9d4f9b67fc64474ca99f/chrome/browser/sync/sessions/sessions_sync_manager_unittest.cc
[modify] https://crrev.com/ab5de4d2557d497cc47b9d4f9b67fc64474ca99f/components/variations/experiment_labels.cc
[modify] https://crrev.com/ab5de4d2557d497cc47b9d4f9b67fc64474ca99f/components/variations/experiment_labels.h
[modify] https://crrev.com/ab5de4d2557d497cc47b9d4f9b67fc64474ca99f/components/variations/experiment_labels_unittest.cc
[modify] https://crrev.com/ab5de4d2557d497cc47b9d4f9b67fc64474ca99f/components/variations/proto/study.proto
[modify] https://crrev.com/ab5de4d2557d497cc47b9d4f9b67fc64474ca99f/components/variations/variations_associated_data.cc
[modify] https://crrev.com/ab5de4d2557d497cc47b9d4f9b67fc64474ca99f/components/variations/variations_associated_data.h
[modify] https://crrev.com/ab5de4d2557d497cc47b9d4f9b67fc64474ca99f/components/variations/variations_associated_data_unittest.cc
[modify] https://crrev.com/ab5de4d2557d497cc47b9d4f9b67fc64474ca99f/components/variations/variations_seed_processor.cc
[modify] https://crrev.com/ab5de4d2557d497cc47b9d4f9b67fc64474ca99f/tools/metrics/histograms/histograms.xml

Labels: M-56 OS-Windows
Status: Fixed (was: Started)
Looks like this landed for Chrome 56.0.2917.0. We just forgot to close the bug.

Sign in to add a comment