New issue
Advanced search Search tips

Issue 660930 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Feature

Blocking:
issue 553459
issue 662122



Sign in to add a comment

MessagePumpWin Refactor

Project Member Reported by robliao@chromium.org, Oct 31 2016

Issue description

This issue tracks...
1) MessagePumpWin using base/MessageWindow
2) Refactor of MessagePumpWin into utilities consumable by other work loops (SchedulerWorker)

 

Comment 1 by gab@chromium.org, Nov 3 2016

Blocking: 662122
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3502f997323b3dabfa9cee0f581d0deba8b5f689

commit 3502f997323b3dabfa9cee0f581d0deba8b5f689
Author: robliao <robliao@chromium.org>
Date: Fri Nov 04 17:46:51 2016

Remove USER32 Function Pointer Loading from MessagePumpWin

Even with regular functions, chrome_elf doesn't pull in user32.

BUG= 660930 

Review-Url: https://codereview.chromium.org/2457393005
Cr-Commit-Position: refs/heads/master@{#429943}

[modify] https://crrev.com/3502f997323b3dabfa9cee0f581d0deba8b5f689/base/message_loop/message_pump_win.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9470e5bdcc0dd613dd5cc1d1ffac3d8a1eac8876

commit 9470e5bdcc0dd613dd5cc1d1ffac3d8a1eac8876
Author: robliao <robliao@chromium.org>
Date: Wed Nov 09 03:13:41 2016

Switch MessagePumpWin to use base::win::MessageWindow

This removes MessagePumpWin's own message window implementation in favor
of MessageWindow's implementation.

This was previously attempted as
https://chromium.googlesource.com/chromium/src/+/bddd3f69e0533c7d51f1bf041434053e2a56913e
but it seems to work fine now.

BUG= 660930 

Review-Url: https://codereview.chromium.org/2488843002
Cr-Commit-Position: refs/heads/master@{#430838}

[modify] https://crrev.com/9470e5bdcc0dd613dd5cc1d1ffac3d8a1eac8876/base/message_loop/message_pump_win.cc
[modify] https://crrev.com/9470e5bdcc0dd613dd5cc1d1ffac3d8a1eac8876/base/message_loop/message_pump_win.h

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/679a57d34267cd7e46e0a15da2dcdd71d76264a1

commit 679a57d34267cd7e46e0a15da2dcdd71d76264a1
Author: robliao <robliao@chromium.org>
Date: Thu Nov 10 23:12:35 2016

Remove CallMsgFilter from MessagePumpWin

kMessageFilterCode is defined locally in message_pump_win.cc.
CallMsgFilter is called with this parameter so that WH_SYSMSGFILTER
and WH_MSGFILTER hooks can look for them.

1) By construction, no hooks can look for kMessageFilterCode since
   there are no hooks in message_pump_win.cc. No other components
   can look for kMessageFilterCode since it is defined locally to
   message_pump_win.cc

2) WH_SYSMSGFILTER and WH_MSGFILTER do not occur anywhere in the
   Chromium codebase.

As a result, we do not need this call in our message pump anymore.

History:
Introduced for dragging a virtual file out of the browser.
https://chromium.googlesource.com/chromium/src/+/6aa4a1c041ca9bd2c3087c3c059a87193b1a82e1
chrome/browser/views/tab_contents/tab_contents_drag_win.cc

Moved To
* chrome/browser/ui/views/tab_contents/tab_contents_drag_win.cc [1]
* content/browser/tab_contents/web_contents_drag_win.cc [2]
* content/browser/web_contents/web_contents_drag_win.cc [3]

[1] https://chromium.googlesource.com/chromium/src/+/213dac2f0bff9162502fe325b6ebb85a255efcb2
[2] https://chromium.googlesource.com/chromium/src/+/95f072f9ce35f0ecd2cbf899de96fa9448aa1285
[3] https://chromium.googlesource.com/chromium/src/+/0c4e92e6434bb8936aca2e03fe8d44201cb51089

Deleted in
https://chromium.googlesource.com/chromium/src/+/2ceee8f17b6fa286d37f0e9190fed01e5f6a9eff
The associated hook code was not migrated to a different file in this
change.

The WH_MSGFILTER unit test for MessageLoopWin was removed in
https://chromium.googlesource.com/chromium/src/+/e73d0300622dbaf3af59863ed1b1370fa76cfdc7

BUG= 660930 

Review-Url: https://codereview.chromium.org/2491403004
Cr-Commit-Position: refs/heads/master@{#431391}

[modify] https://crrev.com/679a57d34267cd7e46e0a15da2dcdd71d76264a1/base/message_loop/message_pump_win.cc

Status: Fixed (was: Started)
This is done for now!

Sign in to add a comment