New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 660909 link

Starred by 1 user
Status: Fixed
Owner:
dalecur...@chromium.org
Closed: Nov 2017
Cc:
█ w...@chromium.org
xhw...@chromium.org
mcasas@chromium.org
dalecur...@chromium.org
█ erickung@chromium.org
█ x...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Clean up dependency on media/base

Project Member Reported by xhw...@chromium.org, Oct 31 2016 
"//media/base" is a source_set in component build [1], and is already part of the "media" target.

I've seen multiple times people want to have some other target depending on "//media/base", while it also depends on "media", causing ODR violations.

This is usually controlled by "visibility" rules. However, today "//media/base" is visible to all targets in //media/* [2]. Given the fact that we have so many different targets in //media/*, e.g. media_remoting, media_blink, media_mojo, capture, etc, this rule seems too loose.

This is also causing some other trouble for capture code, see [3] and [4].

[1] https://cs.chromium.org/chromium/src/media/base/BUILD.gn?rcl=0&l=26
[2] https://cs.chromium.org/chromium/src/media/base/BUILD.gn?rcl=0&l=32
[3] https://cs.chromium.org/chromium/src/media/capture/BUILD.gn?rcl=0&l=102
[4] https://bugs.chromium.org/p/chromium/issues/detail?id=590017#c6
Project Member

Comment 1 by sheriffbot@chromium.org, Nov 1 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by dalecur...@chromium.org, Nov 1 2017

Owner: dalecur...@chromium.org
Status: Fixed (was: Untriaged)
Fixed with the gn check work a couple months ago I think.
►

Sign in to add a comment