New issue
Advanced search Search tips

Issue 660907 link

Starred by 1 user
Status: Fixed
Owner:
yigu@chromium.org
Closed: Nov 2017
Cc:
sahel@chromium.org
tdres...@chromium.org
bokan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

Add more specific metrics for main thread scrolling reasons due to low dpi LCD text.

Project Member Reported by flackr@chromium.org, Oct 31 2016 
With issue 626200 and  issue 381840 , we are / will be automatically promoting elements which can retain LCD text to maintain composited scrolling. However, there are several conditions under which we currently cannot promote, but could with some work.

We should replace the broad main thread reasons of non layer viewport constrained objects and non fast scrollable reason with the more specific reasons which are preventing us from compositing them so that we can prioritize, e.g.:
- Transparent background
- Border radius
- Transform
- Custom scrollbars
- Box shadow
- Clip
- Translucent border
- Multiple background attachments

Comment 1 by tdres...@chromium.org, Oct 31 2016

Cc: sahel@chromium.org

Comment 2 by yigu@chromium.org, Nov 18 2016

Status: Started (was: Assigned)

Comment 3 by yigu@chromium.org, Dec 12 2016

Cc: bokan@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e92b679fee2d010570bb1ea1896b443d01eb5a84

commit e92b679fee2d010570bb1ea1896b443d01eb5a84
Author: yigu <yigu@chromium.org>
Date: Wed Dec 21 00:10:25 2016

We should replace the broad main thread reasons of non layer viewport constrained objects and non fast scrollable reason with the more specific reasons which are preventing us from compositing them so that we can prioritize.
BUG= 660907 
TEST=ScrollingCoordinatorTest.MainThreadScrollingReasonDueToLayoutObject
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2565223002
Cr-Commit-Position: refs/heads/master@{#439944}

[modify] https://crrev.com/e92b679fee2d010570bb1ea1896b443d01eb5a84/cc/input/main_thread_scrolling_reason.h
[modify] https://crrev.com/e92b679fee2d010570bb1ea1896b443d01eb5a84/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/e92b679fee2d010570bb1ea1896b443d01eb5a84/third_party/WebKit/Source/core/frame/FrameView.h
[modify] https://crrev.com/e92b679fee2d010570bb1ea1896b443d01eb5a84/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/e92b679fee2d010570bb1ea1896b443d01eb5a84/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h
[modify] https://crrev.com/e92b679fee2d010570bb1ea1896b443d01eb5a84/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp
[add] https://crrev.com/e92b679fee2d010570bb1ea1896b443d01eb5a84/third_party/WebKit/Source/web/tests/data/two_transparent_scrollable_area.html
[modify] https://crrev.com/e92b679fee2d010570bb1ea1896b443d01eb5a84/tools/metrics/histograms/histograms.xml
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c302a98ceb085bf25d0c004e666d64fd4c3ee9f6

commit c302a98ceb085bf25d0c004e666d64fd4c3ee9f6
Author: yigu <yigu@chromium.org>
Date: Fri Jan 06 17:09:02 2017

Clip related property and border radius are now recorded for UMA

BUG= 660907 
TEST=StyleRelatedMainThreadScrollingReasonTest.ClipPathTest;
StyleRelatedMainThreadScrollingReasonTest.ClipTest;
StyleRelatedMainThreadScrollingReasonTest.BorderRadiusTest
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2613743002
Cr-Commit-Position: refs/heads/master@{#441954}

[modify] https://crrev.com/c302a98ceb085bf25d0c004e666d64fd4c3ee9f6/cc/input/main_thread_scrolling_reason.h
[modify] https://crrev.com/c302a98ceb085bf25d0c004e666d64fd4c3ee9f6/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/c302a98ceb085bf25d0c004e666d64fd4c3ee9f6/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp
[modify] https://crrev.com/c302a98ceb085bf25d0c004e666d64fd4c3ee9f6/third_party/WebKit/Source/web/tests/data/two_scrollable_area.html
[modify] https://crrev.com/c302a98ceb085bf25d0c004e666d64fd4c3ee9f6/tools/metrics/histograms/histograms.xml

Comment 7 by flackr@chromium.org, Jan 24 2017

Labels: -Hotlist-Threaded-Rendering Hotlist-ThreadedRendering
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c83ddee4e5dcb0fdce873021c2701c9c3a2c547a

commit c83ddee4e5dcb0fdce873021c2701c9c3a2c547a
Author: yigu <yigu@chromium.org>
Date: Tue Jan 24 15:11:45 2017

Box shadow should be recorded as main thread scrolling reasons for non-root layers.

BUG= 660907 
TEST=StyleRelatedMainThreadScrollingReasonTest.BoxShadowTest
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2638013002
Cr-Commit-Position: refs/heads/master@{#445728}

[modify] https://crrev.com/c83ddee4e5dcb0fdce873021c2701c9c3a2c547a/cc/input/main_thread_scrolling_reason.h
[modify] https://crrev.com/c83ddee4e5dcb0fdce873021c2701c9c3a2c547a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
[modify] https://crrev.com/c83ddee4e5dcb0fdce873021c2701c9c3a2c547a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h
[modify] https://crrev.com/c83ddee4e5dcb0fdce873021c2701c9c3a2c547a/third_party/WebKit/Source/core/paint/PaintLayer.cpp
[modify] https://crrev.com/c83ddee4e5dcb0fdce873021c2701c9c3a2c547a/third_party/WebKit/Source/core/paint/PaintLayer.h
[modify] https://crrev.com/c83ddee4e5dcb0fdce873021c2701c9c3a2c547a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/c83ddee4e5dcb0fdce873021c2701c9c3a2c547a/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp
[modify] https://crrev.com/c83ddee4e5dcb0fdce873021c2701c9c3a2c547a/third_party/WebKit/Source/web/tests/data/two_scrollable_area.html
[modify] https://crrev.com/c83ddee4e5dcb0fdce873021c2701c9c3a2c547a/tools/metrics/histograms/histograms.xml
Project Member

Comment 9 by bugdroid1@chromium.org, Feb 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d1a8d1c963cae739551639bcec3e4b2e15b9b10

commit 3d1a8d1c963cae739551639bcec3e4b2e15b9b10
Author: yigu <yigu@chromium.org>
Date: Thu Feb 16 14:40:37 2017

Reland with conflict fixed

BUG= 660907 
TEST=StyleRelatedMainThreadScrollingReasonTest.BoxShadowTest
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2700613002
Cr-Commit-Position: refs/heads/master@{#450958}

[modify] https://crrev.com/3d1a8d1c963cae739551639bcec3e4b2e15b9b10/cc/input/main_thread_scrolling_reason.h
[modify] https://crrev.com/3d1a8d1c963cae739551639bcec3e4b2e15b9b10/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
[modify] https://crrev.com/3d1a8d1c963cae739551639bcec3e4b2e15b9b10/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h
[modify] https://crrev.com/3d1a8d1c963cae739551639bcec3e4b2e15b9b10/third_party/WebKit/Source/core/paint/PaintLayer.cpp
[modify] https://crrev.com/3d1a8d1c963cae739551639bcec3e4b2e15b9b10/third_party/WebKit/Source/core/paint/PaintLayer.h
[modify] https://crrev.com/3d1a8d1c963cae739551639bcec3e4b2e15b9b10/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/3d1a8d1c963cae739551639bcec3e4b2e15b9b10/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp
[modify] https://crrev.com/3d1a8d1c963cae739551639bcec3e4b2e15b9b10/third_party/WebKit/Source/web/tests/data/two_scrollable_area.html
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2605f2b320fe9d3d9fbe4d00964fa784a1b6ab16

commit 2605f2b320fe9d3d9fbe4d00964fa784a1b6ab16
Author: yigu <yigu@chromium.org>
Date: Fri Apr 28 20:51:30 2017

Record non-stacking-context as main thread scrolling reasons

There is another common main thread scrolling reason that needs
to be added. A scrollable area with an opaque background
is not a stacking context therefore we don't composite it for
now.

BUG= 660907 
TEST=ScrollingCoordinatorTest.StackingContextTest
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2841603003
Cr-Commit-Position: refs/heads/master@{#468122}

[modify] https://crrev.com/2605f2b320fe9d3d9fbe4d00964fa784a1b6ab16/cc/input/main_thread_scrolling_reason.h
[modify] https://crrev.com/2605f2b320fe9d3d9fbe4d00964fa784a1b6ab16/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/2605f2b320fe9d3d9fbe4d00964fa784a1b6ab16/third_party/WebKit/Source/web/tests/ScrollMetricsTest.cpp
[modify] https://crrev.com/2605f2b320fe9d3d9fbe4d00964fa784a1b6ab16/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp
[modify] https://crrev.com/2605f2b320fe9d3d9fbe4d00964fa784a1b6ab16/tools/metrics/histograms/histograms.xml

Comment 11 by yigu@chromium.org, May 8 2017

Labels: -Type-Bug Type-Feature

Comment 12 by yigu@chromium.org, Nov 17 2017

Status: Fixed (was: Started)
►

Sign in to add a comment