New issue
Advanced search Search tips

Issue 660890 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Move Blink-related shell tab-completion to a common location.

Project Member Reported by qyears...@chromium.org, Oct 31 2016

Issue description

There is currently some shell tab-completion related code in Tools/Scripts/webkit-tools-completion.sh which could potentially be moved to tools/bash-completion.
 
Cc: qyears...@chromium.org
Labels: Hotlist-CodeHealth
Owner: ----
Status: Available (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85380c97c1bc176e8f40f0649cf21e419d036316

commit 85380c97c1bc176e8f40f0649cf21e419d036316
Author: qyearsley <qyearsley@chromium.org>
Date: Fri Jan 27 02:46:20 2017

Move webkit-patch bash completion to tools/bash-completion.

Most of the contents of webkit-tools-completion.sh is now irrelevant,
but there was some logic for webkit-patch command completion there.

This CL doesn't copy it over, but adds some basic completion for
webkit-patch to tools/bash-completion.

Thanks to lukasza@, there is already completion for run-webkit-tests
there (added in https://codereview.chromium.org/2435893002).

This also makes a minor change to bash-completion to make it work
for zsh as well (if $BASH_SOURCE is undefined, use $0 instead).

BUG= 660890 

Review-Url: https://codereview.chromium.org/2657943006
Cr-Commit-Position: refs/heads/master@{#446551}

[delete] https://crrev.com/d972055a588d9e8bd85e8b09faa8f73c0822cb21/third_party/WebKit/Tools/Scripts/webkit-tools-completion.sh
[modify] https://crrev.com/85380c97c1bc176e8f40f0649cf21e419d036316/tools/bash-completion

Owner: qyears...@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment