New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 660886 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
inactive
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 659155



Sign in to add a comment

Hookup aura-mus to real compositor

Project Member Reported by sky@chromium.org, Oct 31 2016

Issue description

Right now it's not binding to a mus surface correctly.
 

Comment 1 by sky@chromium.org, Oct 31 2016

Labels: Proj-Mustash-Mus Proj-Mustash-Mash

Comment 2 by sky@chromium.org, Oct 31 2016

Labels: OS-Chrome
Components: Internals>MUS
Labels: Proj-Mustash-Milestone-Tadpole Proj-Mustash-Mash-WM Proj-Mustash-Mus-WS
Cc: rjkroege@chromium.org
Extreme bikeshedding, we're trying to converge on the term "CompositorFrameSink" in Mus+Ash and Chrome because "surface" is a over-overloaded term :-)
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3364e66eca1f71f542c2d9937acbf5ec288fcdc6

commit 3364e66eca1f71f542c2d9937acbf5ec288fcdc6
Author: mfomitchev <mfomitchev@chromium.org>
Date: Wed Nov 02 23:23:36 2016

Enabling Aura-Mus clients to submit frames to Mus.

- Copying GPUService, WindowCompositorFrameSink, and supporting classes
  from services/ui/public/cpp/ to ui/aura/mus.
- Adding RequestCompositorFrameSink to WindowPortMus.
- Making SurfaceContextFactory work with Aura-Mus. Instead of getting
  ui::Window from the ui::Compositor, it uses AcceleratedWidget to find
  WTH and the corresponding root window.
- Ditto for GpuProcessTransportFactory
- SurfaceContextFactory, GpuProcessTransportFactory, and
  MusBrowserCompositorOutputSurface are made to work with both Aura-Mus
  as well as the old client library. This results in a bit of an awkward
  code with a few icky "ifs", but this is temporary until we get rid of
  the old client lib completely.
- Aura gets a few new deps, including cc, and gpu.

BUG= 660886 

Review-Url: https://codereview.chromium.org/2464123003
Cr-Commit-Position: refs/heads/master@{#429448}

[modify] https://crrev.com/3364e66eca1f71f542c2d9937acbf5ec288fcdc6/content/browser/compositor/gpu_process_transport_factory.cc
[modify] https://crrev.com/3364e66eca1f71f542c2d9937acbf5ec288fcdc6/content/browser/compositor/mus_browser_compositor_output_surface.cc
[modify] https://crrev.com/3364e66eca1f71f542c2d9937acbf5ec288fcdc6/content/browser/compositor/mus_browser_compositor_output_surface.h
[modify] https://crrev.com/3364e66eca1f71f542c2d9937acbf5ec288fcdc6/mojo/public/cpp/bindings/sync_call_restrictions.h
[modify] https://crrev.com/3364e66eca1f71f542c2d9937acbf5ec288fcdc6/ui/aura/BUILD.gn
[add] https://crrev.com/3364e66eca1f71f542c2d9937acbf5ec288fcdc6/ui/aura/mus/DEPS
[add] https://crrev.com/3364e66eca1f71f542c2d9937acbf5ec288fcdc6/ui/aura/mus/gpu_memory_buffer_impl.cc
[add] https://crrev.com/3364e66eca1f71f542c2d9937acbf5ec288fcdc6/ui/aura/mus/gpu_memory_buffer_impl.h
[add] https://crrev.com/3364e66eca1f71f542c2d9937acbf5ec288fcdc6/ui/aura/mus/gpu_service.cc
[add] https://crrev.com/3364e66eca1f71f542c2d9937acbf5ec288fcdc6/ui/aura/mus/gpu_service.h
[add] https://crrev.com/3364e66eca1f71f542c2d9937acbf5ec288fcdc6/ui/aura/mus/mojo_gpu_memory_buffer.cc
[add] https://crrev.com/3364e66eca1f71f542c2d9937acbf5ec288fcdc6/ui/aura/mus/mojo_gpu_memory_buffer.h
[add] https://crrev.com/3364e66eca1f71f542c2d9937acbf5ec288fcdc6/ui/aura/mus/mojo_gpu_memory_buffer_manager.cc
[add] https://crrev.com/3364e66eca1f71f542c2d9937acbf5ec288fcdc6/ui/aura/mus/mojo_gpu_memory_buffer_manager.h
[add] https://crrev.com/3364e66eca1f71f542c2d9937acbf5ec288fcdc6/ui/aura/mus/window_compositor_frame_sink.cc
[add] https://crrev.com/3364e66eca1f71f542c2d9937acbf5ec288fcdc6/ui/aura/mus/window_compositor_frame_sink.h
[modify] https://crrev.com/3364e66eca1f71f542c2d9937acbf5ec288fcdc6/ui/aura/mus/window_port_mus.cc
[modify] https://crrev.com/3364e66eca1f71f542c2d9937acbf5ec288fcdc6/ui/aura/mus/window_port_mus.h
[modify] https://crrev.com/3364e66eca1f71f542c2d9937acbf5ec288fcdc6/ui/aura/mus/window_tree_host_mus.cc
[modify] https://crrev.com/3364e66eca1f71f542c2d9937acbf5ec288fcdc6/ui/views/mus/mus_client.cc
[modify] https://crrev.com/3364e66eca1f71f542c2d9937acbf5ec288fcdc6/ui/views/mus/mus_client.h
[modify] https://crrev.com/3364e66eca1f71f542c2d9937acbf5ec288fcdc6/ui/views/mus/surface_context_factory.cc
[modify] https://crrev.com/3364e66eca1f71f542c2d9937acbf5ec288fcdc6/ui/views/mus/surface_context_factory.h

Status: Fixed (was: Assigned)

Comment 7 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 8 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 9 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 10 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 12 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)
Components: -Internals>MUS Internals>Services>WindowService

Sign in to add a comment