New issue
Advanced search Search tips

Issue 660883 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Linux video freezing for Logitech C930

Project Member Reported by qiangchen@chromium.org, Oct 31 2016

Issue description

Detail in https://buganizer.corp.google.com/issues/32385681.

Underlying cause is that the camera timestamp from C930 is not monotonic.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b8877a5ac02394679fdf37944af414d7534edba

commit 6b8877a5ac02394679fdf37944af414d7534edba
Author: qiangchen <qiangchen@chromium.org>
Date: Thu Nov 03 16:52:25 2016

Bug Fix: Logitech C930 On Linux Results In Freezing Video

We implemented using camera timestamp in https://codereview.chromium.org/1983193002

But in testing, we found a problem on Logitech C930, which
gives us non-monotonic timestamps, which will result in
vido freezing.

BUG= 660883 

Review-Url: https://codereview.chromium.org/2463853002
Cr-Commit-Position: refs/heads/master@{#429620}

[modify] https://crrev.com/6b8877a5ac02394679fdf37944af414d7534edba/media/capture/video/linux/v4l2_capture_delegate.cc
[modify] https://crrev.com/6b8877a5ac02394679fdf37944af414d7534edba/media/capture/video/linux/v4l2_capture_delegate.h

Status: Fixed (was: Started)
Labels: Merge-Request-55
Labels: OS-Linux
Is this only applicable to Linux?
Re#4: Yes. 

Comment 6 by dimu@chromium.org, Nov 4 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 4 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96457f03b4878aeaf7652ba9c8208699dea90df6

commit 96457f03b4878aeaf7652ba9c8208699dea90df6
Author: qiangchen <qiangchen@chromium.org>
Date: Fri Nov 04 16:30:34 2016

Bug Fix: Logitech C930 On Linux Results In Freezing Video [M55]

We implemented using camera timestamp in https://codereview.chromium.org/1983193002

But in testing, we found a problem on Logitech C930, which
gives us non-monotonic timestamps, which will result in
vido freezing.

BUG= 660883 

NOTRY=true
NOPRESUBMIT=true

TBR=miu@chromium.org

Review-Url: https://codereview.chromium.org/2463853002
Cr-Commit-Position: refs/heads/master@{#429620}
(cherry picked from commit 6b8877a5ac02394679fdf37944af414d7534edba)

Review-Url: https://codereview.chromium.org/2478273002
Cr-Commit-Position: refs/branch-heads/2883@{#456}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/96457f03b4878aeaf7652ba9c8208699dea90df6/media/capture/video/linux/v4l2_capture_delegate.cc
[modify] https://crrev.com/96457f03b4878aeaf7652ba9c8208699dea90df6/media/capture/video/linux/v4l2_capture_delegate.h

Labels: Merge-Request-54
Adding 54 merge request since we're already discussing this.

Comment 9 by dimu@chromium.org, Nov 7 2016

Labels: -Merge-Request-54 Merge-Review-54 Hotlist-Merge-Review
[Automated comment] Request affecting a post-stable build (M54), manual review required.
Labels: -Merge-Review-54 Merge-Approved-54
Per discussion approved for M54
We are planning to cut Stable RC at 4.00 PM PST today ( Monday - 11/07), Please merge you change ASAP.
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 7 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d80ad1894991d14e5a4629391e8a5a96bd33460a

commit d80ad1894991d14e5a4629391e8a5a96bd33460a
Author: qiangchen <qiangchen@chromium.org>
Date: Mon Nov 07 22:23:54 2016

Bug Fix: Logitech C930 On Linux Results In Freezing Video

We implemented using camera timestamp in https://codereview.chromium.org/1983193002

But in testing, we found a problem on Logitech C930, which
gives us non-monotonic timestamps, which will result in
vido freezing.

BUG= 660883 

NOPRESUBMIT=true
NOTRY=true
TBR=miu@chromium.org

Review-Url: https://codereview.chromium.org/2463853002
Cr-Commit-Position: refs/heads/master@{#429620}
(cherry picked from commit 6b8877a5ac02394679fdf37944af414d7534edba)

Review-Url: https://codereview.chromium.org/2487483002
Cr-Commit-Position: refs/branch-heads/2840@{#825}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/d80ad1894991d14e5a4629391e8a5a96bd33460a/media/capture/video/linux/v4l2_capture_delegate.cc
[modify] https://crrev.com/d80ad1894991d14e5a4629391e8a5a96bd33460a/media/capture/video/linux/v4l2_capture_delegate.h

Sign in to add a comment