New issue
Advanced search Search tips

Issue 660869 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Fuzz FTP code

Project Member Reported by mmenke@chromium.org, Oct 31 2016

Issue description

We have a fuzzer for FTP parsers, but no more integration-y FTP fuzzer.  I think we should add one, or add FTP fuzzing to the URLRequest parser.
 

Comment 1 by mmenke@chromium.org, Oct 31 2016

Cc: eroman@chromium.org
Components: Internals>Network>FTP

Comment 3 by mmenke@chromium.org, Nov 21 2016

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7da0714bb1e387b30298047a9fa81c0ed2a2d13

commit a7da0714bb1e387b30298047a9fa81c0ed2a2d13
Author: mmenke <mmenke@chromium.org>
Date: Mon Nov 21 21:12:31 2016

Add a URLRequest FTP fuzzer.

Also add a new method to FuzzedDataProvider to provide a random length
string, with a max length. Generating the string this way allows for
the fuzzer to mutate it more easily than the previous pattern of
picking length from the end of input and then choosing that many
characters from the start of the input.

FuzzedSockets are switched to use the new method.  It will cause them
to need to rebuild their corpuses, but should result in faster
convergence, longer term.

BUG= 660869 
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2469813002
Cr-Commit-Position: refs/heads/master@{#433652}

[modify] https://crrev.com/a7da0714bb1e387b30298047a9fa81c0ed2a2d13/base/test/fuzzed_data_provider.cc
[modify] https://crrev.com/a7da0714bb1e387b30298047a9fa81c0ed2a2d13/base/test/fuzzed_data_provider.h
[modify] https://crrev.com/a7da0714bb1e387b30298047a9fa81c0ed2a2d13/net/BUILD.gn
[add] https://crrev.com/a7da0714bb1e387b30298047a9fa81c0ed2a2d13/net/data/fuzzer_data/net_url_request_ftp_fuzzer/epsv-mode.txt
[add] https://crrev.com/a7da0714bb1e387b30298047a9fa81c0ed2a2d13/net/data/fuzzer_data/net_url_request_ftp_fuzzer/pasv-mode.txt
[add] https://crrev.com/a7da0714bb1e387b30298047a9fa81c0ed2a2d13/net/data/fuzzer_dictionaries/net_url_request_ftp_fuzzer.dict
[modify] https://crrev.com/a7da0714bb1e387b30298047a9fa81c0ed2a2d13/net/socket/fuzzed_socket.cc
[add] https://crrev.com/a7da0714bb1e387b30298047a9fa81c0ed2a2d13/net/url_request/url_request_ftp_fuzzer.cc
[modify] https://crrev.com/a7da0714bb1e387b30298047a9fa81c0ed2a2d13/net/url_request/url_request_fuzzer.cc

Sign in to add a comment