New issue
Advanced search Search tips

Issue 660853 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Use lazy data properties on DOM objects where possible

Project Member Reported by jochen@chromium.org, Oct 31 2016

Issue description

We install some data properties as "native" data properties, i.e., everytime they're accessed, we invoke a C callback to provide the actual data value.

Assuming that the data value doesn't change, we can cache the value on access instead of invoking the callback everytime.

This is true, e.g., for DOM constructors
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4be3afec3ef1423f80dcfa0a50e9b68f6bc5062d

commit 4be3afec3ef1423f80dcfa0a50e9b68f6bc5062d
Author: jochen <jochen@chromium.org>
Date: Wed Nov 02 13:27:05 2016

Use new LazyDataProperty API for DOM constructors

R=haraken@chromium.org
BUG= 660853 

Review-Url: https://codereview.chromium.org/2460423002
Cr-Commit-Position: refs/heads/master@{#429263}

[modify] https://crrev.com/4be3afec3ef1423f80dcfa0a50e9b68f6bc5062d/third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp
[modify] https://crrev.com/4be3afec3ef1423f80dcfa0a50e9b68f6bc5062d/third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h
[modify] https://crrev.com/4be3afec3ef1423f80dcfa0a50e9b68f6bc5062d/third_party/WebKit/Source/bindings/scripts/v8_attributes.py
[modify] https://crrev.com/4be3afec3ef1423f80dcfa0a50e9b68f6bc5062d/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl
[modify] https://crrev.com/4be3afec3ef1423f80dcfa0a50e9b68f6bc5062d/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp
[modify] https://crrev.com/4be3afec3ef1423f80dcfa0a50e9b68f6bc5062d/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp
[modify] https://crrev.com/4be3afec3ef1423f80dcfa0a50e9b68f6bc5062d/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp
[modify] https://crrev.com/4be3afec3ef1423f80dcfa0a50e9b68f6bc5062d/third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.cpp
[modify] https://crrev.com/4be3afec3ef1423f80dcfa0a50e9b68f6bc5062d/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp

Status: Fixed (was: Assigned)

Sign in to add a comment