New issue
Advanced search Search tips

Issue 660846 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 383813



Sign in to add a comment

Automate manual Fullscreen web-platform-tests

Project Member Reported by foolip@chromium.org, Oct 31 2016

Issue description

Blink's tests have been exported and there are others that could be automated using wpt_automation:

https://github.com/w3c/web-platform-tests/pull/3692
https://github.com/w3c/web-platform-tests/pull/3830
https://chromium-review.googlesource.com/389972

This will require actually importing them, and then tweaking testharnessreport.js to run them.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96df472c108ec278c919bf704ad5c0eaa2621d6f

commit 96df472c108ec278c919bf704ad5c0eaa2621d6f
Author: foolip <foolip@chromium.org>
Date: Mon Oct 31 20:26:00 2016

Import web-platform-tests manual tests by default

A few manual tests already pass or fail in a useful way, like
stable-state-dialogs-manual.html. More importantly, it is difficult to
automate manual tests using wpt_automation if one must first add the
-automation.js script to cause the test to be imported.

The Fullscreen tests are imported and skipped in TestExpectations so
that they can be automated in a coming CL. These tests will all use the
same automation script, so the current import rules wouldn't work.

The wpt import is done with the same revision as the last import:
https://codereview.chromium.org/2448433002

Import wpt@bd99724e428dae78082983eab4675480c43f6234

Using update-w3c-deps in Chromium 55a661e4ed87e54b702de11e69ecc3babb2a96d0.

BUG= 660846 

Review-Url: https://codereview.chromium.org/2463743003
Cr-Commit-Position: refs/heads/master@{#428786}

[modify] https://crrev.com/96df472c108ec278c919bf704ad5c0eaa2621d6f/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/96df472c108ec278c919bf704ad5c0eaa2621d6f/third_party/WebKit/LayoutTests/W3CImportExpectations
[modify] https://crrev.com/96df472c108ec278c919bf704ad5c0eaa2621d6f/third_party/WebKit/LayoutTests/imported/wpt/MANIFEST.json
[add] https://crrev.com/96df472c108ec278c919bf704ad5c0eaa2621d6f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/document-exit-fullscreen-manual.html
[add] https://crrev.com/96df472c108ec278c919bf704ad5c0eaa2621d6f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/document-fullscreen-element-manual.html
[add] https://crrev.com/96df472c108ec278c919bf704ad5c0eaa2621d6f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/document-onfullscreenchange-manual.html
[add] https://crrev.com/96df472c108ec278c919bf704ad5c0eaa2621d6f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-ready-check-containing-iframe-manual.html
[add] https://crrev.com/96df472c108ec278c919bf704ad5c0eaa2621d6f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-ready-check-enabled-flag-not-set-manual.html
[add] https://crrev.com/96df472c108ec278c919bf704ad5c0eaa2621d6f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-ready-check-fullscreen-element-sibling-manual.html
[add] https://crrev.com/96df472c108ec278c919bf704ad5c0eaa2621d6f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-ready-check-fullscreen-iframe-child-manual.html
[add] https://crrev.com/96df472c108ec278c919bf704ad5c0eaa2621d6f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-ready-check-iframe-child-manual.html
[add] https://crrev.com/96df472c108ec278c919bf704ad5c0eaa2621d6f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-ready-check-not-in-document-manual.html
[add] https://crrev.com/96df472c108ec278c919bf704ad5c0eaa2621d6f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-manual.html
[add] https://crrev.com/96df472c108ec278c919bf704ad5c0eaa2621d6f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-non-top-manual.html
[add] https://crrev.com/96df472c108ec278c919bf704ad5c0eaa2621d6f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-svg-rect-manual.html
[add] https://crrev.com/96df472c108ec278c919bf704ad5c0eaa2621d6f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-svg-svg-manual.html
[add] https://crrev.com/96df472c108ec278c919bf704ad5c0eaa2621d6f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-top-manual.html
[add] https://crrev.com/96df472c108ec278c919bf704ad5c0eaa2621d6f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/model/remove-child-manual.html
[add] https://crrev.com/96df472c108ec278c919bf704ad5c0eaa2621d6f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/model/remove-first-manual.html
[add] https://crrev.com/96df472c108ec278c919bf704ad5c0eaa2621d6f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/model/remove-last-manual.html
[add] https://crrev.com/96df472c108ec278c919bf704ad5c0eaa2621d6f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/model/remove-parent-manual.html
[add] https://crrev.com/96df472c108ec278c919bf704ad5c0eaa2621d6f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/model/remove-single-manual.html
[add] https://crrev.com/96df472c108ec278c919bf704ad5c0eaa2621d6f/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/the-window-object/the-windowproxy-object/test-window-proxy-locationbar-manual.html
[add] https://crrev.com/96df472c108ec278c919bf704ad5c0eaa2621d6f/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/the-window-object/the-windowproxy-object/test-window-proxy-menubar-manual.html
[add] https://crrev.com/96df472c108ec278c919bf704ad5c0eaa2621d6f/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/the-window-object/the-windowproxy-object/test-window-proxy-personalbar-manual.html
[add] https://crrev.com/96df472c108ec278c919bf704ad5c0eaa2621d6f/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/the-window-object/the-windowproxy-object/test-window-proxy-scrollbars-manual.html
[add] https://crrev.com/96df472c108ec278c919bf704ad5c0eaa2621d6f/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/the-window-object/the-windowproxy-object/test-window-proxy-statusbar-manual.html
[add] https://crrev.com/96df472c108ec278c919bf704ad5c0eaa2621d6f/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/the-window-object/the-windowproxy-object/test-window-proxy-toolbar-manual.html
[add] https://crrev.com/96df472c108ec278c919bf704ad5c0eaa2621d6f/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/media-elements/loading-the-media-resource/stable-state-dialogs-manual-expected.txt
[add] https://crrev.com/96df472c108ec278c919bf704ad5c0eaa2621d6f/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/media-elements/loading-the-media-resource/stable-state-dialogs-manual.html
[add] https://crrev.com/96df472c108ec278c919bf704ad5c0eaa2621d6f/third_party/WebKit/LayoutTests/imported/wpt/html/webappapis/system-state-and-capabilities/the-navigator-object/get-navigatorlanguage-manual-expected.txt
[add] https://crrev.com/96df472c108ec278c919bf704ad5c0eaa2621d6f/third_party/WebKit/LayoutTests/imported/wpt/html/webappapis/system-state-and-capabilities/the-navigator-object/get-navigatorlanguage-manual.html
[add] https://crrev.com/96df472c108ec278c919bf704ad5c0eaa2621d6f/third_party/WebKit/LayoutTests/imported/wpt/uievents/keyboard/key-manual.css
[add] https://crrev.com/96df472c108ec278c919bf704ad5c0eaa2621d6f/third_party/WebKit/LayoutTests/imported/wpt/uievents/keyboard/key-manual.js
[modify] https://crrev.com/96df472c108ec278c919bf704ad5c0eaa2621d6f/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py
[modify] https://crrev.com/96df472c108ec278c919bf704ad5c0eaa2621d6f/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/529fd9c41df97f26fd8e3ff26222f3ae195365d6

commit 529fd9c41df97f26fd8e3ff26222f3ae195365d6
Author: foolip <foolip@chromium.org>
Date: Tue Nov 01 21:34:27 2016

Automate Fullscreen web-platform-tests using wpt_automation

BUG= 660846 

Review-Url: https://codereview.chromium.org/2466333002
Cr-Commit-Position: refs/heads/master@{#429118}

[modify] https://crrev.com/529fd9c41df97f26fd8e3ff26222f3ae195365d6/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/e9cb54867442db0d7d556dcae7c139c5f7de77f5/third_party/WebKit/LayoutTests/fullscreen/api/document-exit-fullscreen.html
[modify] https://crrev.com/529fd9c41df97f26fd8e3ff26222f3ae195365d6/third_party/WebKit/LayoutTests/fullscreen/api/document-fullscreen-element.html
[delete] https://crrev.com/e9cb54867442db0d7d556dcae7c139c5f7de77f5/third_party/WebKit/LayoutTests/fullscreen/api/document-onfullscreenchange.html
[delete] https://crrev.com/e9cb54867442db0d7d556dcae7c139c5f7de77f5/third_party/WebKit/LayoutTests/fullscreen/api/element-ready-check-containing-iframe.html
[delete] https://crrev.com/e9cb54867442db0d7d556dcae7c139c5f7de77f5/third_party/WebKit/LayoutTests/fullscreen/api/element-ready-check-enabled-flag-not-set.html
[delete] https://crrev.com/e9cb54867442db0d7d556dcae7c139c5f7de77f5/third_party/WebKit/LayoutTests/fullscreen/api/element-ready-check-fullscreen-element-sibling.html
[delete] https://crrev.com/e9cb54867442db0d7d556dcae7c139c5f7de77f5/third_party/WebKit/LayoutTests/fullscreen/api/element-ready-check-fullscreen-iframe-child.html
[delete] https://crrev.com/e9cb54867442db0d7d556dcae7c139c5f7de77f5/third_party/WebKit/LayoutTests/fullscreen/api/element-ready-check-iframe-child.html
[delete] https://crrev.com/e9cb54867442db0d7d556dcae7c139c5f7de77f5/third_party/WebKit/LayoutTests/fullscreen/api/element-ready-check-not-in-document.html
[delete] https://crrev.com/e9cb54867442db0d7d556dcae7c139c5f7de77f5/third_party/WebKit/LayoutTests/fullscreen/api/element-request-fullscreen-non-top.html
[delete] https://crrev.com/e9cb54867442db0d7d556dcae7c139c5f7de77f5/third_party/WebKit/LayoutTests/fullscreen/api/element-request-fullscreen-top.html
[delete] https://crrev.com/e9cb54867442db0d7d556dcae7c139c5f7de77f5/third_party/WebKit/LayoutTests/fullscreen/api/element-request-fullscreen.html
[delete] https://crrev.com/e9cb54867442db0d7d556dcae7c139c5f7de77f5/third_party/WebKit/LayoutTests/fullscreen/model/remove-child.html
[delete] https://crrev.com/e9cb54867442db0d7d556dcae7c139c5f7de77f5/third_party/WebKit/LayoutTests/fullscreen/model/remove-first.html
[delete] https://crrev.com/e9cb54867442db0d7d556dcae7c139c5f7de77f5/third_party/WebKit/LayoutTests/fullscreen/model/remove-last.html
[delete] https://crrev.com/e9cb54867442db0d7d556dcae7c139c5f7de77f5/third_party/WebKit/LayoutTests/fullscreen/model/remove-parent.html
[delete] https://crrev.com/e9cb54867442db0d7d556dcae7c139c5f7de77f5/third_party/WebKit/LayoutTests/fullscreen/model/remove-single.html
[add] https://crrev.com/529fd9c41df97f26fd8e3ff26222f3ae195365d6/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/document-fullscreen-element-manual-expected.txt
[add] https://crrev.com/529fd9c41df97f26fd8e3ff26222f3ae195365d6/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-svg-rect-manual-expected.txt
[modify] https://crrev.com/529fd9c41df97f26fd8e3ff26222f3ae195365d6/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/the-img-element/update-the-source-set-expected.txt
[modify] https://crrev.com/529fd9c41df97f26fd8e3ff26222f3ae195365d6/third_party/WebKit/LayoutTests/imported/wpt/resources/testharnessreport.js
[add] https://crrev.com/529fd9c41df97f26fd8e3ff26222f3ae195365d6/third_party/WebKit/LayoutTests/imported/wpt_automation/fullscreen/auto-click.js
[modify] https://crrev.com/529fd9c41df97f26fd8e3ff26222f3ae195365d6/third_party/WebKit/LayoutTests/resources/testharnessreport.js

Status: Fixed (was: Started)

Sign in to add a comment