feedback loop detection between texture and framebuffer attachment should honor draw buffers |
||||||||
Issue descriptionWe have done feedback loop detection between texture and framebuffer attachments in Chromium. That code snippet can generate INVALID_OPERATION correctly. But it supposes that the draw buffer is always COLOR_ATTACHMENT0. It is correct in WebGL1 and ES2, but it is incorrect in WebGL2 and ES3. We should honor draw buffers in WebGL 2 and ES3. See the conformance test at: https://github.com/KhronosGroup/WebGL/pull/2121/ see the patch for Chromium at: https://codereview.chromium.org/2461973002/
,
Sep 12 2017
,
Jul 17
This is nearly 2 years old. The test fails in Chrome, passes in Firefox. It came up on Stack Overflow. https://www.khronos.org/registry/webgl/sdk/tests/conformance/extensions/webgl-draw-buffers-feedback-loop.html
,
Jul 17
I suspect ANGLE will need to be patched too.
,
Jul 17
The suppression entry in the conformance suite points to ANGLE bug 1619 : https://cs.chromium.org/chromium/src/content/test/gpu/gpu_tests/webgl_conformance_expectations.py?q=webgl_conformance_expec&sq=package:chromium&g=0&l=102 Let's implement this where it's still needed – it sounds like the validating command decoder, from https://codereview.chromium.org/2461973002/ – and close this.
,
Jul 17
Right. I was assuming ANGLE was missing the validation. But I guess we only do the validation if the passthrough is enabled. Hence only missing in the command buffer. My bad.
,
Oct 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/319faa6f9fc6bb050759c111202dbb61ba99086d commit 319faa6f9fc6bb050759c111202dbb61ba99086d Author: Kenneth Russell <kbr@chromium.org> Date: Wed Oct 24 17:21:44 2018 Roll WebGL 6d2f3f4..0d55c88 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/6d2f3f4..0d55c88 Includes suppressions for the following failures: conformance/rendering/rendering-sampling-feedback-loop.html conformance2/textures/misc/tex-mipmap-levels.html conformance2/textures/image_bitmap_from_video/ tex-2d-rgb565-rgb-unsigned_short_5_6_5.html deqp/functional/gles3/lifetime.html deqp/functional/gles3/shaderoperator/common_functions_*.html Bug: 660844, 739604 , 766918, 849576, 886970, 890002 , 890539, 898350 , 898351 , angleproject:2832 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_angle_rel_ng;luci.chromium.try:win_angle_rel_ng Change-Id: I85be441fa86090e5ed056a9366452248985693e3 Reviewed-on: https://chromium-review.googlesource.com/c/1297570 Reviewed-by: James Darpinian <jdarpinian@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#602377} [modify] https://crrev.com/319faa6f9fc6bb050759c111202dbb61ba99086d/DEPS [modify] https://crrev.com/319faa6f9fc6bb050759c111202dbb61ba99086d/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py [modify] https://crrev.com/319faa6f9fc6bb050759c111202dbb61ba99086d/content/test/gpu/gpu_tests/webgl_conformance_expectations.py [modify] https://crrev.com/319faa6f9fc6bb050759c111202dbb61ba99086d/content/test/gpu/gpu_tests/webgl_conformance_revision.txt
,
Nov 27
,
Nov 27
,
Jan 16
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by zmo@chromium.org
, Nov 5 2016