HTML validation message in wrong position
Reported by
slamb...@gmail.com,
Oct 31 2016
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.71 Safari/537.36 Example URL: https://www.slamb.eu/ Steps to reproduce the problem: 1. Visit https://www.slamb.eu/#kontakt. 2. Try to send empty form. What is the expected behavior? Message about empty input should be close to empty input. What went wrong? Message about empty input is lost somewhere on website. Does it occur on multiple sites: N/A Is it a problem with a plugin? No Did this work before? N/A Does this work in other browsers? Yes Chrome version: 54.0.2840.71 Channel: stable OS Version: 10.0 Flash Version:
,
Oct 31 2016
Edge and Firefox are ok for me.
,
Oct 31 2016
I found that this problem is related to scaling on high resolution displays, see attached screenshots. Number in filename defines percentage settings in Windows.
,
Nov 1 2016
Yup can reproduce on Windows 10 (Comment #1; the dialog is actually provided by the required attribute). bsep@ could this be any fallout from your changes?
,
Nov 1 2016
Yes, I see the issue too. Let me take a look at it.
,
Nov 1 2016
Looks like a HiDPI bug. The little widget is having its x/y position scaled when it shouldn't, I think. I'll address it. I bet this reproduces on other platforms too, if anyone can confirm.
,
Nov 1 2016
,
Nov 3 2016
Yes this is happening on cros too. Looks like the following code should be passing the one in screen coordinates (although it may have to be done differently so that it works in emulator) https://cs.chromium.org/chromium/src/third_party/WebKit/Source/web/ValidationMessageClientImpl.cpp?rcl=1478128703&l=84
,
Nov 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5debc705a0b892bd2dcf82ec7672147268083957 commit 5debc705a0b892bd2dcf82ec7672147268083957 Author: bsep <bsep@chromium.org> Date: Sat Nov 19 00:27:46 2016 Fix form validation bubble positioning at hidpi. Since use-zoom-for-dsf launched, when Blink converts to screen coordinates it needs to take the device scale factor into account. Normally it would do this by calling viewportToScreen or a similar function. However, because the validation bubble anchor is in viewport coordinates instead of screen coordinates, the positioning code needs to use device scale factor explicitly. The reason we can't just convert the anchor to screen coordinates in Blink is because the same anchor is used for cocoa. It needs to y-flip the anchor for OSX and converting to screen coordinates too early messes up that calculation. BUG= 660840 Review-Url: https://codereview.chromium.org/2491113002 Cr-Commit-Position: refs/heads/master@{#433349} [modify] https://crrev.com/5debc705a0b892bd2dcf82ec7672147268083957/chrome/browser/ui/views/validation_message_bubble_view.cc [modify] https://crrev.com/5debc705a0b892bd2dcf82ec7672147268083957/chrome/browser/ui/views/validation_message_bubble_view.h
,
Nov 19 2016
,
Dec 19 2016
Issue 675476 has been merged into this issue.
,
Dec 20 2016
,
Dec 20 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f010f3da574e93bfafb68a0149ae8d350202e71 commit 1f010f3da574e93bfafb68a0149ae8d350202e71 Author: Kent Tamura <tkent@chromium.org> Date: Tue Dec 20 01:51:12 2016 Merge "Fix form validation bubble positioning at hidpi." to M56 Since use-zoom-for-dsf launched, when Blink converts to screen coordinates it needs to take the device scale factor into account. Normally it would do this by calling viewportToScreen or a similar function. However, because the validation bubble anchor is in viewport coordinates instead of screen coordinates, the positioning code needs to use device scale factor explicitly. The reason we can't just convert the anchor to screen coordinates in Blink is because the same anchor is used for cocoa. It needs to y-flip the anchor for OSX and converting to screen coordinates too early messes up that calculation. BUG= 660840 Review-Url: https://codereview.chromium.org/2491113002 Cr-Commit-Position: refs/heads/master@{#433349} (cherry picked from commit 5debc705a0b892bd2dcf82ec7672147268083957) Review-Url: https://codereview.chromium.org/2585263005 . Cr-Commit-Position: refs/branch-heads/2924@{#559} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/1f010f3da574e93bfafb68a0149ae8d350202e71/chrome/browser/ui/views/validation_message_bubble_view.cc [modify] https://crrev.com/1f010f3da574e93bfafb68a0149ae8d350202e71/chrome/browser/ui/views/validation_message_bubble_view.h
,
Dec 20 2016
,
Jan 4 2017
Tested the issue on windows 7 using chrome version#56.0.2924.51 with the steps mentioned in comment #0. Observed Message (Please fill out this field) about empty input is displayed close to empty input field itself. Please find the attached screen cast for the same. Adding TE-Verified labels.
,
Jan 13 2017
Issue 681109 has been merged into this issue. |
||||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||||
Comment 1 by dtapu...@chromium.org
, Oct 31 2016NextAction: 2016-11-14