New issue
Advanced search Search tips

Issue 660819 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 388780



Sign in to add a comment

[GeometryInterface] Should be Implement Constructor(DOMString transformList).

Project Member Reported by hs1217....@samsung.com, Oct 31 2016

Issue description

Should be Implement Constructor(DOMString transformList).
 - https://drafts.fxtf.org/geometry/#dom-dommatrix-dommatrix-transformlist
 
Status: Started (was: Assigned)
i'm working in process. thank you.
(https://codereview.chromium.org/2516973002/)
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59c27f138a1ef700d4adb552e8a9c0452d7a8d4e

commit 59c27f138a1ef700d4adb552e8a9c0452d7a8d4e
Author: hs1217.lee <hs1217.lee@samsung.com>
Date: Tue Dec 13 09:17:37 2016

[GeometryInferface] add Constructor(DOMString transformList).

1. if transformList is the empty string,
 set in to the string "matrix(1, 0, 0, 1, 0, 0)".
2. Parse transformList by following the syntax description[1].
 if parsing failed, throw SyntaxError.
3. Set is2D to false if the <transform-list> consists of any 3D
 Transform functions. Otherwise set is2D to true.
4. Transform all <transform-function>s to 4x4 matrices.
5. Post-multiply all matrices from left to right.
6. Return the result of invoking create a matrix of type
 DOMMatrixReadOnly or DOMMatrix as appropriate.

spec list:
https://drafts.fxtf.org/geometry/#dom-dommatrix-dommatrix-transformlist
[1] = https://drafts.csswg.org/css-transforms-1/#svg-syntax

BUG= 388780 ,  660819 

Review-Url: https://codereview.chromium.org/2516973002
Cr-Commit-Position: refs/heads/master@{#438107}

[modify] https://crrev.com/59c27f138a1ef700d4adb552e8a9c0452d7a8d4e/third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-readonly.html
[modify] https://crrev.com/59c27f138a1ef700d4adb552e8a9c0452d7a8d4e/third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-setMatrixValue.html
[modify] https://crrev.com/59c27f138a1ef700d4adb552e8a9c0452d7a8d4e/third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix.html
[modify] https://crrev.com/59c27f138a1ef700d4adb552e8a9c0452d7a8d4e/third_party/WebKit/Source/core/dom/DOMMatrix.cpp
[modify] https://crrev.com/59c27f138a1ef700d4adb552e8a9c0452d7a8d4e/third_party/WebKit/Source/core/dom/DOMMatrix.h
[modify] https://crrev.com/59c27f138a1ef700d4adb552e8a9c0452d7a8d4e/third_party/WebKit/Source/core/dom/DOMMatrix.idl
[modify] https://crrev.com/59c27f138a1ef700d4adb552e8a9c0452d7a8d4e/third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.cpp
[modify] https://crrev.com/59c27f138a1ef700d4adb552e8a9c0452d7a8d4e/third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.h
[modify] https://crrev.com/59c27f138a1ef700d4adb552e8a9c0452d7a8d4e/third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.idl

Status: Fixed (was: Started)

Sign in to add a comment