New issue
Advanced search Search tips

Issue 660777 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Stop re-signaling a slotchange event

Project Member Reported by hayato@chromium.org, Oct 31 2016

Issue description

The spec change is: https://github.com/whatwg/dom/pull/353 (PR to DOM Standard)

See https://github.com/w3c/webcomponents/issues/571 for details.

 

Comment 1 by hayato@chromium.org, Oct 31 2016

Status: Started (was: Assigned)
Jonnelgarbosa889@gmail
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7af35614d3a6f1d8f0d6f4e37ea921b89446002

commit d7af35614d3a6f1d8f0d6f4e37ea921b89446002
Author: hayato <hayato@chromium.org>
Date: Mon Oct 31 15:38:41 2016

Stop re-signaling a slotchange event

The spec change is: https://github.com/whatwg/dom/pull/353
Spec issue is: https://github.com/w3c/webcomponents/issues/571

Blink no longer re-fires a slotchange event at a slot's assignedSlot (or parent
slot).

Given that the usage of the current slotchange is low enough [1],
it would be okay to change the behavior, just having the entry on chrome status [2].

- [1] https://www.chromestatus.com/metrics/feature/timeline/popularity/1468
- [2] https://www.chromestatus.com/feature/5666302446272512

BUG= 660777 

Review-Url: https://codereview.chromium.org/2420043002
Cr-Commit-Position: refs/heads/master@{#428718}

[modify] https://crrev.com/d7af35614d3a6f1d8f0d6f4e37ea921b89446002/third_party/WebKit/LayoutTests/shadow-dom/slotchange.html
[modify] https://crrev.com/d7af35614d3a6f1d8f0d6f4e37ea921b89446002/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/d7af35614d3a6f1d8f0d6f4e37ea921b89446002/third_party/WebKit/Source/core/dom/Node.h
[modify] https://crrev.com/d7af35614d3a6f1d8f0d6f4e37ea921b89446002/third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp
[modify] https://crrev.com/d7af35614d3a6f1d8f0d6f4e37ea921b89446002/third_party/WebKit/Source/core/html/HTMLSlotElement.cpp
[modify] https://crrev.com/d7af35614d3a6f1d8f0d6f4e37ea921b89446002/third_party/WebKit/Source/core/html/HTMLSlotElement.h

Labels: M-56
Status: Fixed (was: Started)

Sign in to add a comment