Adding attachment, showing erratic behavior and how to work around causing it to repaint.

Deleted: fontAwesomeTest.html 982 bytes

fontAwesomeTest.html 982 bytes View Download

Please address this. Loading icon fonts is a pretty common use case

Confirmed.

Test team, please bisect use the following url: http://jsbin.com/vokeja

Per-revision bisect result:
-------------------------
Good build: 54.0.2836.0 (Revision 413363)
Bad build: 54.0.2838.0 (Revision 413929)

You are probably looking for a change made after 413405 (known good), but no later than 413406 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/bfd1b37e43efa00f282a93a2d8e4bb1bb210eccd..d0c57905368c76aba662dbda3b4e13cb9bd454bf

https://chromium.googlesource.com/chromium/src/+/d0c57905368c76aba662dbda3b4e13cb9bd454bf, sashab@, could you please check the issue and update.

Able to reproduce on Win7, Mac OS X10.11.6, Ubuntu 14.04 using chrome Canary # 56.0.2905.0, Dev 56.0.2902.0, Stable 54.0.2840.71

Also seeing this error when the content is changed on a :before pseudo element (whilst still visible)

This should be fixed by https://codereview.chromium.org/2492783002/. Will work on merging this into stable.

 Issue 660089  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/998f4790884a34c5ac5167876a13b7cb7495a617

commit 998f4790884a34c5ac5167876a13b7cb7495a617
Author: rune <rune@opera.com>
Date: Fri Nov 11 00:50:20 2016

Skip independent inherited property propagation to pseudo elements.

UpdatePseudoElements and IndependentInherit conflict in the following
way. If we both have an independent inherit change on the actual dom
element, and we detect that we need to update the style for the pseudo
element we need to signal the inheritance propagation to the real dom
children and signal the pseudo element recalc to the pseudo element
children. If we return IndependentInherit, we lose the information
about the need for a pseudo element recalc, and if we return
UpdatePseudoElement, we lose the inheritance propagation for the actual
dom children.

We could introduce a new IndependentInheritAndUpdatePseudoElements, but
if there exists pseudo element, we would always return this constant,
so instead just force recalc on pseudo elements on IndependentInherit.

R=sashab@chromium.org
BUG= 660735 , 660089 , 657283 

Review-Url: https://codereview.chromium.org/2492783002
Cr-Commit-Position: refs/heads/master@{#431430}

[add] https://crrev.com/998f4790884a34c5ac5167876a13b7cb7495a617/third_party/WebKit/LayoutTests/fast/css/independent-inherit-update-pseudo.html
[modify] https://crrev.com/998f4790884a34c5ac5167876a13b7cb7495a617/third_party/WebKit/Source/core/dom/Element.cpp

Is this merge CRITICAL for M54 ?If yes please tag the bug with Release Block Stable.

As of now we do not have plan for a Stable Refresh for M54.

Guessing we can take this change for M55 once the CL is baked and verified in canary.

Please request a merge to M55 once CL is baked/verified in Canary and safe to merge if needed. Thank you.

[Automated comment] Request affecting a post-stable build (M54), manual review required.

 Issue 657283  has been merged into this issue.

Sorry, can we please merge into M55 instead.

Can confirm this is working in both tip-of-tree and Version 56.0.2918.0 canary (64-bit) on Windows 10.

re: #17, please request a merge to M55 by applying "Merge-Request-55" label. Thank you.

M54 is already in Stable now we may not do any more refresh.

[Automated comment] There appears to be on-going work (i.e. bugroid changes), needs manual review.

The script treated this bug as manual review in progress because of the Hotlist-Merge-Review label. Also it won't auto approval merge-request more than 24hrs old. So applying merge-request-55 manually now.

Your change meets the bar and is auto-approved for M55 (branch: 2883)

Thanks! Will the patch be auto-merged or do I do that manually myself?

I think you need to do it yourself, or I could drover it.

Since it's evening in Sydney, I'll start drover now.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bbebf3ba3a5b8ff0a645d026a0ede213135521d

commit 9bbebf3ba3a5b8ff0a645d026a0ede213135521d
Author: Rune Lillesveen <rune@opera.com>
Date: Thu Nov 17 10:53:20 2016

Skip independent inherited property propagation to pseudo elements.

UpdatePseudoElements and IndependentInherit conflict in the following
way. If we both have an independent inherit change on the actual dom
element, and we detect that we need to update the style for the pseudo
element we need to signal the inheritance propagation to the real dom
children and signal the pseudo element recalc to the pseudo element
children. If we return IndependentInherit, we lose the information
about the need for a pseudo element recalc, and if we return
UpdatePseudoElement, we lose the inheritance propagation for the actual
dom children.

We could introduce a new IndependentInheritAndUpdatePseudoElements, but
if there exists pseudo element, we would always return this constant,
so instead just force recalc on pseudo elements on IndependentInherit.

R=sashab@chromium.org
BUG= 660735 , 660089 , 657283 

Review-Url: https://codereview.chromium.org/2492783002
Cr-Commit-Position: refs/heads/master@{#431430}
(cherry picked from commit 998f4790884a34c5ac5167876a13b7cb7495a617)

Review URL: https://codereview.chromium.org/2511073002 .

Cr-Commit-Position: refs/branch-heads/2883@{#598}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[add] https://crrev.com/9bbebf3ba3a5b8ff0a645d026a0ede213135521d/third_party/WebKit/LayoutTests/fast/css/independent-inherit-update-pseudo.html
[modify] https://crrev.com/9bbebf3ba3a5b8ff0a645d026a0ede213135521d/third_party/WebKit/Source/core/dom/Element.cpp

Tyvm rune!

Verified the fix on Windows 10, Ubuntu 14.04 and Mac 10.11.6 using Chrome Beta version #55.0.2883.59 as per the comment #3.

Observed that the fix is working as expected.

Attaching the screencast for reference

Hence, adding the verified labels

Deleted: Issue 660735.mp4 445 KB

	Issue 660735.mp4 445 KB View Download

 Issue 666918  has been merged into this issue.