New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 660699 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug


Sign in to add a comment

Implement BluetoothRemoteGATTCharacteristic::getDescriptor[s]

Project Member Reported by dougt@chromium.org, Oct 30 2016

Issue description

Comment 1 by dougt@chromium.org, Oct 30 2016

Cc: scheib@chromium.org

Comment 2 by dougt@chromium.org, Nov 1 2016

Cc: ortuno@chromium.org

Comment 4 by dougt@chromium.org, Nov 21 2016

Blocking: 667319

Comment 5 by ortuno@chromium.org, Nov 28 2016

Blocking: 669183

Comment 6 by dougt@chromium.org, Dec 7 2016

Blocking: 672127

Comment 7 by dougt@chromium.org, Dec 22 2016

Blocking: 676720
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f2237ccffefb9642173b872d4a0aafbac57f65e

commit 4f2237ccffefb9642173b872d4a0aafbac57f65e
Author: dougt <dougt@chromium.org>
Date: Sat Jan 14 04:14:13 2017

Implement WebBluetooth getDescriptor[s]

A GATT Descriptor provides further information about a characteristic's
value. For each characteristic there may be many descriptors as defined by
https://webbluetoothcg.github.io/web-bluetooth/#bluetoothremotegattdescriptor.

BUG= 660699 

R=ortuno@chromium.org

Review-Url: https://codereview.chromium.org/2466223002
Cr-Commit-Position: refs/heads/master@{#443784}

[modify] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/content/browser/bluetooth/web_bluetooth_service_impl.cc
[modify] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/content/browser/bluetooth/web_bluetooth_service_impl.h
[modify] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc
[modify] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
[modify] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/device/bluetooth/bluetooth_device.cc
[modify] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/device/bluetooth/bluetooth_device.h
[modify] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/device/bluetooth/test/mock_bluetooth_gatt_characteristic.cc
[modify] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/device/bluetooth/test/mock_bluetooth_gatt_characteristic.h
[modify] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/device/bluetooth/test/mock_bluetooth_gatt_descriptor.h
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/descriptor-not-found.html
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-characteristic-is-removed.html
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-descriptor-blocklisted.html
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-descriptor-garbage-collection-ran-during-error.html
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-descriptor-garbage-collection-ran-during-success.html
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-descriptor-get-same-object.html
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-descriptor-invalid-name.html
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-device-out-of-range.html
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-gatt-op-device-disconnects-before.html
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-gatt-op-device-disconnects-during-error.html
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-gatt-op-device-disconnects-during-success.html
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-gatt-op-disconnect-called-before.html
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-gatt-op-disconnect-called-during-error.html
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-gatt-op-disconnect-called-during-success.html
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-service-is-removed.html
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/blocklisted-descriptors-not-present.html
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-characteristic-is-removed-with-uuid.html
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-characteristic-is-removed.html
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-blocklisted.html
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-garbage-collection-ran-during-error-with-uuid.html
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-garbage-collection-ran-during-error.html
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-garbage-collection-ran-during-success-with-uuid.html
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-garbage-collection-ran-during-success.html
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-invalid-name.html
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-device-out-of-range-with-uuid.html
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-device-out-of-range.html
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-device-disconnects-before-with-uuid.html
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-device-disconnects-before.html
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-device-disconnects-during-error-with-uuid.html
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-device-disconnects-during-error.html
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-device-disconnects-during-success-with-uuid.html
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-device-disconnects-during-success.html
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-disconnect-called-before-with-uuid.html
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-disconnect-called-before.html
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-disconnect-called-during-error-with-uuid.html
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-disconnect-called-during-error.html
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-disconnect-called-during-success-with-uuid.html
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-disconnect-called-during-success.html
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-service-is-removed-with-uuid.html
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-service-is-removed.html
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/gen-characteristic-is-removed.html
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/characteristic/startNotifications/gen-characteristic-is-removed.html
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/gen-characteristic-is-removed.html
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/characteristic-is-removed.js
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/descriptor-blocklisted.js
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/descriptor-garbage-collection-ran-during-error.js
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/descriptor-garbage-collection-ran-during-success.js
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/descriptor-get-same-object.js
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/descriptor-invalid-name.js
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/device-out-of-range.js
[modify] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/gatt-op-device-disconnects-before.js
[modify] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/gatt-op-device-disconnects-during-error.js
[modify] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/gatt-op-device-disconnects-during-success.js
[modify] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/gatt-op-disconnect-called-before.js
[modify] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/gatt-op-disconnect-called-during-error.js
[modify] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/gatt-op-disconnect-called-during-success.js
[modify] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/gatt-op-reconnect-during-error.js
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/service-is-removed.js
[modify] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js
[modify] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/Source/modules/bluetooth/BUILD.gn
[modify] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/Source/modules/bluetooth/BluetoothAttributeInstanceMap.cpp
[modify] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/Source/modules/bluetooth/BluetoothAttributeInstanceMap.h
[modify] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.cpp
[modify] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.h
[modify] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp
[modify] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp
[modify] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h
[modify] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.idl
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTDescriptor.cpp
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTDescriptor.h
[add] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTDescriptor.idl
[modify] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp
[modify] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom
[modify] https://crrev.com/4f2237ccffefb9642173b872d4a0aafbac57f65e/tools/metrics/histograms/histograms.xml

Comment 9 by dougt@chromium.org, Jan 29 2017

Cc: dougt@chromium.org
 Issue 669183  has been merged into this issue.
Blocking: 686893
Blocking: -686893
Status: Fixed (was: Assigned)

Sign in to add a comment