[css-grid] min-/max-sizes are ignored when finding the used flex fraction with an indefinite free space |
||||||||||
Issue descriptionVersion: 56.0.2897.0 (Official Build) dev (64-bit) OS: Linux What steps will reproduce the problem? (1)load the attached testcase (2) (3) What is the expected output? see 2nd attached screenshot (from Firefox Nightly) What do you see instead? see 1st attached screenshot Relevant spec text: https://drafts.csswg.org/css-grid/#algo-flex-tracks " If using this flex fraction would cause the grid to be smaller than the grid container’s min-width/height (or larger than the grid container’s max-width/height), then redo this step, treating the free space as definite and the available grid space as equal to the grid container’s content box size when it’s sized to its min-width/height (max-width/height). "
,
Nov 2 2016
,
Nov 2 2016
Right, that paragraph was never implemented.
,
Nov 2 2016
I think I have a fix for this.
,
Nov 2 2016
Yaa Pada 2 Nov 2016 23:42, "svil… via monorail" < monorail+v2.2596945094@chromium.org> menulis:
,
Nov 2 2016
Pada 3 Nov 2016 00:22, "Meri Bkn" <meri.bkn0001@gmail.com> menulis:
,
Nov 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee54fbc9b393d7d7b7e49f3f17f3178e817f2e94 commit ee54fbc9b393d7d7b7e49f3f17f3178e817f2e94 Author: svillar <svillar@igalia.com> Date: Tue Nov 08 18:16:59 2016 [css-grid] Use min|max-sizes to compute flex fraction The min|max-sizes must be used to compute the flex fraction for indefinite free spaces. According to the spec "If using this flex fraction would cause the grid to be smaller than the grid container’s min-width/height (or larger than the grid container’s max-width/height), then redo this step, treating the free space as definite and the available grid space as equal to the grid container’s content box size when it’s sized to its min-width/height (max-width/height)." This only affects heights because during layout widths are properly constrained by min|max-width restrictions. BUG= 660690 Review-Url: https://codereview.chromium.org/2480493002 Cr-Commit-Position: refs/heads/master@{#430654} [add] https://crrev.com/ee54fbc9b393d7d7b7e49f3f17f3178e817f2e94/third_party/WebKit/LayoutTests/fast/css-grid-layout/flex-sizing-columns-min-max-width.html [add] https://crrev.com/ee54fbc9b393d7d7b7e49f3f17f3178e817f2e94/third_party/WebKit/LayoutTests/fast/css-grid-layout/flex-sizing-rows-min-max-height.html [modify] https://crrev.com/ee54fbc9b393d7d7b7e49f3f17f3178e817f2e94/third_party/WebKit/Source/core/layout/LayoutGrid.cpp [modify] https://crrev.com/ee54fbc9b393d7d7b7e49f3f17f3178e817f2e94/third_party/WebKit/Source/core/layout/LayoutGrid.h
,
Nov 9 2016
Should be fixed now.
,
Nov 11 2016
Ya Pada 2 Nov 2016 16:45, "svil… via monorail" < monorail+v2.2596945094@chromium.org> menulis: min-/max-sizes are ignored when finding the used flex fraction with an indefinite free space |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by e...@chromium.org
, Oct 31 2016