"LocalDiscoveryUITest.RegisterTest" is flaky |
||||||
Issue description"LocalDiscoveryUITest.RegisterTest" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLAsSBUZsYWtlIiFMb2NhbERpc2NvdmVyeVVJVGVzdC5SZWdpc3RlclRlc3QM. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Oct 31 2016
... Then there's a bunch of ASAN warnings, which are probably symptoms.
,
Oct 31 2016
... Then there's a bunch of ASAN warnings, which are probably symptoms. I failed to find a culprit, maybe https://codereview.chromium.org/2459823002 seems the most likely since it touches signin-related code? Sounds like a rename cl though. Alternatively https://codereview.chromium.org/2445583002? It sounds like a move CL though. Finally there's https://codereview.chromium.org/2450843002, which does actual UI changes. Maybe I'll try reverting that one. Both CLs line up well time-wise. I'm not sure,
,
Oct 31 2016
Or wait, maybe https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/local_discovery/local_discovery_ui_browsertest.cc?dr=CSs&q=LocalDiscoveryUITest&sq=package:chromium&l=523 isn't about signin at all? It seems to test chrome://devices, which I guess is related to signin and sync. vitalybuka@, since you're an OWNER for the test, maybe you're better equipped to figure this out. I'll disable the test for now.
,
Oct 31 2016
,
Oct 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ddfbff157635b5d3a7e6b7b089c7d4139dd76c8e commit ddfbff157635b5d3a7e6b7b089c7d4139dd76c8e Author: phoglund <phoglund@chromium.org> Date: Mon Oct 31 13:18:35 2016 Disabling flaky LocalDiscoveryUITest.RegisterTest BUG= 660669 TBR=vitalybuka@chromium.org Review-Url: https://codereview.chromium.org/2459343002 Cr-Commit-Position: refs/heads/master@{#428695} [modify] https://crrev.com/ddfbff157635b5d3a7e6b7b089c7d4139dd76c8e/chrome/browser/ui/webui/local_discovery/local_discovery_ui_browsertest.cc
,
Feb 21 2017
,
Feb 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/83cfba4c65a0a545656dfb2babe8a423be83fd62 commit 83cfba4c65a0a545656dfb2babe8a423be83fd62 Author: vitalybuka <vitalybuka@chromium.org> Date: Wed Feb 22 23:43:19 2017 Fix flaky tests by disabling DeviceDiscoveryNotification service. Tests assume that nothing else uses local discovery code. BUG= 689305 , 660669 Review-Url: https://codereview.chromium.org/2706183002 Cr-Commit-Position: refs/heads/master@{#452275} [modify] https://crrev.com/83cfba4c65a0a545656dfb2babe8a423be83fd62/chrome/browser/extensions/api/gcd_private/gcd_private_apitest.cc [modify] https://crrev.com/83cfba4c65a0a545656dfb2babe8a423be83fd62/chrome/browser/ui/webui/local_discovery/local_discovery_ui_browsertest.cc
,
Feb 23 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by phoglund@chromium.org
, Oct 31 2016Error is [26608:26608:1028/160751:INFO:CONSOLE(7551)] "Running test expectPageAdding1", source: local_discovery_ui_test.js (7551) unknown file: Failure Unexpected mock function call - returning directly. Function call: OnCreateFakeURLFetcher(@0x6120001f09c8 "http://1.2.3.4:8888/privet/info") Google Mock tried the following 9 expectations, but none matched: ../../chrome/browser/ui/webui/local_discovery/local_discovery_ui_browsertest.cc:414: tried expectation #0: EXPECT_CALL(fake_url_fetcher_creator(), OnCreateFakeURLFetcher( GaiaUrls::GetInstance()->oauth2_token_url().spec()))... Expected arg #0: is equal to "https://www.googleapis.com/oauth2/v4/token" Actual: "http://1.2.3.4:8888/privet/info" Expected: to be called any number of times Actual: called 4 times - satisfied and active ../../chrome/browser/ui/webui/local_discovery/local_discovery_ui_browsertest.cc:424: tried expectation #1: EXPECT_CALL(fake_url_fetcher_creator(), OnCreateFakeURLFetcher( GaiaUrls::GetInstance()->oauth_user_info_url().spec()))... Expected arg #0: is equal to "https://www.googleapis.com/oauth2/v1/userinfo" Actual: "http://1.2.3.4:8888/privet/info" Expected: to be called any number of times Actual: called 3 times - satisfied and active ../../chrome/browser/ui/webui/local_discovery/local_discovery_ui_browsertest.cc:537: tried expectation #2: EXPECT_CALL(fake_url_fetcher_creator(), OnCreateFakeURLFetcher(kURLInfo))... Expected: the expectation is active Actual: it is retired Expected: to be called once Actual: called once - saturated and retired ../../chrome/browser/ui/webui/local_discovery/local_discovery_ui_browsertest.cc:539: tried expectation #3: EXPECT_CALL(fake_url_fetcher_creator(), OnCreateFakeURLFetcher( kURLRegisterStart))... Expected: the expectation is active Actual: it is retired Expected: to be called once Actual: called once - saturated and retired ../../chrome/browser/ui/webui/local_discovery/local_discovery_ui_browsertest.cc:541: tried expectation #4: EXPECT_CALL(fake_url_fetcher_creator(), OnCreateFakeURLFetcher( kURLRegisterClaimToken))... Expected arg #0: is equal to "http://1.2.3.4:8888/privet/register?action=getClaimToken&user=user%40consumer.example.com" Actual: "http://1.2.3.4:8888/privet/info" Expected: to be called once Actual: called once - saturated and active ../../chrome/browser/ui/webui/local_discovery/local_discovery_ui_browsertest.cc:567: tried expectation #5: EXPECT_CALL(fake_url_fetcher_creator(), OnCreateFakeURLFetcher( kURLRegisterClaimToken))... Expected arg #0: is equal to "http://1.2.3.4:8888/privet/register?action=getClaimToken&user=user%40consumer.example.com" Actual: "http://1.2.3.4:8888/privet/info" Expected: to be called once Actual: never called - unsatisfied and active ../../chrome/browser/ui/webui/local_discovery/local_discovery_ui_browsertest.cc:569: tried expectation #6: EXPECT_CALL(fake_url_fetcher_creator(), OnCreateFakeURLFetcher( kURLCloudPrintConfirm))... Expected arg #0: is equal to "https://www.google.com/cloudprint/confirm?token=MySampleToken" Actual: "http://1.2.3.4:8888/privet/info" Expected: to be called once Actual: never called - unsatisfied and active ../../chrome/browser/ui/webui/local_discovery/local_discovery_ui_browsertest.cc:571: tried expectation #7: EXPECT_CALL(fake_url_fetcher_creator(), OnCreateFakeURLFetcher( kURLRegisterComplete))... Expected arg #0: is equal to "http://1.2.3.4:8888/privet/register?action=complete&user=user%40consumer.example.com" Actual: "http://1.2.3.4:8888/privet/info" Expected: to be called once Actual: never called - unsatisfied and active ../../chrome/browser/ui/webui/local_discovery/local_discovery_ui_browsertest.cc:572: tried expectation #8: EXPECT_CALL(fake_url_fetcher_creator(), OnCreateFakeURLFetcher(kURLInfo))... Expected: all pre-requisites are satisfied Actual: the following immediate pre-requisites are not satisfied: ../../chrome/browser/ui/webui/local_discovery/local_discovery_ui_browsertest.cc:571: pre-requisite #0 (end of pre-requisites) Expected: to be called once Actual: never called - unsatisfied and active [26608:26608:1028/160753:WARNING:gaia_auth_fetcher.cc(702)] Could not reach Google Accounts servers: errno -11