CSS rule setProperty does not apply for background if value is a url()
Reported by
christop...@gmail.com,
Oct 29 2016
|
|||||
Issue description
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.71 Safari/537.36
Steps to reproduce the problem:
1. rule.style.setProperty('background', 'url("bbbbbbb")', '')
2. rule.style.getPropertyValue('background')
3. The value is unchanged
What is the expected behavior?
Apply url value correctly
What went wrong?
This might be connected to https://bugs.chromium.org/p/chromium/issues/detail?id=161644.
Did this work before? N/A
Does this work in other browsers? Yes
Chrome version: 54.0.2840.71 Channel: stable
OS Version:
Flash Version:
,
Oct 31 2016
Able to reproduce the issue on MAC 10.11.6 ,Windows 10.0 & Ubuntu 14.04 using chrome earlier version of M30(30.0.1549.0) and latest Stable #54.0.2840.71 and observed the below output.
Observations:
M30 - M45 : It is displaying as "url()"
M50 - M54 : It is displaying as "url("aaaaaaa")"
Expected output is "url("bbbbbbb")"
This is a Non-Regression issue since seeing this from M30 #30.0.1549.0
Thank you.
,
Oct 31 2016
Setting a relative url works if you previously set to an absolute url. So I think these are comparing equal in CSSImageValue::equals, maybe we aren't passing through the base url information so they both have some sort of invalid absolute url.
,
Nov 1 2016
,
Jan 11 2017
Being worked on by shoon.kim@lge.com: https://codereview.chromium.org/2622993003/
,
Jan 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/67f8202c63cc39ca0a4c3bd444158a7587b9bb4d commit 67f8202c63cc39ca0a4c3bd444158a7587b9bb4d Author: shoon.kim <shoon.kim@lge.com> Date: Mon Jan 16 09:58:10 2017 Compare relative url if absolute urls are empty for CSSImageValue Change to compare relative url if absolute urls are all empty while css set property. BUG= 660663 Review-Url: https://codereview.chromium.org/2622993003 Cr-Commit-Position: refs/heads/master@{#443864} [modify] https://crrev.com/67f8202c63cc39ca0a4c3bd444158a7587b9bb4d/AUTHORS [add] https://crrev.com/67f8202c63cc39ca0a4c3bd444158a7587b9bb4d/third_party/WebKit/LayoutTests/fast/css/background-image-url-setproperty.html [modify] https://crrev.com/67f8202c63cc39ca0a4c3bd444158a7587b9bb4d/third_party/WebKit/Source/core/css/CSSImageValue.cpp
,
Feb 13 2017
,
Oct 31 2017
Seems fixed (probably by the above CL) |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by samli@chromium.org
, Oct 30 2016Status: Untriaged (was: Unconfirmed)