New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 660661 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

CastTransportIPC can send messages to uninitialized channel id

Reported by rchlodni...@opera.com, Oct 29 2016

Issue description

Version: 54.0.2840.71 m

CastTransportIPC considers possibility that CastIPCDispatcher::Get() might return null but in such case, it still sends messages to channel_id_ that wasn't initialized...

It should probably:
a) initialize channel id to invalid value (-1)
b) not send constructor and destructor messages (CastHostMsg_New and CastHostMsg_Delete) when channel_id_ is not initialized
c) assert in public methods that channel_id_ is initialized

This "problem" might not be a problem for Chrome in practice if CastIPCDispatcher::Get() is always non-null, but I found it while debugging cast problem in Opera as we had some bits not enabled.
 

Comment 1 by m...@chromium.org, Oct 29 2016

Cc: -mfo...@chromium.org -sko...@chromium.org x...@chromium.org m...@chromium.org
Components: -Internals>Cast Internals>Cast>Streaming
Good catch. Moved to "Cast Streaming" component, and rewrote cc list.

Comment 2 by sko...@chromium.org, Nov 17 2016

Labels: Hotlist-Fixit
Status: Available (was: Untriaged)

Comment 3 by coron...@gmail.com, Nov 21 2016

I uploaded CL for this issue (https://codereview.chromium.org/2516243002/)

Comment 4 by sko...@chromium.org, May 10 2017

Owner: m...@chromium.org
Status: Assigned (was: Available)
Yuri can you review whether this patch landed and mark this as fixed if appropriate?

Comment 5 by m...@chromium.org, May 10 2017

Status: Fixed (was: Assigned)

Sign in to add a comment