New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 660618 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Add master_build_id, cbb_config tags to master/slave BuildBucket scheduling.

Project Member Reported by d...@chromium.org, Oct 29 2016

Issue description

Reference: https://chromium.googlesource.com/chromiumos/chromite/+/b76b0cba65596fadc4b7ec1ae23090afbd902fff/cbuildbot/stages/sync_stages.py#508

Let's add:
- master_build_id:###
  The master build ID that the slave is building. This will be used to 
- cbb_config:<config_name>
  The name of the cbuildbot config that is being built.

These will let us issue interesting queries, like "show me all builds for this master build ID" and "show me all gru-paladin builds". This is anticipated to be useful for UIs and other data gathering.
 
Owner: nxia@chromium.org

Comment 2 by nxia@chromium.org, Nov 1 2016

sounds good. master can simply get the scheduled slaves by searching for the tag. 
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/171c03878746e725521f2d2c841e4dd06479a521

commit 171c03878746e725521f2d2c841e4dd06479a521
Author: Ningning Xia <nxia@chromium.org>
Date: Tue Nov 01 00:33:29 2016

Add cbb_config, cbb_master_build_id and buildset tags.

Add cbb_config, cbb_master_build_id, buildset tags to
PutBuildRequest in PostSlaveBuildToBuildbucket.

BUG= chromium:660618 
TEST=run_tests

Change-Id: I3bdb4ce85f3d5c883fa08fcd4ccf282e3fa35d93
Reviewed-on: https://chromium-review.googlesource.com/405770
Tested-by: Ningning Xia <nxia@chromium.org>
Trybot-Ready: Ningning Xia <nxia@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/171c03878746e725521f2d2c841e4dd06479a521/cbuildbot/stages/sync_stages.py

Comment 4 by nxia@chromium.org, Nov 4 2016

Status: Fixed (was: Untriaged)

Comment 5 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 6 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 7 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 8 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 9 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 10 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment