New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 660602 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug
VT2



Sign in to add a comment

frecon redraws the screen after every keypress

Project Member Reported by dbehr@chromium.org, Oct 28 2016

Issue description

It should just render what has been update on the terminal due to pressing the key.
 

Comment 1 by dbehr@chromium.org, Oct 29 2016

This is due to frecon resetting scrollback buffer position after every keypress which is reasonable, because terminal should go back to end of scrollback buffer in such case.

libtsm does force redraw on every reset, even though scrollback buffer position does not change. So the screen is redrawn on each keypress even though it does not have to be.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/b59468b0ea8448a3742faf8ea642e8053b4883a4

commit b59468b0ea8448a3742faf8ea642e8053b4883a4
Author: Dominik Behr <dbehr@chromium.org>
Date: Fri Oct 28 23:55:37 2016

libtsm: do not reset scrollback buffer position if it has been already reset

BUG= chromium:660602 
TEST=draw full screen rectangle on frecon VT and then press any key

Change-Id: I590328a1011ddfbb24057aa937c52326a5dd5ab0
Signed-off-by: Dominik Behr <dbehr@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/405107
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>

[rename] https://crrev.com/b59468b0ea8448a3742faf8ea642e8053b4883a4/sys-apps/libtsm/libtsm-3-r2.ebuild
[add] https://crrev.com/b59468b0ea8448a3742faf8ea642e8053b4883a4/sys-apps/libtsm/files/0002-libtsm-do-not-reset-scrollback-position-and-age-if-i.patch

Comment 3 by dbehr@chromium.org, Oct 31 2016

Status: Fixed (was: Started)

Comment 4 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 5 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 6 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 7 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 8 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 9 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment