New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 660598 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Separate Mac signing and diff creation

Project Member Reported by mmoss@chromium.org, Oct 28 2016

Issue description

This will make the Mac pipeline more consistent with the Windows pipeline, and is necessary to migrate to the new signing system (b/31931170), which can't access the resources need to generate diffs.
 

Comment 2 by mmoss@chromium.org, Oct 28 2016

Cc: dimu@chromium.org mark@chromium.org
Components: Infra>Client>Chrome>Release
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 1 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build/+/cdb275d5cdc125db96fc37c28840954a9f2a9393

commit cdb275d5cdc125db96fc37c28840954a9f2a9393
Author: mmoss <mmoss@google.com>
Date: Tue Nov 01 20:14:49 2016

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 1 2016

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 4 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/src-internal.git/+/06eda948ed06c64633456e36733cf51bc18f0546

commit 06eda948ed06c64633456e36733cf51bc18f0546
Author: Michael Moss <mmoss@google.com>
Date: Fri Nov 04 23:32:13 2016

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1b58e59add1ada98d78b6b883da1952e0712fd5

commit f1b58e59add1ada98d78b6b883da1952e0712fd5
Author: mmoss <mmoss@chromium.org>
Date: Fri Nov 04 23:31:02 2016

Add new Chrome signing/diff scripts to build configs.

R=mark@chromium.org
BUG= 660598 

Review-Url: https://codereview.chromium.org/2479543003
Cr-Commit-Position: refs/heads/master@{#430067}

[modify] https://crrev.com/f1b58e59add1ada98d78b6b883da1952e0712fd5/chrome/installer/mac/BUILD.gn

Comment 7 by mmoss@chromium.org, Nov 7 2016

Labels: Merge-Request-54 Merge-Request-55
Need to merge #6 to incorporate signing script changes to beta and stable.

Comment 8 by dimu@chromium.org, Nov 7 2016

Labels: -Merge-Request-54 Merge-Review-54 Hotlist-Merge-Review
[Automated comment] Request affecting a post-stable build (M54), manual review required.

Comment 9 by dimu@chromium.org, Nov 7 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 7 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/buildspec/+/1de5d1d86163cc25136fde85f2c08b7fe2be4736

commit 1de5d1d86163cc25136fde85f2c08b7fe2be4736
Author: Michael Moss <mmoss@google.com>
Date: Mon Nov 07 19:21:44 2016

Labels: -Merge-Approved-55 merge-merged-2883
Per comment #10, this is already merged to M55 branch 2883. Hence,removing "Merge-Approved-55" label and applying "merge-merged-2883" label.
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3955524eebed96b98f529530186f75d857aea1e

commit d3955524eebed96b98f529530186f75d857aea1e
Author: Michael Moss <mmoss@google.com>
Date: Mon Nov 07 19:25:14 2016

Add new Chrome signing/diff scripts to build configs.

R=mark@chromium.org
BUG= 660598 

Review-Url: https://codereview.chromium.org/2479543003
Cr-Commit-Position: refs/heads/master@{#430067}
(cherry picked from commit f1b58e59add1ada98d78b6b883da1952e0712fd5)

Review URL: https://codereview.chromium.org/2476403002 .

Cr-Commit-Position: refs/branch-heads/2883@{#479}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/d3955524eebed96b98f529530186f75d857aea1e/chrome/installer/mac/BUILD.gn

Comment 13 by mmoss@google.com, Nov 7 2016

Cc: bustamante@chromium.org
Per CL comment from bustamante, waiting until after tonight's Stable RC to land to 2840.
Project Member

Comment 14 by bugdroid1@chromium.org, Nov 8 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/buildspec/+/17faeba9635f21dda3f0d752bb83882aeb2500b7

commit 17faeba9635f21dda3f0d752bb83882aeb2500b7
Author: Michael Moss <mmoss@google.com>
Date: Tue Nov 08 22:02:56 2016

Project Member

Comment 15 by bugdroid1@chromium.org, Nov 8 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/407872adfa8191bf7d0a2b890dc923c65dbbca80

commit 407872adfa8191bf7d0a2b890dc923c65dbbca80
Author: Michael Moss <mmoss@google.com>
Date: Tue Nov 08 22:05:09 2016

Add new Chrome signing/diff scripts to build configs.

R=mark@chromium.org
BUG= 660598 

Review-Url: https://codereview.chromium.org/2479543003
Cr-Commit-Position: refs/heads/master@{#430067}
(cherry picked from commit f1b58e59add1ada98d78b6b883da1952e0712fd5)

Review URL: https://codereview.chromium.org/2479403004 .

Cr-Commit-Position: refs/branch-heads/2840@{#831}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/407872adfa8191bf7d0a2b890dc923c65dbbca80/chrome/installer/mac/BUILD.gn

Project Member

Comment 16 by bugdroid1@chromium.org, Nov 12 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/src-internal.git/+/facf6689dafd476df21d1e49ca51f12713b76e14

commit facf6689dafd476df21d1e49ca51f12713b76e14
Author: Michael Moss <mmoss@google.com>
Date: Sat Nov 12 03:34:53 2016

Project Member

Comment 17 by bugdroid1@chromium.org, Nov 15 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/buildspec/+/b73446bb14389650d20d6edc61ea74c57d1d1bc2

commit b73446bb14389650d20d6edc61ea74c57d1d1bc2
Author: Michael Moss <mmoss@google.com>
Date: Tue Nov 15 12:57:30 2016

Project Member

Comment 18 by bugdroid1@chromium.org, Nov 18 2016

Project Member

Comment 19 by bugdroid1@chromium.org, Nov 18 2016

Project Member

Comment 20 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build/+/8f2daf80682c6f8577c9ec713182362ac14b524a

commit 8f2daf80682c6f8577c9ec713182362ac14b524a
Author: Michael Moss <mmoss@google.com>
Date: Fri Nov 18 21:35:14 2016

Project Member

Comment 21 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/buildspec/+/04b256510e1ab84cd5566b8eae04e3b401d637bf

commit 04b256510e1ab84cd5566b8eae04e3b401d637bf
Author: Michael Moss <mmoss@google.com>
Date: Fri Nov 18 22:21:52 2016

Project Member

Comment 22 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build/+/efd646eb12633d34d7d054ed5029314b68c78ef9

commit efd646eb12633d34d7d054ed5029314b68c78ef9
Author: Michael Moss <mmoss@google.com>
Date: Fri Nov 18 16:54:18 2016

Project Member

Comment 23 by bugdroid1@chromium.org, Nov 21 2016

Project Member

Comment 24 by bugdroid1@chromium.org, Nov 21 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build/+/2c7cfa66e2aa3eab88f3850891cd040ac3bd1014

commit 2c7cfa66e2aa3eab88f3850891cd040ac3bd1014
Author: Michael Moss <mmoss@google.com>
Date: Mon Nov 21 18:36:44 2016

Project Member

Comment 25 by bugdroid1@chromium.org, Nov 21 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/release/scripts/+/c8ee950d20f79000417beebbee34333734f18392

commit c8ee950d20f79000417beebbee34333734f18392
Author: Michael Moss <mmoss@google.com>
Date: Mon Nov 21 19:17:15 2016

Project Member

Comment 26 by bugdroid1@chromium.org, Nov 28 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/buildspec/+/c551950c264efafaa187dc35e28814ccfc58dc23

commit c551950c264efafaa187dc35e28814ccfc58dc23
Author: Michael Moss <mmoss@google.com>
Date: Mon Nov 28 16:57:10 2016

Project Member

Comment 27 by bugdroid1@chromium.org, Nov 28 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/buildspec/+/0799b241a5603a7ce95cb59acdc4f623dcd0da0f

commit 0799b241a5603a7ce95cb59acdc4f623dcd0da0f
Author: Michael Moss <mmoss@google.com>
Date: Mon Nov 28 17:34:04 2016

Project Member

Comment 28 by bugdroid1@chromium.org, Dec 1 2016

Project Member

Comment 29 by bugdroid1@chromium.org, Dec 2 2016

Project Member

Comment 30 by bugdroid1@chromium.org, Dec 2 2016

Project Member

Comment 31 by bugdroid1@chromium.org, Dec 2 2016

Project Member

Comment 32 by bugdroid1@chromium.org, Dec 2 2016

Project Member

Comment 33 by bugdroid1@chromium.org, Dec 3 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/release/scripts/+/c3c4df354f170f9ac998777d354362a5902d0141

commit c3c4df354f170f9ac998777d354362a5902d0141
Author: Michael Moss <mmoss@google.com>
Date: Sat Dec 03 01:01:00 2016

Project Member

Comment 34 by bugdroid1@chromium.org, Dec 13 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/release/scripts/+/399534150e66c142be7c4b69c2fb20549857d2b9

commit 399534150e66c142be7c4b69c2fb20549857d2b9
Author: Michael Moss <mmoss@google.com>
Date: Tue Dec 13 00:54:01 2016

Comment 35 by mmoss@chromium.org, Dec 13 2016

Status: Fixed (was: Started)
This is fully switched over to the new pipeline now.
Project Member

Comment 36 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13fae548aca8b89f4652711d411975c606f4377c

commit 13fae548aca8b89f4652711d411975c606f4377c
Author: Robert Sesek <rsesek@chromium.org>
Date: Tue Jul 24 19:49:13 2018

[Mac] Stop including generate_diffs in the installer packaging tools.

The script is no longer used by the signing pipeline and will be
removed in https://chrome-internal-review.googlesource.com/c/654803.

Bug:  660598 
Change-Id: Ia80e4dfbf186c2142b8aff021e3842f87c44a2ad
Reviewed-on: https://chromium-review.googlesource.com/1147472
Reviewed-by: Michael Moss <mmoss@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577644}
[modify] https://crrev.com/13fae548aca8b89f4652711d411975c606f4377c/chrome/installer/mac/BUILD.gn

Project Member

Comment 37 by bugdroid1@chromium.org, Jul 25

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/installer/mac/internal/+/04097cb499c2ebfb041f3ed5e2b43e17cfbff328

commit 04097cb499c2ebfb041f3ed5e2b43e17cfbff328
Author: Robert Sesek <rsesek@google.com>
Date: Mon Jul 23 22:07:10 2018

Project Member

Comment 38 by bugdroid1@chromium.org, Jul 25

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/src-internal.git/+/442a61600537d67a9631c60e370cf4556a66b130

commit 442a61600537d67a9631c60e370cf4556a66b130
Author: Robert Sesek <rsesek@google.com>
Date: Wed Jul 25 17:38:35 2018

Project Member

Comment 39 by bugdroid1@chromium.org, Jul 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8811f4f676ba5329ae66580f189130242e47fcae

commit 8811f4f676ba5329ae66580f189130242e47fcae
Author: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed Jul 25 21:04:27 2018

Roll src-internal eade4f0eac2e..442a61600537 (1 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/eade4f0eac2e..442a61600537


Created with:
  gclient setdep -r src-internal@442a61600537

The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:660598 
TBR=mmoss@chromium.org

Change-Id: I21eac030f164eb4397981422abf24a3e6b03e18e
Reviewed-on: https://chromium-review.googlesource.com/1150246
Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578059}
[modify] https://crrev.com/8811f4f676ba5329ae66580f189130242e47fcae/DEPS

Project Member

Comment 40 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/installer/mac/internal/+/0ec3646245a1c52cfe0a121305055a7a9e48ef2a

commit 0ec3646245a1c52cfe0a121305055a7a9e48ef2a
Author: Greg Kerr <kerrnel@google.com>
Date: Mon Oct 15 21:41:39 2018

Sign in to add a comment