New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 660596 link

Starred by 2 users
Status: Fixed
Owner:
█ lushnikov@chromium.org
Last visit 29 days ago
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

[REGRESSION] DevTools: a random workspace file gets selected on reload

Project Member Reported by lushnikov@chromium.org, Oct 28 2016 
Version: M-55
OS: All

What steps will reproduce the problem?
(1) Open devtools, setup workspace
(2) Open a bunch of workspace files, which are mapped to network resources
(3) Hit Reload

Expected: opened file tabs stay as-is
Actual: opened files change order, random file gets selected.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a31eac72f8252705bac3cee5823d0ec92d8d857

commit 1a31eac72f8252705bac3cee5823d0ec92d8d857
Author: lushnikov <lushnikov@chromium.org>
Date: Sat Oct 29 00:24:17 2016

DevTools: [Persistence] tabs should not change order during reload

During page reload, the network UISourceCodes are removed and then
re-added. This results in bindings being removed and then re-added.

However, currently we're not doing a good job maintaining the selected
tab and the tab order - they're getting shuffled during this process.

This patch fixes the behavior so that the reload does not mess tabs
order.

BUG= 660596 
R=dgozman

Review-Url: https://codereview.chromium.org/2460513003
Cr-Commit-Position: refs/heads/master@{#428555}

[modify] https://crrev.com/1a31eac72f8252705bac3cee5823d0ec92d8d857/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-merge-editor-tabs-expected.txt
[modify] https://crrev.com/1a31eac72f8252705bac3cee5823d0ec92d8d857/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-merge-editor-tabs.html
[add] https://crrev.com/1a31eac72f8252705bac3cee5823d0ec92d8d857/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-tabbed-editor-tabs-order-expected.txt
[add] https://crrev.com/1a31eac72f8252705bac3cee5823d0ec92d8d857/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-tabbed-editor-tabs-order.html
[add] https://crrev.com/1a31eac72f8252705bac3cee5823d0ec92d8d857/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/resources/bar.js
[add] https://crrev.com/1a31eac72f8252705bac3cee5823d0ec92d8d857/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/resources/baz.js
[modify] https://crrev.com/1a31eac72f8252705bac3cee5823d0ec92d8d857/third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js

Comment 2 by lushnikov@chromium.org, Oct 31 2016

Labels: -lusha-merge-tbd -Pri-3 Merge-Request-55 Pri-2
Works as expected on Chrome Canary 56.0.2905.0
Would be nice to have this in M-55.

Comment 3 by gov...@chromium.org, Oct 31 2016

Labels: OS-All

Comment 4 by dimu@chromium.org, Oct 31 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 31 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12ae86e1fe82dcbd440a34c7ea5ccc6e9a5e8529

commit 12ae86e1fe82dcbd440a34c7ea5ccc6e9a5e8529
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Oct 31 19:22:21 2016

DevTools: [Persistence] tabs should not change order during reload

During page reload, the network UISourceCodes are removed and then
re-added. This results in bindings being removed and then re-added.

However, currently we're not doing a good job maintaining the selected
tab and the tab order - they're getting shuffled during this process.

This patch fixes the behavior so that the reload does not mess tabs
order.

BUG= 660596 
R=dgozman

Review-Url: https://codereview.chromium.org/2460513003
Cr-Commit-Position: refs/heads/master@{#428555}
(cherry picked from commit 1a31eac72f8252705bac3cee5823d0ec92d8d857)

Review URL: https://codereview.chromium.org/2462163002 .

Cr-Commit-Position: refs/branch-heads/2883@{#388}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/12ae86e1fe82dcbd440a34c7ea5ccc6e9a5e8529/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-merge-editor-tabs-expected.txt
[modify] https://crrev.com/12ae86e1fe82dcbd440a34c7ea5ccc6e9a5e8529/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-merge-editor-tabs.html
[add] https://crrev.com/12ae86e1fe82dcbd440a34c7ea5ccc6e9a5e8529/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-tabbed-editor-tabs-order-expected.txt
[add] https://crrev.com/12ae86e1fe82dcbd440a34c7ea5ccc6e9a5e8529/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-tabbed-editor-tabs-order.html
[add] https://crrev.com/12ae86e1fe82dcbd440a34c7ea5ccc6e9a5e8529/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/resources/bar.js
[add] https://crrev.com/12ae86e1fe82dcbd440a34c7ea5ccc6e9a5e8529/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/resources/baz.js
[modify] https://crrev.com/12ae86e1fe82dcbd440a34c7ea5ccc6e9a5e8529/third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js

Comment 6 by lushnikov@chromium.org, Oct 31 2016

Status: Fixed (was: Started)
►

Sign in to add a comment