New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 660584 link

Starred by 2 users
Status: Assigned
Owner:
linds...@chromium.org
Cc:
█ yzjr@chromium.org
eugene...@chromium.org
ericale@chromium.org
linds...@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task



Sign in to add a comment

Fix tab_test_utils to return bool on failure

Project Member Reported by baxley@chromium.org, Oct 28 2016 
utilities like CloseAllIncognitoTabs() in tab_test_util.mm, expect to close all incognito tabs, and return to normal mode. It would be useful to let the caller know if this failed so they can assert.
Project Member

Comment 1 by sheriffbot@chromium.org, Oct 30 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by pkl@chromium.org, Oct 30 2017

Owner: baxley@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by baxley@chromium.org, Nov 2 2017

Cc: eugene...@chromium.org
Components: -Test>iOS Tests
Status: Available (was: Assigned)

Comment 4 by baxley@chromium.org, Nov 18 2017

Owner: ----
Project Member

Comment 5 by sheriffbot@chromium.org, Nov 19

Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by eugene...@chromium.org, Nov 19

Cc: -baxley@chromium.org -liaoyuke@chromium.org -huangml@chromium.org yzjr@chromium.org
Labels: -Type-Bug Type-Task
Yang, is this something that your team can do? Currently utilities like CloseAllIncognitoTabs()  can fail to perform the action without failing the test.

Comment 7 by kkhorimoto@chromium.org, Nov 29

Cc: linds...@chromium.org ericale@chromium.org
Not sure who the right person to handle EG infra issues; cc'ing Lindsay, Yang, and Eric.

Comment 8 by pkl@chromium.org, Dec 3

Owner: yzjr@chromium.org
Status: Assigned (was: Untriaged)
Please triage. Thanks!

Comment 9 by linds...@chromium.org, Dec 3

Owner: linds...@chromium.org
THis is something I can review as part of porting utils over to EG2.
►

Sign in to add a comment