New issue
Advanced search Search tips

Issue 660580 link

Starred by 2 users
Status: Fixed
Owner:
qyears...@chromium.org
Closed: Nov 2016
Cc:
jeffcarp@chromium.org
thomasanderson@chromium.org
dpranke@chromium.org
vhang@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 665917
issue 666825


Sign in to add a comment

Drop Precise support for layout tests

Project Member Reported by qyears...@chromium.org, Oct 28 2016 
I think that this will involve:

 - Removing Linux WebKit Precise and linux_precise_blink_rel
 - Changing the name and version for the ASAN, MSAN, Leak and debug builders on chromium.webkit and tryserver.blink from Precise to Trusty
 - Updating the related recipe/recipe_module config
 - Updating src/tools/mb/mb_config.pyl
 - Possibly updating the version used by the android builders?
 - Some references to linux_precise_blink_rel will also be have to be updated

And, in the Blink codebase:
 - Removing the linux-precise layout test port
 - Removing the linux-precise baselines

Perhaps this could be done in a several separate parts (not necessarily exactly this order, but some steps have order dependencies):
 1. Update any references to linux_precise_blink_rel to point to linux_trusty_blink_rel
 2. Add entries in src/tools/mb/mb_config.pyl for ASAN, MSAN, Leak and debug trusty builders
 3. Remove the linux-precise port and entries in webkitpy/common/config/builders.py
 4. Remove Linux WebKit Precise and linux_precise_blink_rel
 5. Update the ASAN, MSAN, Leak and debug Precise builders to Trusty, including recipe changes
 6. Remove the linux-precise baselines

Comment 1 by qyears...@chromium.org, Oct 28 2016

Cc: thomasanderson@chromium.org

Comment 2 by dpranke@chromium.org, Oct 31 2016 

I think the list all looks necessary (except for the android builders thing, I don't know why we'd care about that). 

There's also removing the code and config support from webkitpy itself.

But there's also another dependency, which is that we also run the layout tests on a subset of changes in linux_chromium_rel_ng, and those are also Precise builders.

It looks like there's ~30 tests that produce different results on Precise. I suggest we just skip them on Precise for now (and do this before you stop running the CI builder). Once linux_chromium_rel_ng is upgraded, then you can remove the code support.

Comment 3 by qyears...@chromium.org, Nov 2 2016

Cc: -qyears...@chromium.org
Owner: qyears...@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57a4bee8ee4b20eac493881604150a2446bf1387

commit 57a4bee8ee4b20eac493881604150a2446bf1387
Author: qyearsley <qyearsley@chromium.org>
Date: Thu Nov 03 01:22:03 2016

Remove Precise-specific baselines.

This CL is in preparation for removing support for Precise for layout tests.

BUG= 660580 

Review-Url: https://codereview.chromium.org/2469543002
Cr-Commit-Position: refs/heads/master@{#429499}

[modify] https://crrev.com/57a4bee8ee4b20eac493881604150a2446bf1387/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/b231468fd5825415fff761c25f561c8c782ab25c/third_party/WebKit/LayoutTests/platform/linux-precise/compositing/overflow/do-not-repaint-if-scrolling-composited-layers-expected.txt
[delete] https://crrev.com/b231468fd5825415fff761c25f561c8c782ab25c/third_party/WebKit/LayoutTests/platform/linux-precise/fast/borders/border-antialiasing-expected.png
[delete] https://crrev.com/b231468fd5825415fff761c25f561c8c782ab25c/third_party/WebKit/LayoutTests/platform/linux-precise/fast/canvas/canvas-composite-video-shadow-expected.png
[delete] https://crrev.com/b231468fd5825415fff761c25f561c8c782ab25c/third_party/WebKit/LayoutTests/platform/linux-precise/fast/forms/color/color-suggestion-picker-appearance-zoom200-expected.png
[delete] https://crrev.com/b231468fd5825415fff761c25f561c8c782ab25c/third_party/WebKit/LayoutTests/platform/linux-precise/fast/text/complex-text-opacity-expected.png
[delete] https://crrev.com/b231468fd5825415fff761c25f561c8c782ab25c/third_party/WebKit/LayoutTests/platform/linux-precise/fast/text/font-fallback-expected.png
[delete] https://crrev.com/b231468fd5825415fff761c25f561c8c782ab25c/third_party/WebKit/LayoutTests/platform/linux-precise/fast/text/international/complex-character-based-fallback-expected.png
[delete] https://crrev.com/b231468fd5825415fff761c25f561c8c782ab25c/third_party/WebKit/LayoutTests/platform/linux-precise/fast/text/international/complex-character-based-fallback-expected.txt
[delete] https://crrev.com/b231468fd5825415fff761c25f561c8c782ab25c/third_party/WebKit/LayoutTests/platform/linux-precise/fast/text/international/complex-joining-using-gpos-expected.png
[delete] https://crrev.com/b231468fd5825415fff761c25f561c8c782ab25c/third_party/WebKit/LayoutTests/platform/linux-precise/fast/text/international/thai-line-breaks-expected.png
[delete] https://crrev.com/b231468fd5825415fff761c25f561c8c782ab25c/third_party/WebKit/LayoutTests/platform/linux-precise/fast/text/unicode-fallback-font-expected.txt
[delete] https://crrev.com/b231468fd5825415fff761c25f561c8c782ab25c/third_party/WebKit/LayoutTests/platform/linux-precise/http/tests/security/isolatedWorld/media-query-wrapper-leaks-expected.txt
[delete] https://crrev.com/b231468fd5825415fff761c25f561c8c782ab25c/third_party/WebKit/LayoutTests/platform/linux-precise/imported/wpt/dom/nodes/Document-getElementsByTagName-xhtml-expected.png
[delete] https://crrev.com/b231468fd5825415fff761c25f561c8c782ab25c/third_party/WebKit/LayoutTests/platform/linux-precise/inspector-protocol/layout-fonts/languages-emoji-rare-glyphs-expected.txt
[delete] https://crrev.com/b231468fd5825415fff761c25f561c8c782ab25c/third_party/WebKit/LayoutTests/platform/linux-precise/scrollbars/overflow-scrollbar-combinations-expected.png
[delete] https://crrev.com/b231468fd5825415fff761c25f561c8c782ab25c/third_party/WebKit/LayoutTests/platform/linux-precise/svg/W3C-SVG-1.1/paths-data-03-f-expected.png
[delete] https://crrev.com/b231468fd5825415fff761c25f561c8c782ab25c/third_party/WebKit/LayoutTests/platform/linux-precise/svg/W3C-SVG-1.1/text-align-08-b-expected.png
[delete] https://crrev.com/b231468fd5825415fff761c25f561c8c782ab25c/third_party/WebKit/LayoutTests/platform/linux-precise/svg/W3C-SVG-1.1/text-align-08-b-expected.txt
[delete] https://crrev.com/b231468fd5825415fff761c25f561c8c782ab25c/third_party/WebKit/LayoutTests/platform/linux-precise/svg/custom/control-points-for-S-and-T-expected.png
[delete] https://crrev.com/b231468fd5825415fff761c25f561c8c782ab25c/third_party/WebKit/LayoutTests/platform/linux-precise/svg/wicd/test-rightsizing-b-expected.txt
[delete] https://crrev.com/b231468fd5825415fff761c25f561c8c782ab25c/third_party/WebKit/LayoutTests/platform/linux-precise/transforms/2d/hindi-rotated-expected.png
[delete] https://crrev.com/b231468fd5825415fff761c25f561c8c782ab25c/third_party/WebKit/LayoutTests/platform/linux-precise/virtual/display_list_2d_canvas/fast/canvas/canvas-pattern-no-repeat-with-transformations-expected.png
[delete] https://crrev.com/b231468fd5825415fff761c25f561c8c782ab25c/third_party/WebKit/LayoutTests/platform/linux-precise/virtual/display_list_2d_canvas/fast/canvas/canvas-shadow-source-in-expected.png
[delete] https://crrev.com/b231468fd5825415fff761c25f561c8c782ab25c/third_party/WebKit/LayoutTests/platform/linux-precise/virtual/gpu/fast/canvas/canvas-arc-circumference-fill-expected.png
[delete] https://crrev.com/b231468fd5825415fff761c25f561c8c782ab25c/third_party/WebKit/LayoutTests/platform/linux-precise/virtual/gpu/fast/canvas/canvas-pattern-no-repeat-with-transformations-expected.png
[delete] https://crrev.com/b231468fd5825415fff761c25f561c8c782ab25c/third_party/WebKit/LayoutTests/platform/linux-precise/virtual/scalefactor150/fast/hidpi/static/drag-image-expected.png
[delete] https://crrev.com/b231468fd5825415fff761c25f561c8c782ab25c/third_party/WebKit/LayoutTests/platform/linux-precise/virtual/scalefactor150/fast/hidpi/static/drag-image-expected.txt
[delete] https://crrev.com/b231468fd5825415fff761c25f561c8c782ab25c/third_party/WebKit/LayoutTests/platform/linux-precise/virtual/scalefactor200/fast/hidpi/static/drag-image-expected.png
[delete] https://crrev.com/b231468fd5825415fff761c25f561c8c782ab25c/third_party/WebKit/LayoutTests/platform/linux-precise/virtual/scalefactor200withzoom/fast/hidpi/static/drag-image-expected.png
[delete] https://crrev.com/b231468fd5825415fff761c25f561c8c782ab25c/third_party/WebKit/LayoutTests/platform/linux-precise/virtual/scalefactor200withzoom/fast/hidpi/static/drag-image-expected.txt
[delete] https://crrev.com/b231468fd5825415fff761c25f561c8c782ab25c/third_party/WebKit/LayoutTests/platform/linux-precise/virtual/threaded/printing/fixed-positioned-headers-and-footers-expected.png
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/7d94be51508e2e4d3f0681ed1d8ae603ff28eb44

commit 7d94be51508e2e4d3f0681ed1d8ae603ff28eb44
Author: qyearsley <qyearsley@chromium.org>
Date: Thu Nov 03 10:29:15 2016

Update usage of linux blink try bot to use linux_trusty_blink_rel.

Reason: We're planning to drop support for Linux Precise for layout tests.

BUG= chromium:660580 
NOTRY=true

Review-Url: https://codereview.chromium.org/2475563002
Cr-Commit-Position: refs/heads/master@{#40717}

[modify] https://crrev.com/7d94be51508e2e4d3f0681ed1d8ae603ff28eb44/tools/release/auto_roll.py
[modify] https://crrev.com/7d94be51508e2e4d3f0681ed1d8ae603ff28eb44/tools/release/test_scripts.py
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab87a374dd800813751d405a6fdf3a4c4b3066f7

commit ab87a374dd800813751d405a6fdf3a4c4b3066f7
Author: qyearsley <qyearsley@chromium.org>
Date: Tue Nov 08 18:54:02 2016

Update references to linux_precise_blink_rel in src.

Reason: We're planning to drop support for Linux Precise for layout tests.

BUG= 660580 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2470243002
Cr-Commit-Position: refs/heads/master@{#430673}

[modify] https://crrev.com/ab87a374dd800813751d405a6fdf3a4c4b3066f7/cc/PRESUBMIT.py
[modify] https://crrev.com/ab87a374dd800813751d405a6fdf3a4c4b3066f7/docs/updating_clang.md
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7635498a5c8144b28ffa5a22127038e41a9ce6e9

commit 7635498a5c8144b28ffa5a22127038e41a9ce6e9
Author: qyearsley <qyearsley@chromium.org>
Date: Wed Nov 09 01:39:19 2016

Add new Trusty builders to mb_config.pyl.

BUG= 660580 

Review-Url: https://codereview.chromium.org/2486063002
Cr-Commit-Position: refs/heads/master@{#430809}

[modify] https://crrev.com/7635498a5c8144b28ffa5a22127038e41a9ce6e9/tools/mb/mb_config.pyl
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5d0b7d83a0ff8641db0c2269661721d494d6d77

commit a5d0b7d83a0ff8641db0c2269661721d494d6d77
Author: qyearsley <qyearsley@chromium.org>
Date: Thu Nov 10 04:09:22 2016

Add new Trusty builders to src/testing/buildbot/chromium.webkit.json.

BUG= 660580 

Review-Url: https://codereview.chromium.org/2482243003
Cr-Commit-Position: refs/heads/master@{#431177}

[modify] https://crrev.com/a5d0b7d83a0ff8641db0c2269661721d494d6d77/testing/buildbot/chromium.webkit.json

Comment 9 by qyears...@chromium.org, Nov 10 2016 

Related bug for replacing the builders on chromium.webkit: bug 661834 (now already done).

Current status: steps 1 and 2 from the original post are done, I think the next step is to rename the MSAN/ASAN/Leak/dbg builders from Precise to Trusty, and drop the Precise bot (http://crrev.com/2484343002)
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/994a2c68356fcde952b49925e6fd8890eab39b59

commit 994a2c68356fcde952b49925e6fd8890eab39b59
Author: qyearsley <qyearsley@chromium.org>
Date: Mon Nov 14 21:32:59 2016

Drop Precise blink builders, add corresponding Trusty builders.

This CL would:

 - Drop "WebKit Linux Precise" from chromium.webkit
 - Replace "WebKit Linux Precise *" with "WebKit Linux Trusty *".
 - Update config in chromium_tests recipe module.

BUG= 660580 

Review-Url: https://codereview.chromium.org/2484343002

[modify] https://crrev.com/994a2c68356fcde952b49925e6fd8890eab39b59/masters/master.chromium.webkit/master_linux_webkit_latest_cfg.py
[modify] https://crrev.com/994a2c68356fcde952b49925e6fd8890eab39b59/masters/master.chromium.webkit/slaves.cfg
[modify] https://crrev.com/994a2c68356fcde952b49925e6fd8890eab39b59/scripts/slave/recipe_modules/chromium_tests/chromium_webkit.py
[modify] https://crrev.com/994a2c68356fcde952b49925e6fd8890eab39b59/scripts/slave/recipe_modules/chromium_tests/trybots.py
[modify] https://crrev.com/994a2c68356fcde952b49925e6fd8890eab39b59/scripts/slave/recipes/chromium.expected/chromium_webkit_crash.json
[modify] https://crrev.com/994a2c68356fcde952b49925e6fd8890eab39b59/scripts/slave/recipes/chromium.expected/chromium_webkit_revision_chromium.json
[modify] https://crrev.com/994a2c68356fcde952b49925e6fd8890eab39b59/scripts/slave/recipes/chromium.expected/chromium_webkit_revision_webkit.json
[modify] https://crrev.com/994a2c68356fcde952b49925e6fd8890eab39b59/scripts/slave/recipes/chromium.expected/chromium_webkit_warnings.json
[delete] https://crrev.com/3fd0f01c144f2c0459695ae1c8660f09a80227b9/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Linux_Precise_Leak.json
[modify] https://crrev.com/994a2c68356fcde952b49925e6fd8890eab39b59/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Linux_Trusty.json
[rename] https://crrev.com/994a2c68356fcde952b49925e6fd8890eab39b59/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Linux_Trusty_ASAN.json
[rename] https://crrev.com/994a2c68356fcde952b49925e6fd8890eab39b59/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Linux_Trusty_Leak.json
[rename] https://crrev.com/994a2c68356fcde952b49925e6fd8890eab39b59/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Linux_Trusty_MSAN.json
[rename] https://crrev.com/994a2c68356fcde952b49925e6fd8890eab39b59/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Linux_Trusty__dbg_.json
[modify] https://crrev.com/994a2c68356fcde952b49925e6fd8890eab39b59/scripts/slave/recipes/chromium.py
[modify] https://crrev.com/994a2c68356fcde952b49925e6fd8890eab39b59/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_trusty_blink_rel.json

Comment 11 by qyears...@chromium.org, Nov 14 2016

Status: Started (was: Assigned)
Also see bug 664241 for current master restart request

Comment 12 by qyears...@chromium.org, Nov 16 2016

Blockedon: 665917
Project Member

Comment 13 by bugdroid1@chromium.org, Nov 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/745af0be287c0ef9e2af4694e80760931574945c

commit 745af0be287c0ef9e2af4694e80760931574945c
Author: qyearsley <qyearsley@chromium.org>
Date: Wed Nov 16 17:44:50 2016

Revert of Update references to linux_precise_blink_rel in src. (patchset #1 id:1 of https://codereview.chromium.org/2470243002/ )

Reason for revert:
Submitting this before more capacity was added to linux_trusty_blink_rel caused that builder to get too busy (http://crbug.com/665246); should be able to reland after  http://crbug.com/665917  is fixed.

Original issue's description:
> Update references to linux_precise_blink_rel in src.
>
> Reason: We're planning to drop support for Linux Precise for layout tests.
>
> BUG= 660580 
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
>
> Committed: https://crrev.com/ab87a374dd800813751d405a6fdf3a4c4b3066f7
> Cr-Commit-Position: refs/heads/master@{#430673}

TBR=dpranke@chromium.org,enne@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 660580 

Review-Url: https://codereview.chromium.org/2504373002
Cr-Commit-Position: refs/heads/master@{#432545}

[modify] https://crrev.com/745af0be287c0ef9e2af4694e80760931574945c/cc/PRESUBMIT.py
[modify] https://crrev.com/745af0be287c0ef9e2af4694e80760931574945c/docs/updating_clang.md
Project Member

Comment 14 by bugdroid1@chromium.org, Nov 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/04fee02eaf6ee0aaec54c2152f5f532acdc00291

commit 04fee02eaf6ee0aaec54c2152f5f532acdc00291
Author: qyearsley <qyearsley@chromium.org>
Date: Wed Nov 16 19:59:48 2016

Revert of Update usage of linux blink try bot to use linux_trusty_blink_rel. (patchset #1 id:1 of https://codereview.chromium.org/2475563002/ )

Reason for revert:
Submitting this before more capacity was added to linux_trusty_blink_rel caused that builder to get too busy (http://crbug.com/665246); should be able to reland after  http://crbug.com/665917  is fixed.

Original issue's description:
> Update usage of linux blink try bot to use linux_trusty_blink_rel.
>
> Reason: We're planning to drop support for Linux Precise for layout tests.
>
> BUG= chromium:660580 
> NOTRY=true

TBR=machenbach@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= chromium:660580 
NOTRY=true

Review-Url: https://codereview.chromium.org/2507853002
Cr-Commit-Position: refs/heads/master@{#41052}

[modify] https://crrev.com/04fee02eaf6ee0aaec54c2152f5f532acdc00291/tools/release/auto_roll.py
[modify] https://crrev.com/04fee02eaf6ee0aaec54c2152f5f532acdc00291/tools/release/test_scripts.py
Project Member

Comment 15 by bugdroid1@chromium.org, Nov 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/b9e06d9c8bbae1322d9e7155c4216305b14f4b48

commit b9e06d9c8bbae1322d9e7155c4216305b14f4b48
Author: Quinten Yearsley <qyearsley@google.com>
Date: Thu Nov 17 00:31:19 2016

Update builders on tryserver.blink (precise -> trusty).

BUG= 660580 

Change-Id: Id4ab6c7781fb0c844eb719ca9f092be114fa9028
Reviewed-on: https://chromium-review.googlesource.com/411967
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

[modify] https://crrev.com/b9e06d9c8bbae1322d9e7155c4216305b14f4b48/masters/master.tryserver.blink/master.cfg
[modify] https://crrev.com/b9e06d9c8bbae1322d9e7155c4216305b14f4b48/masters/master.tryserver.blink/slaves.cfg
[modify] https://crrev.com/b9e06d9c8bbae1322d9e7155c4216305b14f4b48/scripts/slave/recipe_modules/chromium_tests/trybots.py
[modify] https://crrev.com/b9e06d9c8bbae1322d9e7155c4216305b14f4b48/scripts/slave/recipes/chromium_trybot.expected/blink_compile_without_patch_fails.json
[modify] https://crrev.com/b9e06d9c8bbae1322d9e7155c4216305b14f4b48/scripts/slave/recipes/chromium_trybot.expected/blink_minimal_pass_continues.json
[delete] https://crrev.com/6710cbea23d73008013d69e2a4de68ce4c958db9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_precise_blink_compile_rel.json
[delete] https://crrev.com/6710cbea23d73008013d69e2a4de68ce4c958db9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_precise_blink_rel.json
[rename] https://crrev.com/b9e06d9c8bbae1322d9e7155c4216305b14f4b48/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_trusty_blink_compile_dbg.json
[copy] https://crrev.com/b9e06d9c8bbae1322d9e7155c4216305b14f4b48/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_trusty_blink_compile_rel.json
[rename] https://crrev.com/b9e06d9c8bbae1322d9e7155c4216305b14f4b48/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_trusty_blink_dbg.json
[modify] https://crrev.com/b9e06d9c8bbae1322d9e7155c4216305b14f4b48/scripts/slave/recipes/chromium_trybot.expected/too_many_failures_for_retcode.json
[modify] https://crrev.com/b9e06d9c8bbae1322d9e7155c4216305b14f4b48/scripts/slave/recipes/chromium_trybot.expected/webkit_tests_interrupted.json
[modify] https://crrev.com/b9e06d9c8bbae1322d9e7155c4216305b14f4b48/scripts/slave/recipes/chromium_trybot.expected/webkit_tests_unexpected_error.json
[modify] https://crrev.com/b9e06d9c8bbae1322d9e7155c4216305b14f4b48/scripts/slave/recipes/chromium_trybot.expected/webkit_tests_with_and_without_patch_fail.json
[modify] https://crrev.com/b9e06d9c8bbae1322d9e7155c4216305b14f4b48/scripts/slave/recipes/chromium_trybot.py
Project Member

Comment 16 by bugdroid1@chromium.org, Nov 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/b8e37ffeedc9ea92408de753e30b0821da1d7b3c

commit b8e37ffeedc9ea92408de753e30b0821da1d7b3c
Author: Quinten Yearsley <qyearsley@google.com>
Date: Thu Nov 17 01:48:04 2016

Add entries for precise back to recipe_modules/chromium_tests/trybots.py.

This is a follow-up to https://chromium-review.googlesource.com/c/411967/;
in that CL, I didn't intend to remove entries for precise builders in
recipe_modules/chromium_tests/trybots.py yet, since that CL was changed
to not remove those precise builder names yet.

BUG= 660580 
TBR=dpranke

Change-Id: I27a26a36d07f341c27710e6d51b2e1cb0a56d707
Reviewed-on: https://chromium-review.googlesource.com/412151
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

[modify] https://crrev.com/b8e37ffeedc9ea92408de753e30b0821da1d7b3c/scripts/slave/recipe_modules/chromium_tests/trybots.py
[add] https://crrev.com/b8e37ffeedc9ea92408de753e30b0821da1d7b3c/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_precise_blink_compile_dbg.json
[add] https://crrev.com/b8e37ffeedc9ea92408de753e30b0821da1d7b3c/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_precise_blink_compile_rel.json
[add] https://crrev.com/b8e37ffeedc9ea92408de753e30b0821da1d7b3c/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_precise_blink_dbg.json
[add] https://crrev.com/b8e37ffeedc9ea92408de753e30b0821da1d7b3c/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_precise_blink_rel.json
Project Member

Comment 17 by bugdroid1@chromium.org, Nov 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/468fc9bc7f5e14c463fa9e20f3e677b81f29ccf9

commit 468fc9bc7f5e14c463fa9e20f3e677b81f29ccf9
Author: qyearsley <qyearsley@chromium.org>
Date: Thu Nov 17 18:09:40 2016

Reland of Update references to linux_precise_blink_rel in src. (patchset #1 id:1 of https://codereview.chromium.org/2504373002/ )

Reason for revert:
linux_trusty_blink_rel is now working, with more capacity

Original issue's description:
> Revert of Update references to linux_precise_blink_rel in src. (patchset #1 id:1 of https://codereview.chromium.org/2470243002/ )
>
> Reason for revert:
> Submitting this before more capacity was added to linux_trusty_blink_rel caused that builder to get too busy (http://crbug.com/665246); should be able to reland after  http://crbug.com/665917  is fixed.
>
> Original issue's description:
> > Update references to linux_precise_blink_rel in src.
> >
> > Reason: We're planning to drop support for Linux Precise for layout tests.
> >
> > BUG= 660580 
> > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
> >
> > Committed: https://crrev.com/ab87a374dd800813751d405a6fdf3a4c4b3066f7
> > Cr-Commit-Position: refs/heads/master@{#430673}
>
> TBR=dpranke@chromium.org,enne@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG= 660580 
>
> Committed: https://crrev.com/745af0be287c0ef9e2af4694e80760931574945c
> Cr-Commit-Position: refs/heads/master@{#432545}

TBR=dpranke@chromium.org,enne@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 660580 

Review-Url: https://codereview.chromium.org/2509333002
Cr-Commit-Position: refs/heads/master@{#432914}

[modify] https://crrev.com/468fc9bc7f5e14c463fa9e20f3e677b81f29ccf9/cc/PRESUBMIT.py
[modify] https://crrev.com/468fc9bc7f5e14c463fa9e20f3e677b81f29ccf9/docs/updating_clang.md

Comment 18 by qyears...@chromium.org, Nov 18 2016 

Update: next step is to remove linux_precise_blink*.

CL: https://chromium-review.googlesource.com/c/412261/

But, I found that one more place uses linux_precise_blink_rel, which is the skia deps roller, which should be updated by: https://skia-review.googlesource.com/c/4989/.

After those two CLs, what's left is:

 * Remove the removed builders from //tools/mb/mb_config.pyl and //testing/buildbot/chromium.webkit.json
 * Re-spawn all of the slaves for linux_chromium_rel_ng with Linux Trusty (but not all at once).
 * Remove the linux-precise port.
Project Member

Comment 20 by bugdroid1@chromium.org, Nov 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a70104a9dcae4927b6134de3ed53de57cb15f8b

commit 4a70104a9dcae4927b6134de3ed53de57cb15f8b
Author: qyearsley <qyearsley@chromium.org>
Date: Fri Nov 18 05:59:17 2016

Reland of Update usage of linux blink try bot to use linux_trusty_blink_rel. (patchset #1 id:1 of https://codereview.chromium.org/2507853002/ )

Reason for revert:
linux_trusty_blink_rel is now working, with more capacity

Original issue's description:
> Revert of Update usage of linux blink try bot to use linux_trusty_blink_rel. (patchset #1 id:1 of https://codereview.chromium.org/2475563002/ )
>
> Reason for revert:
> Submitting this before more capacity was added to linux_trusty_blink_rel caused that builder to get too busy (http://crbug.com/665246); should be able to reland after  http://crbug.com/665917  is fixed.
>
> Original issue's description:
> > Update usage of linux blink try bot to use linux_trusty_blink_rel.
> >
> > Reason: We're planning to drop support for Linux Precise for layout tests.
> >
> > BUG= chromium:660580 
> > NOTRY=true
>
> TBR=machenbach@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG= chromium:660580 
> NOTRY=true

TBR=machenbach@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:660580 

Review-Url: https://codereview.chromium.org/2505403002
Cr-Commit-Position: refs/heads/master@{#41090}

[modify] https://crrev.com/4a70104a9dcae4927b6134de3ed53de57cb15f8b/tools/release/auto_roll.py
[modify] https://crrev.com/4a70104a9dcae4927b6134de3ed53de57cb15f8b/tools/release/test_scripts.py
Project Member

Comment 21 by bugdroid1@chromium.org, Nov 18 2016 

The following revision refers to this bug:
  https://skia.googlesource.com/buildbot.git/+/7166dba95d76cc58e6de122a1389f25c0864db1b

commit 7166dba95d76cc58e6de122a1389f25c0864db1b
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Fri Nov 18 01:22:33 2016

Update try bot builder name for skia-deps-autoroller.

BUG= 660580 

Change-Id: I0914976109b8890f39be95304dba63f00ef190eb
Reviewed-on: https://skia-review.googlesource.com/4989
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>

[modify] https://crrev.com/7166dba95d76cc58e6de122a1389f25c0864db1b/autoroll/sys/skia-autorolld.service
Project Member

Comment 22 by bugdroid1@chromium.org, Nov 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/59a2653d5f143213f4f166714657808b0c646bd7

commit 59a2653d5f143213f4f166714657808b0c646bd7
Author: Quinten Yearsley <qyearsley@google.com>
Date: Thu Nov 17 18:08:33 2016

Remove linux_precise_blink_* builders.

BUG= 660580 

Change-Id: Ia6706b8392aa5b61bad442cbc3a5eeff4a0e66e8
Reviewed-on: https://chromium-review.googlesource.com/412261
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>

[modify] https://crrev.com/59a2653d5f143213f4f166714657808b0c646bd7/masters/master.tryserver.blink/master.cfg
[modify] https://crrev.com/59a2653d5f143213f4f166714657808b0c646bd7/masters/master.tryserver.blink/slaves.cfg
[modify] https://crrev.com/59a2653d5f143213f4f166714657808b0c646bd7/scripts/slave/recipe_modules/chromium_tests/trybots.py
[delete] https://crrev.com/c296eda6c0f5b90eb344c93f4c857dcd080c07e5/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_precise_blink_compile_dbg.json
[delete] https://crrev.com/c296eda6c0f5b90eb344c93f4c857dcd080c07e5/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_precise_blink_compile_rel.json
[delete] https://crrev.com/c296eda6c0f5b90eb344c93f4c857dcd080c07e5/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_precise_blink_dbg.json
[delete] https://crrev.com/c296eda6c0f5b90eb344c93f4c857dcd080c07e5/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_precise_blink_rel.json

Comment 23 by qyears...@chromium.org, Nov 18 2016

Blockedon: 666825
Project Member

Comment 24 by bugdroid1@chromium.org, Nov 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/483749453701c53c09acec5d394bf16132d0fd20

commit 483749453701c53c09acec5d394bf16132d0fd20
Author: Quinten Yearsley <qyearsley@google.com>
Date: Fri Nov 18 18:15:57 2016

Update findit/waterfall/flake/trybots.json after Blink try bot name changes.

BUG= 660580 

Change-Id: I166583c537ba893aecaf0e1cfee714c60734c597
Reviewed-on: https://chromium-review.googlesource.com/412391
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/483749453701c53c09acec5d394bf16132d0fd20/appengine/findit/waterfall/flake/trybots.json
Project Member

Comment 25 by bugdroid1@chromium.org, Nov 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8845456348c3f6a5030c18e83f4104e46bb771fe

commit 8845456348c3f6a5030c18e83f4104e46bb771fe
Author: qyearsley <qyearsley@chromium.org>
Date: Mon Nov 21 20:08:40 2016

Remove Precise builders from mb_config.pyl for Blink waterfall and try server.

BUG= 660580 

Review-Url: https://codereview.chromium.org/2517643002
Cr-Commit-Position: refs/heads/master@{#433617}

[modify] https://crrev.com/8845456348c3f6a5030c18e83f4104e46bb771fe/testing/buildbot/chromium.webkit.json
[modify] https://crrev.com/8845456348c3f6a5030c18e83f4104e46bb771fe/tools/mb/mb_config.pyl

Comment 26 by qyears...@chromium.org, Nov 22 2016

Blocking: 666901
Project Member

Comment 27 by bugdroid1@chromium.org, Nov 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/5e85dc012ddf37711b29bc5e7af5c2c5a439e043

commit 5e85dc012ddf37711b29bc5e7af5c2c5a439e043
Author: Quinten Yearsley <qyearsley@google.com>
Date: Tue Nov 22 18:03:29 2016

Update tryserver.chromium.linux slaves.cfg to reflect current version.

BUG= 660580 

Change-Id: I845a85adf0adef91a254113b6f44b6801634a76f
Reviewed-on: https://chromium-review.googlesource.com/413444
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>

[modify] https://crrev.com/5e85dc012ddf37711b29bc5e7af5c2c5a439e043/masters/master.tryserver.chromium.linux/slaves.cfg
Project Member

Comment 28 by bugdroid1@chromium.org, Nov 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ff3fff7fbf713c153eae92a3f0a932f572c062f

commit 8ff3fff7fbf713c153eae92a3f0a932f572c062f
Author: qyearsley <qyearsley@chromium.org>
Date: Tue Nov 22 22:00:50 2016

Remove support for the linux-precise layout tests port.

This CL should remove support for linux-precise port, although it doesn't yet remove all instances of the string "precise", which also occur in various tests. A possible follow-up would be to update these tests to not use the string "precise".

This CL also removes all lines that were marked as Skip for Precise, and updates baselines for those tests.

BUG= 660580 

Review-Url: https://codereview.chromium.org/2514253002
Cr-Commit-Position: refs/heads/master@{#434000}

[modify] https://crrev.com/8ff3fff7fbf713c153eae92a3f0a932f572c062f/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/8ff3fff7fbf713c153eae92a3f0a932f572c062f/third_party/WebKit/LayoutTests/platform/linux/fast/canvas/canvas-composite-video-shadow-expected.png
[modify] https://crrev.com/8ff3fff7fbf713c153eae92a3f0a932f572c062f/third_party/WebKit/LayoutTests/platform/linux/fast/text/complex-text-opacity-expected.png
[modify] https://crrev.com/8ff3fff7fbf713c153eae92a3f0a932f572c062f/third_party/WebKit/LayoutTests/platform/linux/fast/text/font-fallback-expected.png
[modify] https://crrev.com/8ff3fff7fbf713c153eae92a3f0a932f572c062f/third_party/WebKit/LayoutTests/platform/linux/fast/text/international/complex-character-based-fallback-expected.png
[modify] https://crrev.com/8ff3fff7fbf713c153eae92a3f0a932f572c062f/third_party/WebKit/LayoutTests/platform/linux/fast/text/international/complex-character-based-fallback-expected.txt
[modify] https://crrev.com/8ff3fff7fbf713c153eae92a3f0a932f572c062f/third_party/WebKit/LayoutTests/platform/linux/fast/text/international/complex-joining-using-gpos-expected.png
[modify] https://crrev.com/8ff3fff7fbf713c153eae92a3f0a932f572c062f/third_party/WebKit/LayoutTests/platform/linux/inspector-protocol/layout-fonts/languages-emoji-rare-glyphs-expected.txt
[modify] https://crrev.com/8ff3fff7fbf713c153eae92a3f0a932f572c062f/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/paths-data-03-f-expected.png
[modify] https://crrev.com/8ff3fff7fbf713c153eae92a3f0a932f572c062f/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/text-align-08-b-expected.png
[modify] https://crrev.com/8ff3fff7fbf713c153eae92a3f0a932f572c062f/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/text-align-08-b-expected.txt
[add] https://crrev.com/8ff3fff7fbf713c153eae92a3f0a932f572c062f/third_party/WebKit/LayoutTests/platform/linux/svg/custom/control-points-for-S-and-T-expected.png
[modify] https://crrev.com/8ff3fff7fbf713c153eae92a3f0a932f572c062f/third_party/WebKit/LayoutTests/platform/linux/transforms/2d/hindi-rotated-expected.png
[add] https://crrev.com/8ff3fff7fbf713c153eae92a3f0a932f572c062f/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-arc-circumference-fill-expected.png
[modify] https://crrev.com/8ff3fff7fbf713c153eae92a3f0a932f572c062f/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-pattern-no-repeat-with-transformations-expected.png
[modify] https://crrev.com/8ff3fff7fbf713c153eae92a3f0a932f572c062f/third_party/WebKit/Tools/Scripts/webkitpy/common/system/platforminfo.py
[modify] https://crrev.com/8ff3fff7fbf713c153eae92a3f0a932f572c062f/third_party/WebKit/Tools/Scripts/webkitpy/common/system/platforminfo_unittest.py
[modify] https://crrev.com/8ff3fff7fbf713c153eae92a3f0a932f572c062f/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py
[modify] https://crrev.com/8ff3fff7fbf713c153eae92a3f0a932f572c062f/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux.py
[modify] https://crrev.com/8ff3fff7fbf713c153eae92a3f0a932f572c062f/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux_unittest.py

Comment 29 by qyears...@chromium.org, Nov 22 2016

Status: Fixed (was: Started)
Alright, this should be done now!

Although there are a few follow-up items:
 - Remove "precise" string literals from tests
 - Remove lines added to TestExpectations
Project Member

Comment 30 by bugdroid1@chromium.org, Dec 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cfb28f09eed335dec12046d9fb5ebe686d6dfd7c

commit cfb28f09eed335dec12046d9fb5ebe686d6dfd7c
Author: qyearsley <qyearsley@chromium.org>
Date: Thu Dec 01 02:34:11 2016

Remove TestExpectation lines added when removing Precise port.

This is a follow-up to http://crrev.com/2514253002.

BUG= 660580 

Review-Url: https://codereview.chromium.org/2524653003
Cr-Commit-Position: refs/heads/master@{#435531}

[modify] https://crrev.com/cfb28f09eed335dec12046d9fb5ebe686d6dfd7c/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/cfb28f09eed335dec12046d9fb5ebe686d6dfd7c/third_party/WebKit/LayoutTests/platform/linux/fast/canvas/canvas-composite-video-shadow-expected.png
[modify] https://crrev.com/cfb28f09eed335dec12046d9fb5ebe686d6dfd7c/third_party/WebKit/LayoutTests/platform/linux/fast/text/complex-text-opacity-expected.png
[modify] https://crrev.com/cfb28f09eed335dec12046d9fb5ebe686d6dfd7c/third_party/WebKit/LayoutTests/platform/linux/fast/text/font-fallback-expected.png
[modify] https://crrev.com/cfb28f09eed335dec12046d9fb5ebe686d6dfd7c/third_party/WebKit/LayoutTests/platform/linux/fast/text/international/complex-character-based-fallback-expected.png
[modify] https://crrev.com/cfb28f09eed335dec12046d9fb5ebe686d6dfd7c/third_party/WebKit/LayoutTests/platform/linux/fast/text/international/complex-character-based-fallback-expected.txt
[modify] https://crrev.com/cfb28f09eed335dec12046d9fb5ebe686d6dfd7c/third_party/WebKit/LayoutTests/platform/linux/fast/text/international/complex-joining-using-gpos-expected.png
[modify] https://crrev.com/cfb28f09eed335dec12046d9fb5ebe686d6dfd7c/third_party/WebKit/LayoutTests/platform/linux/inspector-protocol/layout-fonts/languages-emoji-rare-glyphs-expected.txt
[modify] https://crrev.com/cfb28f09eed335dec12046d9fb5ebe686d6dfd7c/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/paths-data-03-f-expected.png
[modify] https://crrev.com/cfb28f09eed335dec12046d9fb5ebe686d6dfd7c/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/text-align-08-b-expected.png
[modify] https://crrev.com/cfb28f09eed335dec12046d9fb5ebe686d6dfd7c/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/text-align-08-b-expected.txt
[delete] https://crrev.com/70289fb699a311cf74de0853951145a90c35a5f5/third_party/WebKit/LayoutTests/platform/linux/svg/custom/control-points-for-S-and-T-expected.png
[modify] https://crrev.com/cfb28f09eed335dec12046d9fb5ebe686d6dfd7c/third_party/WebKit/LayoutTests/platform/linux/transforms/2d/hindi-rotated-expected.png
[delete] https://crrev.com/70289fb699a311cf74de0853951145a90c35a5f5/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-arc-circumference-fill-expected.png
[modify] https://crrev.com/cfb28f09eed335dec12046d9fb5ebe686d6dfd7c/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-pattern-no-repeat-with-transformations-expected.png
Project Member

Comment 31 by bugdroid1@chromium.org, Dec 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5d7eb9a2b2c7fcb89ea17a39f92a977b912e3ab

commit c5d7eb9a2b2c7fcb89ea17a39f92a977b912e3ab
Author: qyearsley <qyearsley@chromium.org>
Date: Thu Dec 22 23:17:29 2016

Rebaseline tests that had different results on Linux Precise.

BUG= 660580 

Review-Url: https://codereview.chromium.org/2599093002
Cr-Commit-Position: refs/heads/master@{#440534}

[modify] https://crrev.com/c5d7eb9a2b2c7fcb89ea17a39f92a977b912e3ab/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/c5d7eb9a2b2c7fcb89ea17a39f92a977b912e3ab/third_party/WebKit/LayoutTests/platform/linux/fast/encoding/invalid-UTF-8-expected.png
[modify] https://crrev.com/c5d7eb9a2b2c7fcb89ea17a39f92a977b912e3ab/third_party/WebKit/LayoutTests/platform/linux/fast/encoding/invalid-UTF-8-expected.txt
[modify] https://crrev.com/c5d7eb9a2b2c7fcb89ea17a39f92a977b912e3ab/third_party/WebKit/LayoutTests/platform/linux/fast/forms/month/month-appearance-l10n-expected.png
[modify] https://crrev.com/c5d7eb9a2b2c7fcb89ea17a39f92a977b912e3ab/third_party/WebKit/LayoutTests/platform/linux/fast/text/emoticons-expected.png
[modify] https://crrev.com/c5d7eb9a2b2c7fcb89ea17a39f92a977b912e3ab/third_party/WebKit/LayoutTests/platform/linux/fast/text/emoticons-expected.txt
[modify] https://crrev.com/c5d7eb9a2b2c7fcb89ea17a39f92a977b912e3ab/third_party/WebKit/LayoutTests/platform/linux/fast/text/emphasis-complex-expected.png
[modify] https://crrev.com/c5d7eb9a2b2c7fcb89ea17a39f92a977b912e3ab/third_party/WebKit/LayoutTests/platform/linux/fast/text/international/danda-space-expected.png
[modify] https://crrev.com/c5d7eb9a2b2c7fcb89ea17a39f92a977b912e3ab/third_party/WebKit/LayoutTests/platform/linux/fast/text/international/danda-space-expected.txt
[modify] https://crrev.com/c5d7eb9a2b2c7fcb89ea17a39f92a977b912e3ab/third_party/WebKit/LayoutTests/platform/linux/fast/text/international/hindi-spacing-expected.png
[modify] https://crrev.com/c5d7eb9a2b2c7fcb89ea17a39f92a977b912e3ab/third_party/WebKit/LayoutTests/platform/linux/fast/text/international/hindi-spacing-expected.txt
[modify] https://crrev.com/c5d7eb9a2b2c7fcb89ea17a39f92a977b912e3ab/third_party/WebKit/LayoutTests/platform/linux/fast/text/international/hindi-whitespace-expected.png
[modify] https://crrev.com/c5d7eb9a2b2c7fcb89ea17a39f92a977b912e3ab/third_party/WebKit/LayoutTests/platform/linux/fast/text/selection-multiple-runs-expected.png

Comment 32 by qyears...@chromium.org, Aug 4 2017

Blocking: -666901
►

Sign in to add a comment