New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 660578 link

Starred by 1 user
Status: Fixed
Owner:
█ shrike@chromium.org
Last visit > 30 days ago
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

MacViews - Bookmarks dialog textfield and dropdown labels are not left-aligned as on other platforms

Project Member Reported by shrike@chromium.org, Oct 28 2016 
Version: 56.0.2903.0
OS: 10.11

If you bring up the Bookmarks dialog, the Name and Folder labels are right-aligned instead of left-aligned as they are on Windows and the Harmony spec in general.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/106d55c0f1e8b3a074565392d13b9f528deba61a

commit 106d55c0f1e8b3a074565392d13b9f528deba61a
Author: shrike <shrike@chromium.org>
Date: Sat Oct 29 00:10:25 2016

[MacViews] Left-align control labels as on other platforms.

The Harmony spec calls for left-aligned control labels. Labels are
correctly aligned on Windows but not on the Mac because of special-case
code. This cl removes that special-case code to bring the Mac in line
with all other platforms.

R=sky@chromium.org
BUG= 660578 

Review-Url: https://codereview.chromium.org/2465543002
Cr-Commit-Position: refs/heads/master@{#428552}

[modify] https://crrev.com/106d55c0f1e8b3a074565392d13b9f528deba61a/ui/views/layout/layout_constants.h

Comment 2 by shrike@chromium.org, Oct 29 2016

Status: Fixed (was: Started)
►

Sign in to add a comment