The Reload snackbar will never appear after triggering a link download from offline page |
|||
Issue descriptionThanks ryansturm for finding this bug. What steps will reproduce the problem? 1) Disconnect the network and open an offline page 2) Reconnect the network. The snackbar with Reload button pops up 3) Click a link in the offline page that will trigger a download (a zip file or other type) 4) Disconnect the network after the download is done 5) Reconnect the network What is the expected output? The snackbar with Reload button should be shown. What do you see instead? The snackbar with Reload button won't be shown anymore. Note: this occurs due to that OfflinePageTabObserver.isLoadedTab does not handle the case that onPageLoadFinished is never called after onUrlUpdated.
,
Nov 19 2016
,
Nov 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7c13b94eafad8d7458bde05ca6733eb11d731be commit b7c13b94eafad8d7458bde05ca6733eb11d731be Author: fgorski <fgorski@chromium.org> Date: Mon Nov 21 23:51:35 2016 [Offline pages] Addressing several reload snackbar issues * Solves the problem of snackbar not working after incognito tabs being dismissed * solves the problem of snackbar not working when there is a download happening in between. BUG= 663263 ,662353, 660577 Review-Url: https://codereview.chromium.org/2520583002 Cr-Commit-Position: refs/heads/master@{#433700} [modify] https://crrev.com/b7c13b94eafad8d7458bde05ca6733eb11d731be/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java [modify] https://crrev.com/b7c13b94eafad8d7458bde05ca6733eb11d731be/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java
,
Nov 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d7cde35af699b567f1cd88ffbebd3b12623f133f commit d7cde35af699b567f1cd88ffbebd3b12623f133f Author: Filip Gorski <fgorski@chromium.org> Date: Tue Nov 22 18:09:18 2016 [Offline pages] Addressing several reload snackbar issues * Solves the problem of snackbar not working after incognito tabs being dismissed * solves the problem of snackbar not working when there is a download happening in between. BUG= 663263 ,662353, 660577 Review-Url: https://codereview.chromium.org/2520583002 Cr-Commit-Position: refs/heads/master@{#433700} (cherry picked from commit b7c13b94eafad8d7458bde05ca6733eb11d731be) Review URL: https://codereview.chromium.org/2529433002 . Cr-Commit-Position: refs/branch-heads/2924@{#59} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/d7cde35af699b567f1cd88ffbebd3b12623f133f/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java [modify] https://crrev.com/d7cde35af699b567f1cd88ffbebd3b12623f133f/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java
,
Nov 22 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by fgor...@chromium.org
, Nov 18 2016Owner: fgor...@chromium.org
Status: Assigned (was: Available)