New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 660574 link

Starred by 2 users
Status: Fixed
Owner:
s...@chromium.org
Closed: Oct 2016
Cc:
mastiz@chromium.org
█ tschumann@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Sync] Replaced ASSERT/EXPECT_TRUE/FALSE with expected/action checks.

Project Member Reported by s...@chromium.org, Oct 28 2016 
A pretty good list can be generated by running

grep -r "ASSERT_TRUE\|ASSERT_FALSE\|EXPECT_TRUE\|EXPECT_FALSE" chrome/browser/sync/* components/sync/* components/sync_bookmarks/* components/sync_sessions/* components/browser_sync/* | grep "==\|!=\| < \| > " | grep -v end\(\)  | grep -v find\( | grep -v \|\| | grep -v \\\\
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 31 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1aa7a3f17d23892053ff4dc1c0c088fd95822ed5

commit 1aa7a3f17d23892053ff4dc1c0c088fd95822ed5
Author: skym <skym@chromium.org>
Date: Mon Oct 31 15:43:32 2016

[Sync] Replaced ASSERT/EXPECT_TRUE/FALSE with expected/actual checks.

BUG= 660574 

Review-Url: https://codereview.chromium.org/2455343003
Cr-Commit-Position: refs/heads/master@{#428721}

[modify] https://crrev.com/1aa7a3f17d23892053ff4dc1c0c088fd95822ed5/chrome/browser/sync/test/integration/single_client_bookmarks_sync_test.cc
[modify] https://crrev.com/1aa7a3f17d23892053ff4dc1c0c088fd95822ed5/chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc
[modify] https://crrev.com/1aa7a3f17d23892053ff4dc1c0c088fd95822ed5/chrome/browser/sync/test/integration/sync_auth_test.cc
[modify] https://crrev.com/1aa7a3f17d23892053ff4dc1c0c088fd95822ed5/chrome/browser/sync/test/integration/sync_datatype_helper.cc
[modify] https://crrev.com/1aa7a3f17d23892053ff4dc1c0c088fd95822ed5/chrome/browser/sync/test/integration/sync_test.cc
[modify] https://crrev.com/1aa7a3f17d23892053ff4dc1c0c088fd95822ed5/chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc
[modify] https://crrev.com/1aa7a3f17d23892053ff4dc1c0c088fd95822ed5/components/browser_sync/profile_sync_service_autofill_unittest.cc
[modify] https://crrev.com/1aa7a3f17d23892053ff4dc1c0c088fd95822ed5/components/browser_sync/profile_sync_service_typed_url_unittest.cc
[modify] https://crrev.com/1aa7a3f17d23892053ff4dc1c0c088fd95822ed5/components/sync/driver/data_type_manager_impl_unittest.cc
[modify] https://crrev.com/1aa7a3f17d23892053ff4dc1c0c088fd95822ed5/components/sync/driver/sync_stopped_reporter_unittest.cc
[modify] https://crrev.com/1aa7a3f17d23892053ff4dc1c0c088fd95822ed5/components/sync/engine_impl/syncer_unittest.cc
[modify] https://crrev.com/1aa7a3f17d23892053ff4dc1c0c088fd95822ed5/components/sync/syncable/directory_unittest.cc

Comment 2 by s...@chromium.org, Oct 31 2016

Status: Fixed (was: Started)
►

Sign in to add a comment