New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 660573 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 755801
issue 403462



Sign in to add a comment

Add an interface to provide render frame based services to media services

Project Member Reported by xhw...@chromium.org, Oct 28 2016

Issue description

Today we use a service_manager::mojom::InterfaceProviderPtr to provide render frame based services. This seems unnecessary and make it harder to enforce capability exchange between processes. Instead, we can just define a MediaServiceHost (or something similar) interface to provide these services.

 

Comment 1 by xhw...@chromium.org, Oct 28 2016

Cc: alokp@chromium.org

Comment 2 by alokp@chromium.org, Oct 31 2016

Cc: s...@chromium.org

Comment 3 by xhw...@chromium.org, Nov 10 2016

ben: I am looking at this closely :) I have a question though. How about the services we provide in the content embedders [1]? With InterfaceRegistry and InterfaceProvider this is very easy to do.

Do you have any idea on what's the best way to do this when we switch to a MediaServiceHost interface? I guess we can implement the MediaServiceHost using an internal InterfaceRegistry. But I am not sure whether that's what you are looking for.

[1] https://cs.chromium.org/chromium/src/content/browser/frame_host/render_frame_host_impl.cc?rcl=0&l=828
Blocking: 403462
We should be able to use a media::mojom::AuxService or media::mojom::HostService to replace the service_manager.mojom.InterfaceProvider? host_interfaces we have today [1].

https://cs.chromium.org/chromium/src/media/mojo/interfaces/media_service.mojom?rcl=e5e81dd5d79c96f679275de1244aa645b5af44bc&l=16

Also, we should use StrongBindingSet to host these services such that the aux/host services will be removed when it's not needed anymore (connection error).

Comment 5 by xhw...@chromium.org, Aug 30 2017

Blocking: 755801

Sign in to add a comment