New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 660554 link

Starred by 2 users
Status: Fixed
Owner:
robliao@chromium.org
Closed: Nov 2016
Cc:
gab@chromium.org
fdoray@chromium.org
asvitk...@chromium.org
pkl@chromium.org
rohitrao@chromium.org
ios-bugs-priority@chromium.org
skare@chromium.org
isherman@chromium.org
ios-bugs@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Feature

Blocking:
issue 553459



Sign in to add a comment

fieldtrial_testing_config.json Support for iOS

Project Member Reported by robliao@chromium.org, Oct 28 2016 
Currently, Chromium iOS does not read variations data from fieldtrial_testing_config.json. It should use this file as the basis for default experiments since...

1. The config file thinks it's currently being used (ios platform param).
2. This brings Chromium iOS more inline with Desktop and Android Chromium.

Comment 1 by robliao@chromium.org, Oct 28 2016

Blocking: 553459
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48f456a2e965153e5fc85dca7bff30ae972d5be5

commit 48f456a2e965153e5fc85dca7bff30ae972d5be5
Author: robliao <robliao@chromium.org>
Date: Fri Nov 04 17:35:03 2016

Move Field Trial Utils from chrome/common/variations to components/variations/field_trial_config

This allows iOS to use fieldtrial_testing_config.json for their
waterfall.

BUG= 660554 

TBR=rch as this is moving an existing use of net/base.

Review-Url: https://codereview.chromium.org/2465953002
Cr-Commit-Position: refs/heads/master@{#429935}

[modify] https://crrev.com/48f456a2e965153e5fc85dca7bff30ae972d5be5/chrome/browser/BUILD.gn
[modify] https://crrev.com/48f456a2e965153e5fc85dca7bff30ae972d5be5/chrome/browser/chrome_browser_field_trials_desktop.cc
[modify] https://crrev.com/48f456a2e965153e5fc85dca7bff30ae972d5be5/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/48f456a2e965153e5fc85dca7bff30ae972d5be5/chrome/browser/plugins/flash_permission_browsertest.cc
[modify] https://crrev.com/48f456a2e965153e5fc85dca7bff30ae972d5be5/chrome/browser/tracing/background_tracing_field_trial.cc
[modify] https://crrev.com/48f456a2e965153e5fc85dca7bff30ae972d5be5/chrome/browser/tracing/chrome_tracing_delegate_browsertest.cc
[modify] https://crrev.com/48f456a2e965153e5fc85dca7bff30ae972d5be5/chrome/common/BUILD.gn
[modify] https://crrev.com/48f456a2e965153e5fc85dca7bff30ae972d5be5/chrome/common/chrome_switches.cc
[modify] https://crrev.com/48f456a2e965153e5fc85dca7bff30ae972d5be5/chrome/common/chrome_switches.h
[delete] https://crrev.com/8815c41f286b76846313c9b1955507c7f5709fbf/chrome/common/variations/BUILD.gn
[modify] https://crrev.com/48f456a2e965153e5fc85dca7bff30ae972d5be5/chrome/test/BUILD.gn
[modify] https://crrev.com/48f456a2e965153e5fc85dca7bff30ae972d5be5/components/variations/BUILD.gn
[add] https://crrev.com/48f456a2e965153e5fc85dca7bff30ae972d5be5/components/variations/field_trial_config/BUILD.gn
[add] https://crrev.com/48f456a2e965153e5fc85dca7bff30ae972d5be5/components/variations/field_trial_config/DEPS
[rename] https://crrev.com/48f456a2e965153e5fc85dca7bff30ae972d5be5/components/variations/field_trial_config/field_trial_testing_config_schema.json
[rename] https://crrev.com/48f456a2e965153e5fc85dca7bff30ae972d5be5/components/variations/field_trial_config/field_trial_util.cc
[rename] https://crrev.com/48f456a2e965153e5fc85dca7bff30ae972d5be5/components/variations/field_trial_config/field_trial_util.h
[rename] https://crrev.com/48f456a2e965153e5fc85dca7bff30ae972d5be5/components/variations/field_trial_config/field_trial_util_unittest.cc
[modify] https://crrev.com/48f456a2e965153e5fc85dca7bff30ae972d5be5/components/variations/variations_switches.cc
[modify] https://crrev.com/48f456a2e965153e5fc85dca7bff30ae972d5be5/components/variations/variations_switches.h
[modify] https://crrev.com/48f456a2e965153e5fc85dca7bff30ae972d5be5/tools/variations/fieldtrial_to_struct_unittest.py
[modify] https://crrev.com/48f456a2e965153e5fc85dca7bff30ae972d5be5/tools/variations/unittest_data/expected_output.cc
[modify] https://crrev.com/48f456a2e965153e5fc85dca7bff30ae972d5be5/tools/variations/unittest_data/expected_output.h
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4cdcaa90e9d83af4bd86cda475a16d3455766c48

commit 4cdcaa90e9d83af4bd86cda475a16d3455766c48
Author: robliao <robliao@chromium.org>
Date: Mon Nov 07 19:35:43 2016

Add Field Trial Testing Support to iOS

This brings desktop and Android default field trial testing support to
iOS. Official builds, similar to desktop and Android, remain
unaffected.

As of this writing, the following variations are set by default with
this change on iOS due to the field trial configuration:

AutofillProfileCleanup:Enabled
BrowserScheduler:Enabled
PageRevisitInstrumentation:Enabled
PasswordManagerSettingsMigration:Enable
QUIC:Enabled
TLS13Negotiation:Enabled
TranslateRanker:EnforcementEnabled

BUG= 660554 

Review-Url: https://codereview.chromium.org/2472753002
Cr-Commit-Position: refs/heads/master@{#430347}

[modify] https://crrev.com/4cdcaa90e9d83af4bd86cda475a16d3455766c48/ios/chrome/browser/BUILD.gn
[modify] https://crrev.com/4cdcaa90e9d83af4bd86cda475a16d3455766c48/ios/chrome/browser/ios_chrome_main_parts.mm

Comment 4 by robliao@chromium.org, Nov 8 2016

Status: Fixed (was: Started)
This appears to be working now.
►

Sign in to add a comment