Bookmarks menu icons should be light versions in dark mode |
||
Issue descriptionIf you switch to dark mode (via System Preferences), bookmark menu folder and default URL icons are almost invisible because they are stroked with a dark color. This menu should show light versions of these icons (i.e. the ones you see when in Incognito mode) when the system is in dark mode. It looks like this has a clue about detecting dark mode: http://stackoverflow.com/questions/25207077/how-to-detect-if-os-x-is-in-dark-mode Maybe we check just before the menu is opened (the user can change the setting at any time).
,
Apr 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/71125ff12bb0d87b36c81a2783223489bd062a42 commit 71125ff12bb0d87b36c81a2783223489bd062a42 Author: lgrey <lgrey@chromium.org> Date: Tue Apr 11 17:25:42 2017 [Mac] Use templated images for bookmark menu This gives us light icons in macOS "Use dark menu bar and Dock" mode without manual intervention. BUG= 660551 Review-Url: https://codereview.chromium.org/2814703003 Cr-Commit-Position: refs/heads/master@{#463666} [modify] https://crrev.com/71125ff12bb0d87b36c81a2783223489bd062a42/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.mm
,
Apr 28 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by lgrey@chromium.org
, Apr 11 2017