New issue
Advanced search Search tips

Issue 660541 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2016
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug-Regression



Sign in to add a comment

remoting_perftests does not build

Reported by arm.ama...@gmail.com, Oct 28 2016

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.59 Safari/537.36

Steps to reproduce the problem:

cros_sdk -- ninja -C /var/cache/chromeos-chrome/chrome-src/src/out_veyron_jerry/Release/ remoting_perftests

What is the expected behavior?
/var/cache/chromeos-chrome/chrome-src/src/out_veyron_jerry/Release/remoting_perftests

Should be generated without any reported error

What went wrong?
(cr) (master) amalel01@chromeosbld ~/chrome_root/src $ ninja -C /var/cache/chromeos-chrome/chrome-src/src/out_veyron_jerry/Release/ remoting_perftests -j8
ninja: Entering directory `/var/cache/chromeos-chrome/chrome-src/src/out_veyron_jerry/Release/'
[1/4] CXX obj/remoting/host/test_support/fake_desktop_environment.o
FAILED: armv7a-cros-linux-gnueabi-g++ -B/usr/x86_64-pc-linux-gnu/armv7a-cros-linux-gnueabi/binutils-bin/2.25.51-gold -MMD -MF obj/remoting/host/test_support/fake_desktop_environment.o.d -DV8_DEPRECATION_WARNINGS -DENABLE_MDNS=1 -DENABLE_NOTIFICATIONS -DENABLE_PLUGINS=1 -DENABLE_PDF=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_ASH=1 -DUSE_AURA=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_NSS_CERTS=1 -DUSE_OZONE=1 -DENABLE_WEBRTC=1 -DENABLE_EXTENSIONS=1 -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_SUPERVISED_USERS=1 -DIMAGE_LOADER_EXTENSION=1 -DENABLE_WAYLAND_SERVER=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DOS_CHROMEOS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DVERSION=56.0.2900.0 -DUSE_EGL -DTOOLKIT_VIEWS=1 -DGTEST_HAS_POSIX_RE=0 -DGTEST_LANG_CXX11=1 -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DFEATURE_ENABLE_SSL -DFEATURE_ENABLE_VOICEMAIL -DEXPAT_RELATIVE_PATH -DGTEST_RELATIVE_PATH -DNO_MAIN_THREAD_WRAPPING -DNO_SOUND_SYSTEM -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_LINUX -DCHROMEOS -DFEATURE_ENABLE_SSL -DFEATURE_ENABLE_VOICEMAIL -DUNIT_TEST -I../../../../../../../home/amalel01/chrome_root/src -Igen -I../../../../../../../home/amalel01/chrome_root/src/third_party/khronos -I../../../../../../../home/amalel01/chrome_root/src/gpu -I../../../../../../../home/amalel01/chrome_root/src/testing/gtest/include -I../../../../../../../home/amalel01/chrome_root/src/third_party/protobuf/src -I../../../../../../../home/amalel01/chrome_root/src/third_party/webrtc_overrides -I../../../../../../../home/amalel01/chrome_root/src/testing/gtest/include -I../../../../../../../home/amalel01/chrome_root/src/third_party -I../../../../../../../home/amalel01/chrome_root/src/third_party/webrtc_overrides -I../../../../../../../home/amalel01/chrome_root/src/third_party -I../../../../../../../home/amalel01/chrome_root/src/third_party/protobuf/src -Igen/protoc_out -I../../../../../../../home/amalel01/chrome_root/src/testing/gmock_custom -I../../../../../../../home/amalel01/chrome_root/src/testing/gmock/include -fno-strict-aliasing -funwind-tables -fPIC -pipe -pthread -march=armv7-a -mfloat-abi=hard -mthumb -mtune=generic-armv7-a -mfpu=neon -Wall -Werror -Wno-psabi -Wno-unused-local-typedefs -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-unused-parameter -O2 -fno-ident -fdata-sections -ffunction-sections -g2 -gsplit-dwarf --sysroot=../../../../../../../build/veyron_jerry -fvisibility=hidden -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -Wno-narrowing -Wno-literal-suffix -fno-rtti -fno-exceptions -pipe -march=armv7-a -mtune=cortex-a15 -mfpu=neon -mfloat-abi=hard -D__google_stl_debug_vector=1 -femit-struct-debug-reduced -c ../../../../../../../home/amalel01/chrome_root/src/remoting/host/fake_desktop_environment.cc -o obj/remoting/host/test_support/fake_desktop_environment.o
../../../../../../../home/amalel01/chrome_root/src/remoting/host/fake_desktop_environment.cc: In member function ‘virtual std::unique_ptr<webrtc::DesktopCapturer> remoting::FakeDesktopEnvironment::CreateVideoCapturer()’:
../../../../../../../home/amalel01/chrome_root/src/remoting/host/fake_desktop_environment.cc:87:10: error: cannot bind ‘std::unique_ptr<remoting::DesktopCapturerProxy>’ lvalue to ‘std::unique_ptr<remoting::DesktopCapturerProxy>&&’
   return result;
          ^
In file included from /usr/lib/gcc/armv7a-cros-linux-gnueabi/4.9.x/include/g++-v4/memory:81:0,
                 from ../../../../../../../home/amalel01/chrome_root/src/remoting/host/fake_desktop_environment.h:9,
                 from ../../../../../../../home/amalel01/chrome_root/src/remoting/host/fake_desktop_environment.cc:5:
/usr/lib/gcc/armv7a-cros-linux-gnueabi/4.9.x/include/g++-v4/bits/unique_ptr.h:220:2: note: initializing argument 1 of ‘std::unique_ptr<_Tp, _Dp>::unique_ptr(std::unique_ptr<_Up, _Ep>&&) [with _Up = remoting::DesktopCapturerProxy; _Ep = std::default_delete<remoting::DesktopCapturerProxy>; <template-parameter-2-3> = void; _Tp = webrtc::DesktopCapturer; _Dp = std::default_delete<webrtc::DesktopCapturer>]’
  unique_ptr(unique_ptr<_Up, _Ep>&& __u) noexcept
  ^
../../../../../../../home/amalel01/chrome_root/src/remoting/host/fake_desktop_environment.cc:88:1: error: control reaches end of non-void function [-Werror=return-type]
 }
 ^
cc1plus: all warnings being treated as errors
ninja: build stopped: subcommand failed.

Did this work before? Yes 3c62d53c8ebadcefe0e4597757e780c24ad77141 seems to be the culprit

Chrome version: 54.0.2840.59  Channel: n/a
OS Version: 
Flash Version: Shockwave Flash 23.0 r0

Only affects a build for ChromeOS. Does not happen on Chrome for Linux (as Chrome for Linux now uses clang whereas g++ seems to be more strict on the returning of an rvalue.

Easily fixable in a coming patch
 
Labels: Arch-ARM
Owner: cavalcantii@chromium.org
Status: Started (was: Unconfirmed)
Labels: -Pri-2 Pri-3
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29bfbecb49572b61264de7acccf8b23942bba43d

commit 29bfbecb49572b61264de7acccf8b23942bba43d
Author: amaury.leleyzour <amaury.leleyzour@arm.com>
Date: Sat Nov 19 00:30:18 2016

Fix remoting_perftests build for ARM

While compiling chromium for chromeos, remoting_perftests fails to
build due to an attempt to return an rvalue

BUG= 660541 

Review-Url: https://codereview.chromium.org/2515813002
Cr-Commit-Position: refs/heads/master@{#433350}

[modify] https://crrev.com/29bfbecb49572b61264de7acccf8b23942bba43d/remoting/host/fake_desktop_environment.cc

Status: Verified (was: Started)

Sign in to add a comment