New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 660537 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Revisit WebMediaPlayerDelegate naming inconsistencies

Project Member Reported by w...@chromium.org, Oct 28 2016

Issue description

Issues:
* This class is not a delegate (see https://en.wikipedia.org/wiki/Delegation_pattern)
* WMPI has a delegate_id which sounds like it's the id of the delegate, but it's WMPI's id. 
* RWMPD has a CleanupIdleDelegates. So the delegate considers the players to be delegates.
* The delegate methods take delegate_ids but the docs say things like "specified player". We should probably s/delegate_id/player_id/.
* The docs on the WMPD::Observer interface talk about WebMediaPlayers instead of Observers. Should probably s/Observer/Player.
* RendererWebMediaPlayerDelegateTest has a RWMPD member called delegate_manager_ but the type doesn't have 'manager' in the name.

I'm thinking we just call this MediaPlayerManager. + people who might care.
 

Comment 1 by w...@chromium.org, Jul 6 2017

Status: WontFix (was: Assigned)

Sign in to add a comment