New shelf tooltips have a darker rectangle behind text. |
||||||||||||||
Issue descriptionNew shelf tooltips have a darker rectangle behind text. On a recent linux desktop cros build @ 56.0.2900.0 (#427116): 1) Put something white over the shelf: (eg. fullscreen about:blank) 2) Hover over a shelf item. Expected: shelf item tooltip has a solid color background? Actual: There's a darker rectangle directly under the text (see attached).
,
Oct 28 2016
,
Oct 28 2016
,
Oct 29 2016
Issue 660583 has been merged into this issue.
,
Oct 29 2016
best I can tell, this has been happening since at least July, so I'm surprised it was reported twice in the same day.
,
Oct 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17ab8262e8e13c1ace5b8270dbf71a3c7af6a7aa commit 17ab8262e8e13c1ace5b8270dbf71a3c7af6a7aa Author: estade <estade@chromium.org> Date: Mon Oct 31 15:40:04 2016 CrOS - Fix text background of shelf tooltips. BUG= 660510 Review-Url: https://codereview.chromium.org/2460103002 Cr-Commit-Position: refs/heads/master@{#428719} [modify] https://crrev.com/17ab8262e8e13c1ace5b8270dbf71a3c7af6a7aa/ash/common/shelf/shelf_tooltip_manager.cc [modify] https://crrev.com/17ab8262e8e13c1ace5b8270dbf71a3c7af6a7aa/ui/views/bubble/bubble_dialog_delegate.cc
,
Oct 31 2016
,
Nov 11 2016
Verified on ChromeOS 8980.0.0, 56.0.2915.0
,
Dec 1 2016
Issue exists on M55 (8872.65.0, 55.0.2883.76) Will this change not be merged to M55?
,
Dec 1 2016
Note: The dark tooltip theme was not behind a flag so this affects general M-55 population.
,
Dec 5 2016
It seems a little late to merge a relatively minor visual fix to m55.
,
Dec 5 2016
+sgabriel are tooltips high-visibility enough that we would want to merge into M55? It definitely doesn't look great.
,
Dec 5 2016
The change doesn't look that risky so I would vote for trying to merge it.
,
Dec 5 2016
I would try to merge it yes.
,
Dec 5 2016
,
Dec 5 2016
actually, I think we'd also need to merge https://crrev.com/03f052fcaf93364ce2136172b91137793e4f3458 for bug 663192
,
Dec 5 2016
[Automated comment] Less than 2 weeks to go before stable on M55, manual review required.
,
Dec 13 2016
,
Dec 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/68c6bc8ddf9d89cbd3dd8cec6d76cce047413ac3 commit 68c6bc8ddf9d89cbd3dd8cec6d76cce047413ac3 Author: Evan Stade <estade@chromium.org> Date: Tue Dec 13 16:13:10 2016 CrOS - Fix text background of shelf tooltips. BUG= 660510 Review-Url: https://codereview.chromium.org/2460103002 Cr-Commit-Position: refs/heads/master@{#428719} (cherry picked from commit 17ab8262e8e13c1ace5b8270dbf71a3c7af6a7aa) Review-Url: https://codereview.chromium.org/2573813002 . Cr-Commit-Position: refs/branch-heads/2883@{#740} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/68c6bc8ddf9d89cbd3dd8cec6d76cce047413ac3/ash/common/shelf/shelf_tooltip_manager.cc [modify] https://crrev.com/68c6bc8ddf9d89cbd3dd8cec6d76cce047413ac3/ui/views/bubble/bubble_dialog_delegate.cc
,
Dec 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17bc960ab9d9cfbf841a39c37d510b4c464174cc commit 17bc960ab9d9cfbf841a39c37d510b4c464174cc Author: estade <estade@chromium.org> Date: Tue Dec 13 16:51:12 2016 Fix IME tray bubble (and other tray bubble views). This was broken by 17ab8262e8e13c1ace5 which stopped explicitly painting a background for bubble contents views. The symptom I observed is a black background (due to the layer being opaque and painting nothing). This should also fix the subpixel text corruption shown in the bug. BUG= 660510 TBR=msw@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2485793002 Cr-Commit-Position: refs/heads/master@{#430500} (cherry picked from commit 03f052fcaf93364ce2136172b91137793e4f3458) Review-Url: https://codereview.chromium.org/2573823002 Cr-Commit-Position: refs/branch-heads/2883@{#741} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/17bc960ab9d9cfbf841a39c37d510b4c464174cc/ui/views/bubble/bubble_dialog_delegate.cc
,
Dec 21 2016
Does the latest change also need to be merged?
,
Dec 22 2016
which latest change? Comments 19 and 20 are both merges.
,
Dec 29 2016
,
Jan 10 2017
Verified on ChromeOS 8872.76.0, 55.0.2883.105 |
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by est...@chromium.org
, Oct 28 2016Status: Assigned (was: Untriaged)