New issue
Advanced search Search tips

Issue 660503 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

webkit_tests failing, AttributeError in layout_test_wrapper.py

Project Member Reported by qyears...@chromium.org, Oct 28 2016

Issue description

Example logs:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/builds/12164/steps/webkit_tests/logs/stdio

Traceback (most recent call last):
  File "/b/rr/tmptg6U9L/rw/checkout/infra/.recipe_deps/build/scripts/slave/chromium/layout_test_wrapper.py", line 277, in <module>
    sys.exit(main())
  File "/b/rr/tmptg6U9L/rw/checkout/infra/.recipe_deps/build/scripts/slave/chromium/layout_test_wrapper.py", line 274, in main
    return layout_test(options, args)
  File "/b/rr/tmptg6U9L/rw/checkout/infra/.recipe_deps/build/scripts/slave/chromium/layout_test_wrapper.py", line 99, in layout_test
    if options.order:
AttributeError: Values instance has no attribute 'order'
 
Cc: jeffcarp@chromium.org
Cause: https://codereview.chromium.org/2384243005

Could probably be fixed by a small fix patch fairly quickly rather than reverted and relanded.
Just reverted https://crrev.com/2384243005/ 
What's the status here? Still seeing the failing tests and your revert looks like it was reverted?
Cc: -jeffcarp@chromium.org qyears...@chromium.org
Owner: jeffcarp@chromium.org
The change was relanded with a fix, so we're expecting that webkit_tests should turn green again, I believe; some builders may not have turned green yet just because of long cycle time.
The revert has been committed but the reland[1] has not been committed yet.

[1] https://codereview.chromium.org/2459983002
Status: Started (was: Assigned)
So, we're still expecting the builders to roll green soon, but as of 3:40 pm PST, some dbg/MSAN/ASAN builders are still red.
Status: Fixed (was: Started)
All the builders are back to green, closing.

Sign in to add a comment