New issue
Advanced search Search tips

Issue 660492 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

storage/indexeddb/structured-clone.html time out

Project Member Reported by xidac...@chromium.org, Oct 28 2016

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Oct 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dced0c2accbea02854b4e1311d3cc472582533e8

commit dced0c2accbea02854b4e1311d3cc472582533e8
Author: xidachen <xidachen@chromium.org>
Date: Fri Oct 28 20:22:50 2016

Mark storage/indexeddb/structured-clone.html as timeout

BUG=660492
TBR=jsbell@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2465483002
Cr-Commit-Position: refs/heads/master@{#428475}

[modify] https://crrev.com/dced0c2accbea02854b4e1311d3cc472582533e8/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/763c0f72578867e14acc7e8bb1e8f47e78fc9ad7

commit 763c0f72578867e14acc7e8bb1e8f47e78fc9ad7
Author: jsbell <jsbell@chromium.org>
Date: Thu Nov 03 23:52:20 2016

Mark structured-clone test as Slow, not Timeout

Per discussion in https://codereview.chromium.org/2465483002 a more
appropriate expectation for this test is [Slow], not [Timeout].

BUG=660492
TBR=xidachen@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2474273002
Cr-Commit-Position: refs/heads/master@{#429730}

[modify] https://crrev.com/763c0f72578867e14acc7e8bb1e8f47e78fc9ad7/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/763c0f72578867e14acc7e8bb1e8f47e78fc9ad7/third_party/WebKit/LayoutTests/TestExpectations

Cc: jsb...@chromium.org
Components: Blink>Storage>IndexedDB
Labels: Hotlist-GoodFirstBug
Owner: ----
Status: Available (was: Assigned)
Slow because it uses one transaction per value and there are lots of values:

https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/storage/indexeddb/structured-clone.html?q=structured-clone.html&sq=package:chromium&l=80

This was done because some of the verification is async (e.g. using FileReader on Blobs); it could be restructured to prepare all the values, insert them all, read them all, then verify them. Probably less readable that way, though.

Another option is to just split it up, e.g. one file for simple types (primitives, Objects) and one for everything else.
Marking as slow on Linux and Mac as well.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e454e78901ce0173e47a67258675a1f2888ef76

commit 9e454e78901ce0173e47a67258675a1f2888ef76
Author: Dirk Pranke <dpranke@chromium.org>
Date: Tue Jun 06 22:11:18 2017

Update some slow layout test expectations.

Both storage/indexeddb/structured-clone.html and
are being flaky on multiple platforms, but were previously
only marked as such on one platform.

TBR=fdoray@chromium.org
BUG=660492, 680383
NOTRY=true

Change-Id: Ib0158041427e50b4ca7c6883cf504b9eff082a18
Reviewed-on: https://chromium-review.googlesource.com/526281
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477430}
[modify] https://crrev.com/9e454e78901ce0173e47a67258675a1f2888ef76/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/9e454e78901ce0173e47a67258675a1f2888ef76/third_party/WebKit/LayoutTests/TestExpectations

Comment 6 by dmu...@chromium.org, May 15 2018

Labels: Test-Flaky Test-Disabled

Sign in to add a comment