New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 660491 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Delete chrome/test/earl_grey/chrome_util.mm

Project Member Reported by baxley@chromium.org, Oct 28 2016

Issue description

chrome_util.mm/h was created as a workaround to not modify shared utilities while converting tests. Now that it is done, this should be moved into proper files.
 

Comment 1 by baxley@chromium.org, Mar 14 2017

Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1a5ce8907afdad37a43b5fafc266be318aa491a

commit a1a5ce8907afdad37a43b5fafc266be318aa491a
Author: baxley <baxley@chromium.org>
Date: Wed Mar 15 01:00:26 2017

Move EarlGrey helper to check toolbar visibility into ChromeEarlGreyUI.

Delete chrome_util.h/mm, since it was a temporary location for
utility methods. Change the method from one that waits and asserts
to one that waits and returns YES on success, and NO on failure.

BUG= 660491 

Review-Url: https://codereview.chromium.org/2751523004
Cr-Commit-Position: refs/heads/master@{#456929}

[modify] https://crrev.com/a1a5ce8907afdad37a43b5fafc266be318aa491a/ios/chrome/browser/context_menu/context_menu_egtest.mm
[modify] https://crrev.com/a1a5ce8907afdad37a43b5fafc266be318aa491a/ios/chrome/browser/ui/fullscreen_egtest.mm
[modify] https://crrev.com/a1a5ce8907afdad37a43b5fafc266be318aa491a/ios/chrome/browser/web/progress_indicator_egtest.mm
[modify] https://crrev.com/a1a5ce8907afdad37a43b5fafc266be318aa491a/ios/chrome/test/earl_grey/BUILD.gn
[modify] https://crrev.com/a1a5ce8907afdad37a43b5fafc266be318aa491a/ios/chrome/test/earl_grey/chrome_earl_grey_ui.h
[modify] https://crrev.com/a1a5ce8907afdad37a43b5fafc266be318aa491a/ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm
[delete] https://crrev.com/981ff3850e661dae2425f4183aeb1dc8c1104d19/ios/chrome/test/earl_grey/chrome_util.h
[delete] https://crrev.com/981ff3850e661dae2425f4183aeb1dc8c1104d19/ios/chrome/test/earl_grey/chrome_util.mm

Status: Fixed (was: Started)
chrome_util.mm does not exist anymore

Sign in to add a comment