New issue
Advanced search Search tips

Issue 660478 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

install_chrome_apk_incremental unreliable

Project Member Reported by dmazz...@chromium.org, Oct 28 2016

Issue description

I'm building Clank like this:

$ gn args gn_out/release:

target_os = "android"
disable_incremental_isolated_processes=true
is_component_build = true
is_debug = false
use_goma = true
goma_dir = "/ssd1tb/goma"

Confirming that dcheck_always_on is false:

$ gn args gn_out/release --list --short | grep dcheck
dcheck_always_on = false

Building and installing like this:

ninja -C gn_out/release -j 500 chrome_apk_incremental
gn_out/release/bin/install_chrome_apk_incremental

But when I run Chrome I'm getting frequent crashes like this one:

[FATAL:WebFrameContentDumper.cpp(34)] Check failed: !document->needsLayoutTreeUpdate().

...which is a DCHECK:

DCHECK(!document->needsLayoutTreeUpdate());

Any ideas?

 
Cc: tedc...@chromium.org
Components: -Blink -Infra Infra>Client>Android
Summary: install_chrome_apk_incremental unreliable (was: Hitting DCHECK assertions in release build when dcheck_always_on = false)
OK, I uninstalled Clankium and ran gn_out/release/bin/install_chrome_apk_incremental again and now it's fine.

Looks like a bug in the incremental updater. I updated the bug title.

Cc: jbudorick@chromium.org agrieve@chromium.org
Components: -Infra>Client>Android

Comment 3 by cmasso@google.com, Feb 14 2018

Cc: -agrieve@chromium.org
Components: Tools>ClankTools
Owner: agrieve@chromium.org
Status: Assigned (was: Untriaged)
Status: Archived (was: Assigned)
I think incremental install has been working fine recently. archiving.

Sign in to add a comment