New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 660477 link

Starred by 1 user
Status: WontFix
Owner:
█ chenwilliam@chromium.org
Last visit > 30 days ago
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

DevTools: Move inspector layout tests to within /Source/devtools

Project Member Reported by chenwilliam@chromium.org, Oct 28 2016 
Moving inspector (devtools) layout tests to within /Source/devtools provides a couple of benefits:

1. Although inspector tests use the same layout test harness as the rest of Blink, the intent of these tests are very different and aren't actually trying to test the layout. In particular, inspector tests run quite slowly (~80 seconds for 1100 tests) relative to other layout tests.

2. This enables external contributors to run and update tests by only checking out our subtree mirror: https://chromium.googlesource.com/chromium/src/third_party/WebKit/Source/devtools/
This reduces the barrier for contribution for external contributors that are working on front-end only (e.g. javascript) changes and don't need the entire Chromium repo.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98e38c15f03f244abf103caa9abd6da265cda794

commit 98e38c15f03f244abf103caa9abd6da265cda794
Author: chenwilliam <chenwilliam@chromium.org>
Date: Fri Nov 04 19:25:01 2016

Make layout test harness extensible with custom layout tests directory

- Moves apache config for layout tests to within Tools/Scripts
- This will make it easier to re-use for devtools tests.

BUG= 660477 

Review-Url: https://codereview.chromium.org/2454323004
Cr-Commit-Position: refs/heads/master@{#429973}

[rename] https://crrev.com/98e38c15f03f244abf103caa9abd6da265cda794/third_party/WebKit/Tools/Scripts/apache_config/apache2-httpd-2.2.conf
[rename] https://crrev.com/98e38c15f03f244abf103caa9abd6da265cda794/third_party/WebKit/Tools/Scripts/apache_config/apache2-httpd-2.4.conf
[rename] https://crrev.com/98e38c15f03f244abf103caa9abd6da265cda794/third_party/WebKit/Tools/Scripts/apache_config/arch-httpd-2.4.conf
[rename] https://crrev.com/98e38c15f03f244abf103caa9abd6da265cda794/third_party/WebKit/Tools/Scripts/apache_config/cygwin-httpd.conf
[rename] https://crrev.com/98e38c15f03f244abf103caa9abd6da265cda794/third_party/WebKit/Tools/Scripts/apache_config/debian-httpd-2.2.conf
[rename] https://crrev.com/98e38c15f03f244abf103caa9abd6da265cda794/third_party/WebKit/Tools/Scripts/apache_config/debian-httpd-2.4.conf
[rename] https://crrev.com/98e38c15f03f244abf103caa9abd6da265cda794/third_party/WebKit/Tools/Scripts/apache_config/mime.types
[rename] https://crrev.com/98e38c15f03f244abf103caa9abd6da265cda794/third_party/WebKit/Tools/Scripts/apache_config/redhat-httpd-2.2.conf
[rename] https://crrev.com/98e38c15f03f244abf103caa9abd6da265cda794/third_party/WebKit/Tools/Scripts/apache_config/redhat-httpd-2.4.conf
[rename] https://crrev.com/98e38c15f03f244abf103caa9abd6da265cda794/third_party/WebKit/Tools/Scripts/apache_config/webkit-httpd.pem
[rename] https://crrev.com/98e38c15f03f244abf103caa9abd6da265cda794/third_party/WebKit/Tools/Scripts/apache_config/win-httpd.conf
[add] https://crrev.com/98e38c15f03f244abf103caa9abd6da265cda794/third_party/WebKit/Tools/Scripts/run-inspector-tests
[modify] https://crrev.com/98e38c15f03f244abf103caa9abd6da265cda794/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
[modify] https://crrev.com/98e38c15f03f244abf103caa9abd6da265cda794/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mac.py
[modify] https://crrev.com/98e38c15f03f244abf103caa9abd6da265cda794/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mac_unittest.py
[modify] https://crrev.com/98e38c15f03f244abf103caa9abd6da265cda794/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py
[modify] https://crrev.com/98e38c15f03f244abf103caa9abd6da265cda794/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py
[modify] https://crrev.com/98e38c15f03f244abf103caa9abd6da265cda794/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win.py
[modify] https://crrev.com/98e38c15f03f244abf103caa9abd6da265cda794/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win_unittest.py
[modify] https://crrev.com/98e38c15f03f244abf103caa9abd6da265cda794/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
[modify] https://crrev.com/98e38c15f03f244abf103caa9abd6da265cda794/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/apache_http.py
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f10d44710039f6b1b2437cfc2819295659ff7d0

commit 1f10d44710039f6b1b2437cfc2819295659ff7d0
Author: chenwilliam <chenwilliam@chromium.org>
Date: Fri Mar 24 01:36:40 2017

DevTools: copy console tests to /Source/devtools/tests/

While I'm ironing out the process for running tests locally & trybots from
the new test directory, I'd like to copy these tests. I'll delete them from
the original location later once this is stable.

This does mean that if these tests / expectations change, they'll need to
be updated in two locations, but I believe these are stable and shouldn't
change much in the short-term.

BUG= 660477 

Review-Url: https://codereview.chromium.org/2772553002
Cr-Commit-Position: refs/heads/master@{#459331}

[add] https://crrev.com/1f10d44710039f6b1b2437cfc2819295659ff7d0/third_party/WebKit/Source/devtools/tests/README.md
[rename] https://crrev.com/1f10d44710039f6b1b2437cfc2819295659ff7d0/third_party/WebKit/Source/devtools/tests/compatibility/TestExpectations
[add] https://crrev.com/1f10d44710039f6b1b2437cfc2819295659ff7d0/third_party/WebKit/Source/devtools/tests/console/console-assert-expected.txt
[add] https://crrev.com/1f10d44710039f6b1b2437cfc2819295659ff7d0/third_party/WebKit/Source/devtools/tests/console/console-assert.html
[add] https://crrev.com/1f10d44710039f6b1b2437cfc2819295659ff7d0/third_party/WebKit/Source/devtools/tests/console/console-clear-expected.txt
[add] https://crrev.com/1f10d44710039f6b1b2437cfc2819295659ff7d0/third_party/WebKit/Source/devtools/tests/console/console-clear-function-expected.txt
[add] https://crrev.com/1f10d44710039f6b1b2437cfc2819295659ff7d0/third_party/WebKit/Source/devtools/tests/console/console-clear-function.html
[add] https://crrev.com/1f10d44710039f6b1b2437cfc2819295659ff7d0/third_party/WebKit/Source/devtools/tests/console/console-clear.html
[add] https://crrev.com/1f10d44710039f6b1b2437cfc2819295659ff7d0/third_party/WebKit/Source/devtools/tests/console/console-command-copy-expected.txt
[add] https://crrev.com/1f10d44710039f6b1b2437cfc2819295659ff7d0/third_party/WebKit/Source/devtools/tests/console/console-command-copy.html

Comment 3 by chenwilliam@chromium.org, Apr 20 2017

Status: WontFix (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08c6f22d4e4071256941191f319dcbc9c7b9f741

commit 08c6f22d4e4071256941191f319dcbc9c7b9f741
Author: chenwilliam <chenwilliam@chromium.org>
Date: Thu Apr 20 20:27:47 2017

DevTools: delete copied tests and update readme

BUG= 660477 

Review-Url: https://codereview.chromium.org/2829663005
Cr-Commit-Position: refs/heads/master@{#466110}

[modify] https://crrev.com/08c6f22d4e4071256941191f319dcbc9c7b9f741/third_party/WebKit/Source/devtools/tests/README.md
[delete] https://crrev.com/8c4b1490ea9281f0cd6189d2f79ebc3f97e74ad3/third_party/WebKit/Source/devtools/tests/console/console-assert-expected.txt
[delete] https://crrev.com/8c4b1490ea9281f0cd6189d2f79ebc3f97e74ad3/third_party/WebKit/Source/devtools/tests/console/console-assert.html
[delete] https://crrev.com/8c4b1490ea9281f0cd6189d2f79ebc3f97e74ad3/third_party/WebKit/Source/devtools/tests/console/console-clear-expected.txt
[delete] https://crrev.com/8c4b1490ea9281f0cd6189d2f79ebc3f97e74ad3/third_party/WebKit/Source/devtools/tests/console/console-clear-function-expected.txt
[delete] https://crrev.com/8c4b1490ea9281f0cd6189d2f79ebc3f97e74ad3/third_party/WebKit/Source/devtools/tests/console/console-clear-function.html
[delete] https://crrev.com/8c4b1490ea9281f0cd6189d2f79ebc3f97e74ad3/third_party/WebKit/Source/devtools/tests/console/console-clear.html
[delete] https://crrev.com/8c4b1490ea9281f0cd6189d2f79ebc3f97e74ad3/third_party/WebKit/Source/devtools/tests/console/console-command-copy-expected.txt
[delete] https://crrev.com/8c4b1490ea9281f0cd6189d2f79ebc3f97e74ad3/third_party/WebKit/Source/devtools/tests/console/console-command-copy.html
►

Sign in to add a comment