New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 660474 link

Starred by 1 user
Status: Verified
Owner: ----
Closed: Apr 2017
Cc:
aarya@google.com
█ kateso...@chromium.org
mbarbe...@chromium.org
infe...@chromium.org
st...@chromium.org
█ robert...@chromium.org
chanli@chromium.org
lijeffrey@chromium.org
liaoyuke@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 644372
issue 646189



Sign in to add a comment

[Findit] break dependency between ./common and ./lib/gitiles

Project Member Reported by wrengr@chromium.org, Oct 28 2016 
Nothing in ./lib should depend on anything in ./common, however there are a few cases where this occurs. 

* ./lib/gitiles/test/gitiles_repository_test.py depends on ./common/retry_http_client.py

* various things depend on ./common/time_util.py

Comment 1 by wrengr@chromium.org, Nov 3 2016

Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/7db2966deb7a599377da34981323f0790c4d58d3

commit 7db2966deb7a599377da34981323f0790c4d58d3
Author: katesonia <katesonia@chromium.org>
Date: Fri Nov 04 20:35:17 2016

[Predator] Move time_util from common/ to lib/, split code review related part in gitiles_repository to code_review_util

Also refactor the time zone part in gitile repository to use TimeZoneInfo in time_util.

BUG= 660474 

Review-Url: https://codereview.chromium.org/2480593002

[modify] https://crrev.com/7db2966deb7a599377da34981323f0790c4d58d3/appengine/findit/common/findit_testcase.py
[modify] https://crrev.com/7db2966deb7a599377da34981323f0790c4d58d3/appengine/findit/crash/crash_pipeline.py
[modify] https://crrev.com/7db2966deb7a599377da34981323f0790c4d58d3/appengine/findit/crash/findit.py
[modify] https://crrev.com/7db2966deb7a599377da34981323f0790c4d58d3/appengine/findit/findit_api.py
[modify] https://crrev.com/7db2966deb7a599377da34981323f0790c4d58d3/appengine/findit/handlers/crash/fracas_dashboard.py
[modify] https://crrev.com/7db2966deb7a599377da34981323f0790c4d58d3/appengine/findit/handlers/crash/fracas_result_feedback.py
[modify] https://crrev.com/7db2966deb7a599377da34981323f0790c4d58d3/appengine/findit/handlers/crash/test/fracas_dashboard_test.py
[modify] https://crrev.com/7db2966deb7a599377da34981323f0790c4d58d3/appengine/findit/handlers/crash/test/fracas_result_feedback_test.py
[modify] https://crrev.com/7db2966deb7a599377da34981323f0790c4d58d3/appengine/findit/handlers/crash/test/triage_fracas_analysis_test.py
[modify] https://crrev.com/7db2966deb7a599377da34981323f0790c4d58d3/appengine/findit/handlers/crash/triage_fracas_analysis.py
[modify] https://crrev.com/7db2966deb7a599377da34981323f0790c4d58d3/appengine/findit/handlers/flake/check_flake.py
[modify] https://crrev.com/7db2966deb7a599377da34981323f0790c4d58d3/appengine/findit/handlers/flake/list_flakes.py
[modify] https://crrev.com/7db2966deb7a599377da34981323f0790c4d58d3/appengine/findit/handlers/flake/test/list_flakes_test.py
[modify] https://crrev.com/7db2966deb7a599377da34981323f0790c4d58d3/appengine/findit/handlers/list_analyses.py
[modify] https://crrev.com/7db2966deb7a599377da34981323f0790c4d58d3/appengine/findit/handlers/test/triage_suspected_cl_test.py
[modify] https://crrev.com/7db2966deb7a599377da34981323f0790c4d58d3/appengine/findit/handlers/triage_analysis.py
[modify] https://crrev.com/7db2966deb7a599377da34981323f0790c4d58d3/appengine/findit/handlers/triage_suspected_cl.py
[modify] https://crrev.com/7db2966deb7a599377da34981323f0790c4d58d3/appengine/findit/handlers/try_job_dashboard.py
[add] https://crrev.com/7db2966deb7a599377da34981323f0790c4d58d3/appengine/findit/lib/gitiles/commit_util.py
[modify] https://crrev.com/7db2966deb7a599377da34981323f0790c4d58d3/appengine/findit/lib/gitiles/gitiles_repository.py
[add] https://crrev.com/7db2966deb7a599377da34981323f0790c4d58d3/appengine/findit/lib/gitiles/test/commit_util_test.py
[modify] https://crrev.com/7db2966deb7a599377da34981323f0790c4d58d3/appengine/findit/lib/gitiles/test/gitiles_repository_test.py
[rename] https://crrev.com/7db2966deb7a599377da34981323f0790c4d58d3/appengine/findit/lib/test/time_util_test.py
[rename] https://crrev.com/7db2966deb7a599377da34981323f0790c4d58d3/appengine/findit/lib/time_util.py
[modify] https://crrev.com/7db2966deb7a599377da34981323f0790c4d58d3/appengine/findit/model/base_suspected_cl.py
[modify] https://crrev.com/7db2966deb7a599377da34981323f0790c4d58d3/appengine/findit/model/base_triaged_model.py
[modify] https://crrev.com/7db2966deb7a599377da34981323f0790c4d58d3/appengine/findit/model/suspected_cl_confidence.py
[modify] https://crrev.com/7db2966deb7a599377da34981323f0790c4d58d3/appengine/findit/waterfall/analyze_build_failure_pipeline.py
[modify] https://crrev.com/7db2966deb7a599377da34981323f0790c4d58d3/appengine/findit/waterfall/build_failure_analysis_pipelines.py
[modify] https://crrev.com/7db2966deb7a599377da34981323f0790c4d58d3/appengine/findit/waterfall/build_util.py
[modify] https://crrev.com/7db2966deb7a599377da34981323f0790c4d58d3/appengine/findit/waterfall/flake/initialize_flake_pipeline.py
[modify] https://crrev.com/7db2966deb7a599377da34981323f0790c4d58d3/appengine/findit/waterfall/flake/recursive_flake_pipeline.py
[modify] https://crrev.com/7db2966deb7a599377da34981323f0790c4d58d3/appengine/findit/waterfall/flake/test/recursive_flake_pipeline_test.py
[modify] https://crrev.com/7db2966deb7a599377da34981323f0790c4d58d3/appengine/findit/waterfall/flake/trigger_flake_analyses_pipeline.py
[modify] https://crrev.com/7db2966deb7a599377da34981323f0790c4d58d3/appengine/findit/waterfall/identify_culprit_pipeline.py
[modify] https://crrev.com/7db2966deb7a599377da34981323f0790c4d58d3/appengine/findit/waterfall/send_notification_for_culprit_pipeline.py
[modify] https://crrev.com/7db2966deb7a599377da34981323f0790c4d58d3/appengine/findit/waterfall/suspected_cl_util.py
[modify] https://crrev.com/7db2966deb7a599377da34981323f0790c4d58d3/appengine/findit/waterfall/trigger_base_swarming_task_pipeline.py
[modify] https://crrev.com/7db2966deb7a599377da34981323f0790c4d58d3/appengine/findit/waterfall/trigger_swarming_task_pipeline.py
[modify] https://crrev.com/7db2966deb7a599377da34981323f0790c4d58d3/appengine/findit/waterfall/try_job_util.py

Comment 3 by st...@chromium.org, Apr 24 2017

Status: Verified (was: Available)
I believed this was fixed.
►

Sign in to add a comment