New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 660466 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 644372
issue 646189



Sign in to add a comment

[Findit] break dependencies re cache_decorator.py

Project Member Reported by wrengr@chromium.org, Oct 28 2016

Issue description

cache_decorator.py is the only file in the ./lib directory that depends on AppEngine stuff, and the only thing that depends on cache_decorator.py is ./lib/gitiles/gitiles_repository.py. Ideally we should break that dependency (so that the gitiles library is independent of AppEngine) by offering a non-cached version of GitilesRepository (as part of the gitiles library), with the cached version as a subclass (in some other directory like ./services/appengine_utils or something).

(Just to be clear, this ticket uses the terminology of https://codereview.chromium.org/2344443005/#ps240001)
 

Comment 1 by wrengr@chromium.org, Oct 28 2016

Description: Show this description

Comment 2 by wrengr@chromium.org, Oct 28 2016

Blocking: 646189
Status: Started (was: Assigned)
I can take care of this refactor while block by log linear implementation.

Comment 4 by st...@chromium.org, Dec 6 2016

Cc: -aarya@google.com wrengr@chromium.org
Owner: kateso...@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/8fbbd99499879846a74fe2f9e312a1e4b1bd7761

commit 8fbbd99499879846a74fe2f9e312a1e4b1bd7761
Author: katesonia <katesonia@chromium.org>
Date: Thu Dec 08 01:10:55 2016

[Culprit-Finder] Seperate gae related part in cache_decorator and gitile repository to gae_libs/

BUG= 660466 

Review-Url: https://codereview.chromium.org/2557553002

[modify] https://crrev.com/8fbbd99499879846a74fe2f9e312a1e4b1bd7761/appengine/findit/crash/crash_pipeline.py
[add] https://crrev.com/8fbbd99499879846a74fe2f9e312a1e4b1bd7761/appengine/findit/gae_libs/caches.py
[add] https://crrev.com/8fbbd99499879846a74fe2f9e312a1e4b1bd7761/appengine/findit/gae_libs/gitiles/__init__.py
[add] https://crrev.com/8fbbd99499879846a74fe2f9e312a1e4b1bd7761/appengine/findit/gae_libs/gitiles/cached_gitiles_repository.py
[add] https://crrev.com/8fbbd99499879846a74fe2f9e312a1e4b1bd7761/appengine/findit/gae_libs/test/__init__.py
[add] https://crrev.com/8fbbd99499879846a74fe2f9e312a1e4b1bd7761/appengine/findit/gae_libs/test/caches_test.py
[modify] https://crrev.com/8fbbd99499879846a74fe2f9e312a1e4b1bd7761/appengine/findit/handlers/crash/crash_handler.py
[modify] https://crrev.com/8fbbd99499879846a74fe2f9e312a1e4b1bd7761/appengine/findit/handlers/help_triage.py
[add] https://crrev.com/8fbbd99499879846a74fe2f9e312a1e4b1bd7761/appengine/findit/lib/cache.py
[modify] https://crrev.com/8fbbd99499879846a74fe2f9e312a1e4b1bd7761/appengine/findit/lib/cache_decorator.py
[modify] https://crrev.com/8fbbd99499879846a74fe2f9e312a1e4b1bd7761/appengine/findit/lib/gitiles/gitiles_repository.py
[modify] https://crrev.com/8fbbd99499879846a74fe2f9e312a1e4b1bd7761/appengine/findit/lib/gitiles/test/gitiles_repository_test.py
[modify] https://crrev.com/8fbbd99499879846a74fe2f9e312a1e4b1bd7761/appengine/findit/lib/test/cache_decorator_test.py
[modify] https://crrev.com/8fbbd99499879846a74fe2f9e312a1e4b1bd7761/appengine/findit/util_scripts/local_cache.py
[modify] https://crrev.com/8fbbd99499879846a74fe2f9e312a1e4b1bd7761/appengine/findit/util_scripts/script_util.py
[modify] https://crrev.com/8fbbd99499879846a74fe2f9e312a1e4b1bd7761/appengine/findit/util_scripts/test/local_cache_test.py
[modify] https://crrev.com/8fbbd99499879846a74fe2f9e312a1e4b1bd7761/appengine/findit/waterfall/build_failure_analysis.py
[modify] https://crrev.com/8fbbd99499879846a74fe2f9e312a1e4b1bd7761/appengine/findit/waterfall/extract_deps_info_pipeline.py
[modify] https://crrev.com/8fbbd99499879846a74fe2f9e312a1e4b1bd7761/appengine/findit/waterfall/flake/step_mapper.py
[modify] https://crrev.com/8fbbd99499879846a74fe2f9e312a1e4b1bd7761/appengine/findit/waterfall/identify_try_job_culprit_pipeline.py
[modify] https://crrev.com/8fbbd99499879846a74fe2f9e312a1e4b1bd7761/appengine/findit/waterfall/pull_changelog_pipeline.py
[modify] https://crrev.com/8fbbd99499879846a74fe2f9e312a1e4b1bd7761/appengine/findit/waterfall/send_notification_for_culprit_pipeline.py

Status: Fixed (was: Started)

Sign in to add a comment