New issue
Advanced search Search tips

Issue 660453 link

Starred by 1 user
Status: Fixed
Owner:
qyears...@chromium.org
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

depot_tools presubmit_suport: Remove deprecated function DoGetTrySlaves.

Project Member Reported by qyears...@chromium.org, Oct 28 2016 
DoGetTrySlaves was a function in presubmit_support that calls the function GetPreferredTrySlaves in PRESUBMIT files, which has been deprecated for some time.

Note, there is one use of GetPreferredTrySlaves in libyuv, but removing support shouldn't affect that (see https://bugs.chromium.org/p/libyuv/issues/detail?id=652)

CL to remove this: http://crrev.com/2453823002
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 31 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/136b49ff7e09d851bc677495a37bea1d87e102a7

commit 136b49ff7e09d851bc677495a37bea1d87e102a7
Author: qyearsley <qyearsley@chromium.org>
Date: Mon Oct 31 16:02:26 2016

depot_tools: Remove DoGetTrySlaves, GetTrySlavesExecuter, GetPreferredTrySlaves

Note: This CL originally just removed a deprecated use of Remove use of DoGetTrySlaves, suggested in http://crrev.com/2442153002, then was expanded to remove DoGetTrySlaves, GetPreferredTrySlaves and GetTrySlavesExecuter since these are all deprecated and unused.

BUG= 660453 

Review-Url: https://codereview.chromium.org/2453823002

[modify] https://crrev.com/136b49ff7e09d851bc677495a37bea1d87e102a7/git_cl.py
[modify] https://crrev.com/136b49ff7e09d851bc677495a37bea1d87e102a7/presubmit_support.py
[modify] https://crrev.com/136b49ff7e09d851bc677495a37bea1d87e102a7/tests/git_cl_test.py
[modify] https://crrev.com/136b49ff7e09d851bc677495a37bea1d87e102a7/tests/presubmit_unittest.py

Comment 2 by qyears...@chromium.org, Oct 31 2016

Status: Fixed (was: Started)
►

Sign in to add a comment