New issue
Advanced search Search tips

Issue 660446 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

swarmbucket task expire on windows

Project Member Reported by no...@chromium.org, Oct 28 2016

Issue description

When swarmbucket schedules a swarming task and sets priority to 30, swarming resets it to 100. As a result, Windows tasks often expire because there is a lot of tasks with priority 30. We need the same priority for existing and swarmbucket tasks.
 

Comment 1 by no...@chromium.org, Oct 28 2016

Status: Assigned (was: Untriaged)

Comment 2 by mar...@chromium.org, Oct 28 2016

swarmbucket's account needs to be considered a bot, e.g. be including in swarming-bots.
https://chrome-infra-auth.appspot.com/auth/groups#swarming-bots

Comment 3 by no...@chromium.org, Oct 28 2016

swarmbucket schedules tasks on behalf of users, so e.g. on behalf of maruel@chromium.org

is there a group where I can include project-chromium-tryjob-access, project-infra-tryjob-access groups?

Comment 4 by no...@chromium.org, Oct 28 2016

alternatively, can we check peer_identity in addition to current identity?

Comment 5 by mar...@chromium.org, Oct 28 2016

Humm interesting. I kinda forgot about that. TL;DR: Yes.

Comment 6 by no...@chromium.org, Oct 28 2016

Cc: vadimsh@chromium.org
i assume this is Yes to my question about peer_identity
It's better not to use peer_identity for any authorization decisions. It exists as a hint for debugging/tracing. Evaluating both main identity and peer_identity for authorization is path to an unnecessary complexity.

I think we need to introduce a new group for users that are allowed to post high-priority tasks and add 'bots', admin and CQ service account there. 

All CQ jobs are using CQ service account, e.g. https://chromium-swarm.appspot.com/user/task/3224ff6948c9d110 (look at 'Authenticated' field).

Comment 8 by no...@chromium.org, Oct 28 2016

i can implement #3/#7. maruel, wdyt?
I wonder what happens for a CQ job by a non member. It uses the account of the user who LGTM'ed?
Discussed offline. The groups needs to be updated, then we can just have swarming-privileged-users allowed to run high priority tasks (a one liner or so)
CQ always uses it's own account when scheduling through buildbucket.

Comment 13 by no...@chromium.org, Oct 31 2016

Status: Started (was: Assigned)
This also, naturally, affects boringssl. Nodir@ please make their setup for windows work too (but not for Android bots, because those are scarce and stip@ will kill me afterwards :D)
This also, naturally, affects boringssl. Nodir@ please make their setup for windows work too (but not for Android bots, because those are scarce and stip@ will kill me afterwards :D)

Comment 17 by no...@chromium.org, Oct 31 2016

does CQ schedule boringssl builds that you are concerned about?

Comment 18 by no...@chromium.org, Oct 31 2016

Status: Fixed (was: Started)
Components: Infra>Platform>Buildbucket

Sign in to add a comment